From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v2 05/11] Documentation: DT: bindings: mfd: add A33 GPADC binding Date: Fri, 10 Mar 2017 13:25:44 +0100 Message-ID: <20170310122544.wkbqnzq2twfciyaw@lukather> References: <20170310103921.19469-1-quentin.schulz@free-electrons.com> <20170310103921.19469-6-quentin.schulz@free-electrons.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ajqoqo3jtkceco4e" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20170310103921.19469-6-quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Quentin Schulz Cc: dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, knaack.h-Mmb7MZpHnFY@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org, stefan.mavrodiev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org List-Id: devicetree@vger.kernel.org --ajqoqo3jtkceco4e Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Fri, Mar 10, 2017 at 11:39:15AM +0100, Quentin Schulz wrote: > This patch adds documentation for the A33 GPADC binding. > > Signed-off-by: Quentin Schulz > --- > > added in v2 > > .../devicetree/bindings/mfd/sun4i-gpadc.txt | 59 ++++++++++++++++++++++ > 1 file changed, 59 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > > diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > new file mode 100644 > index 0000000..17242c8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > @@ -0,0 +1,59 @@ > +Allwinner SoCs' GPADC Device Tree bindings > +------------------------------------------ > +The Allwinner SoCs all have an ADC that can also act as a thermal sensor > +and sometimes as a touchscreen controller. > + > +Required properties: > + - compatible: "sun8i-a33-gpadc-iio", This doesn't match your example, and you shouldn't have IIO in there. Compatibles shouldn't be tied to a given framework, since that is Linux specific (and might even change in the future). Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --ajqoqo3jtkceco4e--