From: Pavel Machek <pavel@ucw.cz>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Russell King" <linux@armlinux.org.uk>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-leds@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 1/2] ARM: dts: BCM53573: Don't use nonexistent "default-off" LED trigger
Date: Fri, 10 Mar 2017 14:20:50 +0100 [thread overview]
Message-ID: <20170310132049.GC11875@amd> (raw)
In-Reply-To: <42bce8ea-f1dc-2018-33f1-d296ccd7b677@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
On Wed 2017-03-08 09:31:44, Florian Fainelli wrote:
> On 03/07/2017 10:41 PM, Rafał Miłecki wrote:
> > From: Rafał Miłecki <rafal@milecki.pl>
> >
> > Such a trigger doesn't exist in Linux and is not needed as LED is being
> > turned off by default. This could cause errors in LEDs core code when
> > trying to set default trigger.
> >
> > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>
> Since you are fixing something, what's the proper Fixes: tag for this
> commit? Likewise for the second patch.
Lets not make submitting patches any harder than it already is.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-03-10 13:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 6:41 [PATCH 1/2] ARM: dts: BCM53573: Don't use nonexistent "default-off" LED trigger Rafał Miłecki
2017-03-08 6:41 ` [PATCH 2/2] ARM: dts: BCM5301X: " Rafał Miłecki
2017-03-09 20:33 ` Florian Fainelli
2017-03-08 10:20 ` [PATCH 1/2] ARM: dts: BCM53573: " Pavel Machek
2017-03-08 17:31 ` Florian Fainelli
2017-03-08 22:20 ` Rafał Miłecki
2017-03-10 13:20 ` Pavel Machek [this message]
2017-03-10 17:44 ` Florian Fainelli
2017-03-09 20:33 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170310132049.GC11875@amd \
--to=pavel@ucw.cz \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).