From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH V3 4/4] dts/imx6q-b850v3: Use megachips-stdpxxxx-ge-b850v3-fw bridges (LVDS-DP++) Date: Mon, 13 Mar 2017 20:41:37 +0800 Message-ID: <20170313124134.GF3618@dragon> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Peter Senna Tschudin Cc: mark.rutland@arm.com, heiko@sntech.de, airlied@linux.ie, daniel.vetter@ffwll.ch, peter.senna@gmail.com, dri-devel@lists.freedesktop.org, tiwai@suse.com, thierry.reding@gmail.com, laurent.pinchart@ideasonboard.com, jslaby@suse.cz, martyn.welch@collabora.co.uk, Rob Herring , architt@codeaurora.org, mchehab@osg.samsung.com, linux@armlinux.org.uk, javier@dowhile0.org, treding@nvidia.com, linux@roeck-us.net, martin.donnelly@ge.com, devicetree@vger.kernel.org, p.zabel@pengutronix.de, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, eballetbo@gmail.com, Fabio Estevam , rmk+kernel@armlinux.org.uk, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, galak@codeaurora.org, enric.balletbo@collabora.com, akpm@linux-foundation.org, davem@davemloft.net List-Id: devicetree@vger.kernel.org On Fri, Mar 03, 2017 at 04:57:10PM +0100, Peter Senna Tschudin wrote: > Configures the megachips-stdpxxxx-ge-b850v3-fw bridges on the GE > B850v3 dts file. > > Cc: Laurent Pinchart > Cc: Martyn Welch > Cc: Martin Donnelly > Cc: Javier Martinez Canillas > Cc: Enric Balletbo i Serra > Cc: Philipp Zabel > Cc: Rob Herring > Cc: Fabio Estevam > Signed-off-by: Peter Senna Tschudin > --- > Unchanged since V1. > > arch/arm/boot/dts/imx6q-b850v3.dts | 68 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6q-b850v3.dts b/arch/arm/boot/dts/imx6q-b850v3.dts > index b237429..3ec54da 100644 > --- a/arch/arm/boot/dts/imx6q-b850v3.dts > +++ b/arch/arm/boot/dts/imx6q-b850v3.dts > @@ -72,6 +72,13 @@ > fsl,data-mapping = "spwg"; > fsl,data-width = <24>; > status = "okay"; > + > + port@4 { > + reg = <4>; Have a newline between property list and child node. > + lvds0_out: endpoint { > + remote-endpoint = <&stdp4028_in>; > + }; > + }; > }; > }; > > @@ -146,3 +153,64 @@ > &usdhc2 { > status = "disabled"; > }; > + > +&mux2_i2c2 { > + status = "okay"; This okay status doesn't seem really necessary to me. If it does, please put it at the end of property list. > + clock-frequency = <100000>; > + > + stdp4028@73 { > + compatible = "megachips,stdp4028-ge-b850v3-fw"; > + #address-cells = <1>; > + #size-cells = <0>; > + Drop this newline, as in general we do not add newline in middle of property list. > + reg = <0x73>; > + Ditto > + interrupt-parent = <&gpio2>; > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + stdp4028_in: endpoint { > + remote-endpoint = <&lvds0_out>; > + }; > + }; Have a newline between nodes. > + port@1 { > + reg = <1>; > + stdp4028_out: endpoint { > + remote-endpoint = <&stdp2690_in>; > + }; > + }; > + }; > + }; > + > + stdp2690@72 { Sort device nodes under bus in order of unit address. That said, stdp2690@72 should go before stdp4028@73. Shawn > + compatible = "megachips,stdp2690-ge-b850v3-fw"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + reg = <0x72>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + stdp2690_in: endpoint { > + remote-endpoint = <&stdp4028_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + stdp2690_out: endpoint { > + /* Connector for external display */ > + }; > + }; > + }; > + }; > +}; > -- > 2.9.3 >