From: Doug Berger <opendmb@gmail.com>
To: f.fainelli@gmail.com
Cc: robh+dt@kernel.org, mark.rutland@arm.com, davem@davemloft.net,
rafal@milecki.pl, xow@google.com, joel@jms.id.au,
jon.mason@broadcom.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
pgynther@google.com, jaedon.shin@gmail.com,
Doug Berger <opendmb@gmail.com>
Subject: [PATCH net-next 08/12] net: bcmgenet: correct return value of __bcmgenet_tx_reclaim
Date: Mon, 13 Mar 2017 17:41:38 -0700 [thread overview]
Message-ID: <20170314004142.4746-9-opendmb@gmail.com> (raw)
In-Reply-To: <20170314004142.4746-1-opendmb@gmail.com>
The reclaim function should return the number of buffer descriptors
reclaimed, not just the number corresponding to skb packets.
Also, remove the unnecessary computation when updating the consumer
index.
While this is not a functional problem it could degrade performance
of napi in a fragmented transmit stream.
Signed-off-by: Doug Berger <opendmb@gmail.com>
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index 1f94ba1773dd..d90d366b286f 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -1218,7 +1218,7 @@ static unsigned int __bcmgenet_tx_reclaim(struct net_device *dev,
}
ring->free_bds += txbds_processed;
- ring->c_index = (ring->c_index + txbds_processed) & DMA_C_INDEX_MASK;
+ ring->c_index = c_index;
dev->stats.tx_packets += pkts_compl;
dev->stats.tx_bytes += bytes_compl;
@@ -1231,7 +1231,7 @@ static unsigned int __bcmgenet_tx_reclaim(struct net_device *dev,
netif_tx_wake_queue(txq);
}
- return pkts_compl;
+ return txbds_processed;
}
static unsigned int bcmgenet_tx_reclaim(struct net_device *dev,
--
2.11.1
next prev parent reply other threads:[~2017-03-14 0:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 0:41 [PATCH net-next 00/12] net: bcmgenet: add support for GENETv5 Doug Berger
2017-03-14 0:41 ` [PATCH net-next 01/12] net: phy: bcm-phylib: replace obsolete EEE macro references Doug Berger
[not found] ` <20170314004142.4746-2-opendmb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-14 0:49 ` Florian Fainelli
2017-03-14 0:41 ` [PATCH net-next 02/12] net: phy: bcm7xxx: add support for 28nm EPHY Doug Berger
[not found] ` <20170314004142.4746-3-opendmb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-14 0:50 ` Florian Fainelli
2017-03-14 1:06 ` Andrew Lunn
2017-03-14 2:06 ` Doug Berger
[not found] ` <3e5f7ac9-7e97-60f1-3986-4045522a65f5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-14 2:43 ` Andrew Lunn
[not found] ` <20170314024320.GQ15842-g2DYL2Zd6BY@public.gmane.org>
2017-03-14 17:23 ` Doug Berger
2017-03-14 0:41 ` [PATCH net-next 03/12] net: bcmgenet: simplify circular pointer arithmetic Doug Berger
[not found] ` <20170314004142.4746-4-opendmb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-14 0:54 ` Florian Fainelli
2017-03-14 0:41 ` [PATCH net-next 04/12] net: bcmgenet: remove meaningless lines Doug Berger
[not found] ` <20170314004142.4746-5-opendmb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-14 0:55 ` Florian Fainelli
2017-03-14 0:41 ` [PATCH net-next 05/12] net: bcmgenet: manage dma interrupts in napi code Doug Berger
2017-03-14 0:55 ` Florian Fainelli
[not found] ` <20170314004142.4746-1-opendmb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-14 0:41 ` [PATCH net-next 06/12] net: bcmgenet: remove handling of wol interrupts from isr0 Doug Berger
[not found] ` <20170314004142.4746-7-opendmb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-14 0:56 ` Florian Fainelli
2017-03-14 4:53 ` [PATCH net-next 00/12] net: bcmgenet: add support for GENETv5 David Miller
2017-03-14 0:41 ` [PATCH net-next 07/12] net: bcmgenet: clear status to reduce spurious interrupts Doug Berger
[not found] ` <20170314004142.4746-8-opendmb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-14 0:56 ` Florian Fainelli
2017-03-14 0:41 ` Doug Berger [this message]
2017-03-14 0:57 ` [PATCH net-next 08/12] net: bcmgenet: correct return value of __bcmgenet_tx_reclaim Florian Fainelli
2017-03-14 0:41 ` [PATCH net-next 09/12] net: bcmgenet: return EOPNOTSUPP for unknown ioctl commands Doug Berger
2017-03-14 0:57 ` Florian Fainelli
2017-03-14 11:04 ` David Laight
2017-03-14 17:31 ` Doug Berger
2017-03-14 0:41 ` [PATCH net-next 10/12] dt-bindings: net: document bcmgenet WoL interrupt Doug Berger
[not found] ` <20170314004142.4746-11-opendmb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-14 0:58 ` Florian Fainelli
2017-03-20 22:09 ` Rob Herring
2017-03-14 0:41 ` [PATCH net-next 11/12] dt-bindings: net: update bcmgenet binding for GENETv5 Doug Berger
2017-03-14 0:58 ` Florian Fainelli
2017-03-14 0:41 ` [PATCH net-next 12/12] net: bcmgenet: add support for the GENETv5 hardware Doug Berger
[not found] ` <20170314004142.4746-13-opendmb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-14 0:59 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314004142.4746-9-opendmb@gmail.com \
--to=opendmb@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jaedon.shin@gmail.com \
--cc=joel@jms.id.au \
--cc=jon.mason@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pgynther@google.com \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=xow@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).