devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v2 06/12] dmaengine: sun6i: make gate bit in sun8i's DMA engines a common quirk
Date: Tue, 14 Mar 2017 09:40:13 +0530	[thread overview]
Message-ID: <20170314041013.GB2843@localhost> (raw)
In-Reply-To: <20170305133709.6288-7-icenowy-ymACFijhrKM@public.gmane.org>

On Sun, Mar 05, 2017 at 09:37:03PM +0800, Icenowy Zheng wrote:
> Originally we enable a special gate bit when the compatible indicates
> A23/33.
> 
> But according to BSP sources and user manuals, more SoCs will need this
> gate bit.
> 
> So make it a common quirk configured in the config struct.
> 
> The BSP source also indicates that A83T will need this gate bit (there's
> "SUN8IW6" in the #ifdef's), so also enable this gate bit for it.
> 
> Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
> ---
>  drivers/dma/sun6i-dma.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
> index a2358780ab2c..889fb24023cd 100644
> --- a/drivers/dma/sun6i-dma.c
> +++ b/drivers/dma/sun6i-dma.c
> @@ -101,6 +101,7 @@ struct sun6i_dma_config {
>  	u32 nr_max_channels;
>  	u32 nr_max_requests;
>  	u32 nr_max_vchans;
> +	bool gate_needed;

can you please explain what gate means here

-- 
~Vinod

  parent reply	other threads:[~2017-03-14  4:10 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-05 13:36 [PATCH v2 00/12] Add support for the audio codec on Allwinner V3s Icenowy Zheng
     [not found] ` <20170305133709.6288-1-icenowy-ymACFijhrKM@public.gmane.org>
2017-03-05 13:36   ` [PATCH v2 01/12] ASoC: sun8i-codec-analog: split out mic2 Icenowy Zheng
     [not found]     ` <20170305133709.6288-2-icenowy-ymACFijhrKM@public.gmane.org>
2017-03-06  3:43       ` Chen-Yu Tsai
2017-03-15 18:13       ` Applied "ASoC: sun8i-codec-analog: split out mic2" to the asoc tree Mark Brown
2017-03-05 13:36   ` [PATCH v2 02/12] ASoC: sun8i-codec-analog: split out line in Icenowy Zheng
     [not found]     ` <20170305133709.6288-3-icenowy-ymACFijhrKM@public.gmane.org>
2017-03-06  3:45       ` Chen-Yu Tsai
2017-03-15 18:13       ` Applied "ASoC: sun8i-codec-analog: split out line in" to the asoc tree Mark Brown
2017-03-05 13:37   ` [PATCH v2 03/12] ASoC: sun8i-codec-analog: split out mbias Icenowy Zheng
     [not found]     ` <20170305133709.6288-4-icenowy-ymACFijhrKM@public.gmane.org>
2017-03-05 13:49       ` Icenowy Zheng
     [not found]         ` <6803451488721799-eo/M/X53CP1xpj1cXAZ9Bg@public.gmane.org>
2017-03-06  3:46           ` Chen-Yu Tsai
2017-03-07  0:15       ` [alsa-devel] " kbuild test robot
2017-03-05 13:37   ` [PATCH v2 04/12] ASoC: sun8i-codec-analog: add support for V3s SoC Icenowy Zheng
     [not found]     ` <20170305133709.6288-5-icenowy-ymACFijhrKM@public.gmane.org>
2017-03-06  3:53       ` Chen-Yu Tsai
2017-03-05 13:37   ` [PATCH v2 05/12] ASoC: sun4i-codec: Add support for V3s codec Icenowy Zheng
     [not found]     ` <20170305133709.6288-6-icenowy-ymACFijhrKM@public.gmane.org>
2017-03-06  4:05       ` Chen-Yu Tsai
     [not found]         ` <CAGb2v66TZj7EjcAf3PyYky5adjTc4xdHUAh7jFChe2LWs7cYjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-06  4:15           ` Chen-Yu Tsai
2017-03-05 13:37   ` [PATCH v2 06/12] dmaengine: sun6i: make gate bit in sun8i's DMA engines a common quirk Icenowy Zheng
     [not found]     ` <20170305133709.6288-7-icenowy-ymACFijhrKM@public.gmane.org>
2017-03-06  3:50       ` Chen-Yu Tsai
2017-03-14  4:10       ` Vinod Koul [this message]
2017-03-05 13:37   ` [PATCH v2 07/12] dmaengine: sun6i: support V3s SoC variant Icenowy Zheng
2017-03-06  3:58     ` [linux-sunxi] " Chen-Yu Tsai
2017-03-05 13:37   ` [PATCH v2 08/12] ARM: dts: sun8i: restore the inclusion of ccu headers in V3s DTSI Icenowy Zheng
     [not found]     ` <20170305133709.6288-9-icenowy-ymACFijhrKM@public.gmane.org>
2017-03-06  4:12       ` Chen-Yu Tsai
2017-03-05 13:37   ` [PATCH v2 09/12] ARM: dts: sun8i: add DMA engine " Icenowy Zheng
     [not found]     ` <20170305133709.6288-10-icenowy-ymACFijhrKM@public.gmane.org>
2017-03-06  4:13       ` Chen-Yu Tsai
2017-03-05 13:37   ` [PATCH v2 10/12] ARM: dts: sun8i: add audio codec support into " Icenowy Zheng
     [not found]     ` <20170305133709.6288-11-icenowy-ymACFijhrKM@public.gmane.org>
2017-03-06  4:17       ` Chen-Yu Tsai
2017-03-05 13:37   ` [PATCH v2 11/12] ARM: dts: sun8i: add pinmux for V3s mmc1 Icenowy Zheng
     [not found]     ` <20170305133709.6288-12-icenowy-ymACFijhrKM@public.gmane.org>
2017-03-06  4:22       ` Chen-Yu Tsai
2017-03-05 13:37   ` [PATCH v2 12/12] ARM: dts: sun8i: add device tree for Lichee Pi Zero with Dock Icenowy Zheng
     [not found]     ` <20170305133709.6288-13-icenowy-ymACFijhrKM@public.gmane.org>
2017-03-06  4:28       ` Chen-Yu Tsai
2017-03-07  8:57   ` [PATCH v2 00/12] Add support for the audio codec on Allwinner V3s Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170314041013.GB2843@localhost \
    --to=vinod.koul-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=icenowy-ymACFijhrKM@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=wens-jdAy2FN1RRM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).