* [PATCH] ARM: dts: mvebu: linksys: enable buffer manager support
@ 2017-03-08 5:33 Ralph Sennhauser
[not found] ` <20170308053312.29243-1-ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Ralph Sennhauser @ 2017-03-08 5:33 UTC (permalink / raw)
To: Gregory Clement
Cc: Ralph Sennhauser, Jason Cooper, Andrew Lunn,
Sebastian Hesselbarth, Rob Herring, Mark Rutland, Russell King,
moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,...,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Add appropriate properties to devices in the Linksys WRT AC Series for the
mvneta driver to use hardware buffer management.
Also update "soc" ranges property and set the status of bm and bm-bppi
to "okay" (SRAM).
Signed-off-by: Ralph Sennhauser <ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/boot/dts/armada-385-linksys.dtsi | 17 ++++++++++++++++-
arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 17 ++++++++++++++++-
2 files changed, 32 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/armada-385-linksys.dtsi b/arch/arm/boot/dts/armada-385-linksys.dtsi
index df47bf1..4aac375 100644
--- a/arch/arm/boot/dts/armada-385-linksys.dtsi
+++ b/arch/arm/boot/dts/armada-385-linksys.dtsi
@@ -59,7 +59,8 @@
ranges = <MBUS_ID(0xf0, 0x01) 0 0xf1000000 0x100000
MBUS_ID(0x01, 0x1d) 0 0xfff00000 0x100000
MBUS_ID(0x09, 0x19) 0 0xf1100000 0x10000
- MBUS_ID(0x09, 0x15) 0 0xf1110000 0x10000>;
+ MBUS_ID(0x09, 0x15) 0 0xf1110000 0x10000
+ MBUS_ID(0x0c, 0x04) 0 0xf1200000 0x100000>;
internal-regs {
i2c@11000 {
@@ -88,6 +89,9 @@
ethernet@70000 {
status = "okay";
phy-mode = "rgmii-id";
+ buffer-manager = <&bm>;
+ bm,pool-long = <1>;
+ bm,pool-short = <3>;
fixed-link {
speed = <1000>;
full-duplex;
@@ -97,6 +101,9 @@
ethernet@34000 {
status = "okay";
phy-mode = "sgmii";
+ buffer-manager = <&bm>;
+ bm,pool-long = <0>;
+ bm,pool-short = <3>;
fixed-link {
speed = <1000>;
full-duplex;
@@ -159,6 +166,10 @@
status = "okay";
};
+ bm@c8000 {
+ status = "okay";
+ };
+
/* USB part of the eSATA/USB 2.0 port */
usb@58000 {
status = "okay";
@@ -241,6 +252,10 @@
};
};
+ bm-bppi {
+ status = "okay";
+ };
+
pcie-controller {
status = "okay";
diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
index 3744ba3..b188a4dc 100644
--- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
+++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
@@ -71,7 +71,8 @@
ranges = <MBUS_ID(0xf0, 0x01) 0 0 0xf1000000 0x100000
MBUS_ID(0x01, 0x1d) 0 0 0xfff00000 0x100000
MBUS_ID(0x09, 0x09) 0 0 0xf1100000 0x10000
- MBUS_ID(0x09, 0x05) 0 0 0xf1110000 0x10000>;
+ MBUS_ID(0x09, 0x05) 0 0 0xf1110000 0x10000
+ MBUS_ID(0x0c, 0x04) 0 0 0xf1200000 0x100000>;
internal-regs {
@@ -95,6 +96,9 @@
pinctrl-names = "default";
status = "okay";
phy-mode = "rgmii-id";
+ buffer-manager = <&bm>;
+ bm,pool-long = <0>;
+ bm,pool-short = <3>;
fixed-link {
speed = <1000>;
full-duplex;
@@ -106,6 +110,9 @@
pinctrl-names = "default";
status = "okay";
phy-mode = "rgmii-id";
+ buffer-manager = <&bm>;
+ bm,pool-long = <1>;
+ bm,pool-short = <3>;
fixed-link {
speed = <1000>;
full-duplex;
@@ -186,6 +193,10 @@
};
};
+ bm@c8000 {
+ status = "okay";
+ };
+
nand@d0000 {
status = "okay";
num-cs = <1>;
@@ -259,6 +270,10 @@
};
};
};
+
+ bm-bppi {
+ status = "okay";
+ };
};
gpio_keys {
--
2.10.2
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: mvebu: linksys: enable buffer manager support
[not found] ` <20170308053312.29243-1-ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2017-03-15 19:17 ` Gregory CLEMENT
[not found] ` <8760jafiy8.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Gregory CLEMENT @ 2017-03-15 19:17 UTC (permalink / raw)
To: Ralph Sennhauser
Cc: Jason Cooper, Andrew Lunn, Sebastian Hesselbarth, Rob Herring,
Mark Rutland, Russell King,
moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,...,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Hi Ralph,
On mer., mars 08 2017, Ralph Sennhauser <ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Add appropriate properties to devices in the Linksys WRT AC Series for the
> mvneta driver to use hardware buffer management.
>
> Also update "soc" ranges property and set the status of bm and bm-bppi
> to "okay" (SRAM).
>
> Signed-off-by: Ralph Sennhauser <ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> arch/arm/boot/dts/armada-385-linksys.dtsi | 17 ++++++++++++++++-
> arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 17 ++++++++++++++++-
> 2 files changed, 32 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-linksys.dtsi b/arch/arm/boot/dts/armada-385-linksys.dtsi
> index df47bf1..4aac375 100644
> --- a/arch/arm/boot/dts/armada-385-linksys.dtsi
> +++ b/arch/arm/boot/dts/armada-385-linksys.dtsi
> @@ -59,7 +59,8 @@
> ranges = <MBUS_ID(0xf0, 0x01) 0 0xf1000000 0x100000
> MBUS_ID(0x01, 0x1d) 0 0xfff00000 0x100000
> MBUS_ID(0x09, 0x19) 0 0xf1100000 0x10000
> - MBUS_ID(0x09, 0x15) 0 0xf1110000 0x10000>;
> + MBUS_ID(0x09, 0x15) 0 0xf1110000 0x10000
> + MBUS_ID(0x0c, 0x04) 0 0xf1200000 0x100000>;
>
> internal-regs {
> i2c@11000 {
> @@ -88,6 +89,9 @@
> ethernet@70000 {
> status = "okay";
> phy-mode = "rgmii-id";
> + buffer-manager = <&bm>;
> + bm,pool-long = <1>;
> + bm,pool-short = <3>;
> fixed-link {
> speed = <1000>;
> full-duplex;
> @@ -97,6 +101,9 @@
> ethernet@34000 {
> status = "okay";
> phy-mode = "sgmii";
> + buffer-manager = <&bm>;
> + bm,pool-long = <0>;
> + bm,pool-short = <3>;
Any reason to reuse the same pool than the other port?
As only two ports are used here, then each of them can have use 2 of the
4 availables pools.
> fixed-link {
> speed = <1000>;
> full-duplex;
> @@ -159,6 +166,10 @@
> status = "okay";
> };
>
> + bm@c8000 {
> + status = "okay";
> + };
> +
> /* USB part of the eSATA/USB 2.0 port */
> usb@58000 {
> status = "okay";
> @@ -241,6 +252,10 @@
> };
> };
>
> + bm-bppi {
> + status = "okay";
> + };
> +
> pcie-controller {
> status = "okay";
>
> diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> index 3744ba3..b188a4dc 100644
> --- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> +++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> @@ -71,7 +71,8 @@
> ranges = <MBUS_ID(0xf0, 0x01) 0 0 0xf1000000 0x100000
> MBUS_ID(0x01, 0x1d) 0 0 0xfff00000 0x100000
> MBUS_ID(0x09, 0x09) 0 0 0xf1100000 0x10000
> - MBUS_ID(0x09, 0x05) 0 0 0xf1110000 0x10000>;
> + MBUS_ID(0x09, 0x05) 0 0 0xf1110000 0x10000
> + MBUS_ID(0x0c, 0x04) 0 0 0xf1200000 0x100000>;
>
> internal-regs {
>
> @@ -95,6 +96,9 @@
> pinctrl-names = "default";
> status = "okay";
> phy-mode = "rgmii-id";
> + buffer-manager = <&bm>;
> + bm,pool-long = <0>;
> + bm,pool-short = <3>;
> fixed-link {
> speed = <1000>;
> full-duplex;
> @@ -106,6 +110,9 @@
> pinctrl-names = "default";
> status = "okay";
> phy-mode = "rgmii-id";
> + buffer-manager = <&bm>;
> + bm,pool-long = <1>;
> + bm,pool-short = <3>;
Same question that above.
Gregory
> fixed-link {
> speed = <1000>;
> full-duplex;
> @@ -186,6 +193,10 @@
> };
> };
>
> + bm@c8000 {
> + status = "okay";
> + };
> +
> nand@d0000 {
> status = "okay";
> num-cs = <1>;
> @@ -259,6 +270,10 @@
> };
> };
> };
> +
> + bm-bppi {
> + status = "okay";
> + };
> };
>
> gpio_keys {
> --
> 2.10.2
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: mvebu: linksys: enable buffer manager support
[not found] ` <8760jafiy8.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
@ 2017-03-16 5:48 ` Ralph Sennhauser
0 siblings, 0 replies; 3+ messages in thread
From: Ralph Sennhauser @ 2017-03-16 5:48 UTC (permalink / raw)
To: Gregory CLEMENT
Cc: Jason Cooper, Andrew Lunn, Sebastian Hesselbarth, Rob Herring,
Mark Rutland, Russell King,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Wed, 15 Mar 2017 20:17:35 +0100
Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> Hi Ralph,
>
> On mer., mars 08 2017, Ralph Sennhauser <ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> wrote:
>
> </snip>
>
> > @@ -88,6 +89,9 @@
> > ethernet@70000 {
> > status = "okay";
> > phy-mode = "rgmii-id";
> > + buffer-manager = <&bm>;
> > + bm,pool-long = <1>;
> > + bm,pool-short = <3>;
> > fixed-link {
> > speed = <1000>;
> > full-duplex;
> > @@ -97,6 +101,9 @@
> > ethernet@34000 {
> > status = "okay";
> > phy-mode = "sgmii";
> > + buffer-manager = <&bm>;
> > + bm,pool-long = <0>;
> > + bm,pool-short = <3>;
> Any reason to reuse the same pool than the other port?
>
> As only two ports are used here, then each of them can have use 2 of
> the 4 availables pools.
>
> </snip>
Hi Gregory,
It has been quite a while since I have written that patch. Something
written somewhere in the Documentation / commit message which I can't
find anymore gave me the impression that using the same for short
doesn't make a difference. So I went with the pool IDs used for other
similar boards for "consistency".
Will send a v2 shortly using all independent pools using the IDs witch
come most natural in context.
Thanks
Ralph
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-16 5:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-08 5:33 [PATCH] ARM: dts: mvebu: linksys: enable buffer manager support Ralph Sennhauser
[not found] ` <20170308053312.29243-1-ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-15 19:17 ` Gregory CLEMENT
[not found] ` <8760jafiy8.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2017-03-16 5:48 ` Ralph Sennhauser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).