From mboxrd@z Thu Jan 1 00:00:00 1970 From: "maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org" Subject: Re: [PATCH v2 05/11] Documentation: DT: bindings: mfd: add A33 GPADC binding Date: Mon, 20 Mar 2017 09:45:27 +0100 Message-ID: <20170320084527.7cah2g7doas7ykyf@lukather> References: <20170310103921.19469-1-quentin.schulz@free-electrons.com> <20170310103921.19469-6-quentin.schulz@free-electrons.com> <5798131489173902@web12o.yandex.ru> <6d997cc1-585e-e25c-a53f-d7b28613dfbb@free-electrons.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="w3ydkscm76ah7w4j" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <6d997cc1-585e-e25c-a53f-d7b28613dfbb-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Quentin Schulz Cc: Icenowy Zheng , "dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "mark.rutland-5wv7dgnIgG8@public.gmane.org" , "wens-jdAy2FN1RRM@public.gmane.org" , "lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org" , "jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "knaack.h-Mmb7MZpHnFY@public.gmane.org" , "lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org" , "pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org" , "stefan.mavrodiev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org --w3ydkscm76ah7w4j Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi, On Sat, Mar 11, 2017 at 03:07:55PM +0100, Quentin Schulz wrote: > Hi Icenowy, > > On 10/03/2017 20:25, Icenowy Zheng wrote: > > > > > > 10.03.2017, 18:56, "Quentin Schulz" : > >> This patch adds documentation for the A33 GPADC binding. > >> > >> Signed-off-by: Quentin Schulz > >> --- > >> > >> added in v2 > >> > >> .../devicetree/bindings/mfd/sun4i-gpadc.txt | 59 ++++++++++++++++++++++ > >> 1 file changed, 59 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > >> > >> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > >> new file mode 100644 > >> index 0000000..17242c8 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt > >> @@ -0,0 +1,59 @@ > >> +Allwinner SoCs' GPADC Device Tree bindings > >> +------------------------------------------ > >> +The Allwinner SoCs all have an ADC that can also act as a thermal sensor > >> +and sometimes as a touchscreen controller. > >> + > >> +Required properties: > >> + - compatible: "sun8i-a33-gpadc-iio", > >> + - reg: mmio address range of the chip, > >> + - #thermal-sensor-cells: shall be 0, > >> + - #io-channel-cells: shall be 0, > >> + > >> +Example: > >> + rtp: rtp@01c25000 { > > > > I think we'd better call it ths. > > To match the datasheet, I agree. I agree too. > > And can you make thermal-sensor-cells become 1? > > > > Maxime Ripard wants to base H3/H5/A64 thermal driver on this patchset, and > > for H5/A64 there's 2/3 thermal sensors. > > Yes, that'll require a specific DT node for those thermal sensors. Then > since we would update the possible compatibles in the documentation > anyway, that would be a good idea to update to say that > thermal-sensor-cells could be different from 0 too. > > That was my mindset to set thermal-sensor-cells to 0, since we only > support SoC which has only one thermal sensor at the moment. And I agree here as well. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --w3ydkscm76ah7w4j--