From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH 2/2] arm64: dts: add arm/arm64 include symlinks Date: Mon, 20 Mar 2017 16:03:37 -0700 Message-ID: <20170320230337.GB78325@google.com> References: <20170226060058.5841-1-heiko@sntech.de> <20170226060058.5841-2-heiko@sntech.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170226060058.5841-2-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Heiko Stuebner Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On Sun, Feb 26, 2017 at 07:00:58AM +0100, Heiko Stuebner wrote: > Allow including of dtsi files in an architecture-independent manner. > Some dtsi files may be shared between architectures and one suggestion > was to have symlinks and let these includes get accessed via a > #include > So add the necessary symlinks for arm32. > > Suggested-by: Olof Johansson > Signed-off-by: Heiko Stuebner > --- > Suggested by Olof in response to the patch adding direct symlinks > for cros-ec includes. > > Tested with adapted rk3399-Gru dtsi files and while we only need this arm64 > version right now, it might make sense to already have both the arm32 and > arm64 versions ready. FWIW, tested fine here too (for the same platform). I guess this works fine, if it makes people happy. It also allows some weird #include paths. e.g.: #include I guess we can call that an entertaining feature, and not a bug? Reviewed-by: Brian Norris Tested-by: Brian Norris Where should this go? I'd like not to wait another few months before sending my Gru/Kevin DTS again. Brian > arch/arm64/boot/dts/include/arm | 1 + > arch/arm64/boot/dts/include/arm64 | 1 + > 2 files changed, 2 insertions(+) > create mode 120000 arch/arm64/boot/dts/include/arm > create mode 120000 arch/arm64/boot/dts/include/arm64 > > diff --git a/arch/arm64/boot/dts/include/arm b/arch/arm64/boot/dts/include/arm > new file mode 120000 > index 000000000000..cf63d80e2b93 > --- /dev/null > +++ b/arch/arm64/boot/dts/include/arm > @@ -0,0 +1 @@ > +../../../../arm/boot/dts > \ No newline at end of file > diff --git a/arch/arm64/boot/dts/include/arm64 b/arch/arm64/boot/dts/include/arm64 > new file mode 120000 > index 000000000000..a96aa0ea9d8c > --- /dev/null > +++ b/arch/arm64/boot/dts/include/arm64 > @@ -0,0 +1 @@ > +.. > \ No newline at end of file > -- > 2.11.0 >