From: Sebastian Reichel <sre@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-pm@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, Marcel Partap <mpartap@gmx.net>,
Michael Scott <michael.scott@linaro.org>
Subject: Re: [PATCH] power: supply: cpcap-charger: Add minimal CPCAP PMIC battery charger
Date: Wed, 22 Mar 2017 03:15:14 +0100 [thread overview]
Message-ID: <20170322021514.ewipilqbfm2cwua6@earth> (raw)
In-Reply-To: <20170317022152.21427-1-tony@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 816 bytes --]
Hi,
On Thu, Mar 16, 2017 at 07:21:52PM -0700, Tony Lindgren wrote:
> The custom CPCAP PMIC used on Motorola phones such as Droid 4 has a
> USB battery charger. It can optionally also have a companion chip that
> is used for wireless charging.
>
> The charger on CPCAP also can feed VBUS for the USB host mode. This
> can be handled by the existing kernel phy_companion interface.
>
> Cc: devicetree@vger.kernel.org
> Cc: Marcel Partap <mpartap@gmx.net>
> Cc: Michael Scott <michael.scott@linaro.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Driver looks ok and works for me, but values are not scaled
correctly. The power-supply subsystem exposes values in microamps
and microvolt. IIO provides values in millivolt/milliamps instead,
so it should be scaled with 1000.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-03-22 2:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 2:21 [PATCH] power: supply: cpcap-charger: Add minimal CPCAP PMIC battery charger Tony Lindgren
2017-03-22 2:15 ` Sebastian Reichel [this message]
2017-03-22 17:22 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322021514.ewipilqbfm2cwua6@earth \
--to=sre@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=michael.scott@linaro.org \
--cc=mpartap@gmx.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox