From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v3 02/11] ARM: sun8i: a33: add all operating points Date: Wed, 22 Mar 2017 08:16:57 +0100 Message-ID: <20170322071657.omlvxykz5ans357o@lukather> References: <20170321153611.16228-1-quentin.schulz@free-electrons.com> <20170321153611.16228-3-quentin.schulz@free-electrons.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gqje5lszmbmjyqtz" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Quentin Schulz , Dmitry Torokhov , Rob Herring , Mark Rutland , Lee Jones , Russell King , Jonathan Cameron , knaack.h-Mmb7MZpHnFY@public.gmane.org, Lars-Peter Clausen , Peter Meerwald-Stadler , Thomas Petazzoni , "linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , devicetree , linux-arm-kernel , linux-kernel , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi , Icenowy Zheng List-Id: devicetree@vger.kernel.org --gqje5lszmbmjyqtz Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Wed, Mar 22, 2017 at 11:31:54AM +0800, Chen-Yu Tsai wrote: > On Tue, Mar 21, 2017 at 11:36 PM, Quentin Schulz > wrote: > > This adds almost all operating points allowed for the A33 as defined by > > fex files available at: > > https://github.com/linux-sunxi/sunxi-boards/tree/master/sys_config/a33 > > > > There are more possible frequencies in this patch than there are in the > > fex files because the fex files only give an interval of possible > > frequencies for a given voltage. All supported frequencies are defined > > in the original driver code in Allwinner vendor tree. > > > > There are two missing frequencies though: 1104MHz and 1200MHz which > > require the CPU to have 1.32V supplied, which is higher than the default > > voltage. > > > > Without all A33 boards defining the CPU regulator, we cannot have these > > two frequencies as it would cause the CPU to try to run a higher > > frequency without "overvolting" which is very likely to crash the CPU. > > > > Therefore, these two frequencies must be enabled on a per-board basis. > > > > Signed-off-by: Quentin Schulz > > Acked-by: Chen-Yu Tsai Applied, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --gqje5lszmbmjyqtz--