devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Sebastian Reichel <sre@kernel.org>,
	Richard Purdie <rpurdie@rpsys.net>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies
Date: Wed, 22 Mar 2017 08:57:16 -0700	[thread overview]
Message-ID: <20170322155716.GC10760@atomide.com> (raw)
In-Reply-To: <20170322092708.GA26771@amd>

* Pavel Machek <pavel@ucw.cz> [170322 02:29]:
> On Wed 2017-03-22 01:09:11, Sebastian Reichel wrote:
> > This fixes compilation for files, that try to include the
> > cpcap header in alphabetically sorted #include lists.
> > 
> > Signed-off-by: Sebastian Reichel <sre@kernel.org>
> 
> Acked-by: Pavel Machek <pavel@ucw.cz>

Hmm I wonder why I never ran into this so far. No objections
to the patch though if it fixes the issue with all the necessary
headers included.

Regards,

Tony


> > ---
> > This patch is new, since PATCHv1 did not order the includes
> > in the led driver alphabetically.
> > ---
> >  include/linux/mfd/motorola-cpcap.h | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/include/linux/mfd/motorola-cpcap.h b/include/linux/mfd/motorola-cpcap.h
> > index 7629e0d24d26..b8916953a537 100644
> > --- a/include/linux/mfd/motorola-cpcap.h
> > +++ b/include/linux/mfd/motorola-cpcap.h
> > @@ -14,6 +14,9 @@
> >   * published by the Free Software Foundation.
> >   */
> >  
> > +#include <linux/device.h>
> > +#include <linux/regmap.h>
> > +
> >  #define CPCAP_VENDOR_ST		0
> >  #define CPCAP_VENDOR_TI		1
> >  
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2017-03-22 15:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22  0:09 [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Sebastian Reichel
2017-03-22  0:09 ` [PATCHv2 2/2] leds: cpcap: new driver Sebastian Reichel
2017-03-22 20:24   ` Jacek Anaszewski
     [not found]     ` <30b1d220-730e-445d-cab1-8bb776a5b917-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-23  1:04       ` Sebastian Reichel
2017-03-22  9:27 ` [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Pavel Machek
2017-03-22 15:57   ` Tony Lindgren [this message]
     [not found]     ` <20170322155716.GC10760-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-03-23  1:00       ` Sebastian Reichel
2017-03-23 14:52         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170322155716.GC10760@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=rpurdie@rpsys.net \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).