From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Jagan Teki <jagan@openedev.com>,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Matteo Lisi <matteo.lisi@engicam.com>,
Michael Trimarchi <michael@amarulasolutions.com>
Subject: Re: [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table
Date: Wed, 22 Mar 2017 11:44:21 -0700 [thread overview]
Message-ID: <20170322184421.GB2899@dtor-ws> (raw)
In-Reply-To: <CAMty3ZApz+GVkeoT4-75tiJcn6-CxkzdOrMcH7hjK1k2Ht=ZUQ@mail.gmail.com>
On Thu, Mar 23, 2017 at 12:05:17AM +0530, Jagan Teki wrote:
> On Thu, Mar 23, 2017 at 12:00 AM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Wed, Mar 22, 2017 at 04:36:46PM +0530, Jagan Teki wrote:
> >> From: Jagan Teki <jagan@amarulasolutions.com>
> >>
> >> Added missing of_match_table for max11801_ts driver with
> >> compatible as "maxim,max11801_ts"
> >>
> >
> > Why not "maxim,max11801"? Also, I think we'd need a binding document.
>
> Compatibility purpose to make this is for touchscreen and few of other
Compatibility with what? The i2c id is "max11801" (without the "-ts").
> *_ts.c files follow the same, and added binding documentation in 2/3
> patch.
Sorry, it seems I am only copied on 1/3 patch.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2017-03-22 18:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 11:06 [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table Jagan Teki
2017-03-22 11:06 ` [PATCH v7 2/3] dt-bindings: input: touchscreen: Add max11801-ts binding Jagan Teki
2017-03-22 11:06 ` [PATCH v7 3/3] ARM: dts: imx6q-icore: Add touchscreen node Jagan Teki
[not found] ` <1490180808-2856-1-git-send-email-jagan-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>
2017-03-22 18:30 ` [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table Dmitry Torokhov
2017-03-22 18:35 ` Jagan Teki
2017-03-22 18:44 ` Dmitry Torokhov [this message]
2017-03-22 18:47 ` Dmitry Torokhov
2017-03-22 18:49 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322184421.GB2899@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jagan@amarulasolutions.com \
--cc=jagan@openedev.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matteo.lisi@engicam.com \
--cc=michael@amarulasolutions.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).