From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 1/3] ARM: sun8i: v3s: add LRADC device node Date: Wed, 22 Mar 2017 20:22:21 +0100 Message-ID: <20170322192221.yhtk6qmzqka4vssd@lukather> References: <20170317154343.39921-1-icenowy@aosc.xyz> <20170317154343.39921-2-icenowy@aosc.xyz> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qrs2aqduen5qwjgq" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20170317154343.39921-2-icenowy-ymACFijhrKM@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Icenowy Zheng Cc: Chen-Yu Tsai , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --qrs2aqduen5qwjgq Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Fri, Mar 17, 2017 at 11:43:41PM +0800, Icenowy Zheng wrote: > Allwinner V3s features a LRADC like the ones in older SoCs. > > Add a device tree node for it. > > Signed-off-by: Icenowy Zheng > --- > arch/arm/boot/dts/sun8i-v3s.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi > index 71075969e5e6..77bbf5ff9548 100644 > --- a/arch/arm/boot/dts/sun8i-v3s.dtsi > +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi > @@ -238,6 +238,13 @@ > interrupts = ; > }; > > + lradc: lradc@01c22800 { The node name should reflect the class of the device, so something like adc@.. > + compatible = "allwinner,sun4i-a10-lradc-keys"; Please put a SoC-specific compatible there. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --qrs2aqduen5qwjgq--