From: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jacek Anaszewski
<jacek.anaszewski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Richard Purdie <rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>,
Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCHv2 2/2] leds: cpcap: new driver
Date: Thu, 23 Mar 2017 02:04:43 +0100 [thread overview]
Message-ID: <20170323010443.uzv4xs3ne2mjpm7i@earth> (raw)
In-Reply-To: <30b1d220-730e-445d-cab1-8bb776a5b917-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 982 bytes --]
Hi Jacek,
On Wed, Mar 22, 2017 at 09:24:35PM +0100, Jacek Anaszewski wrote:
> > +#define CPCAP_LED_OFF 0x0000
> > +#define CPCAP_LED_ON 0x01
>
> In this case you can do very well without CPCAP_LED_OFF and
> CPCAP_LED_ON, since we have both counterparts in the core:
> LED_OFF and LED_ON.
I will use them in PATCHv3.
> > +static const struct of_device_id cpcap_led_of_match[] = {
> > + { .compatible = "motorola,cpcap-led-red", .data = &cpcap_led_red },
>
> checkpatch.pl complains here:
>
> WARNING: DT compatible string vendor "motorola" appears un-documented
>
> Are you adding vendor prefix in some other patch?
Yes, the vendor prefix is added in rtc-next [0].
Since it's just a checkpatch warning and fixed in linux-next I
suggest to ignore it instead of bothering with an immutable branch.
[0] https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next&id=0522de00929e9e9ee51235fc40035179e4d45381
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-03-23 1:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 0:09 [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Sebastian Reichel
2017-03-22 0:09 ` [PATCHv2 2/2] leds: cpcap: new driver Sebastian Reichel
2017-03-22 20:24 ` Jacek Anaszewski
[not found] ` <30b1d220-730e-445d-cab1-8bb776a5b917-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-23 1:04 ` Sebastian Reichel [this message]
2017-03-22 9:27 ` [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Pavel Machek
2017-03-22 15:57 ` Tony Lindgren
[not found] ` <20170322155716.GC10760-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-03-23 1:00 ` Sebastian Reichel
2017-03-23 14:52 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323010443.uzv4xs3ne2mjpm7i@earth \
--to=sre-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jacek.anaszewski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pavel-+ZI9xUNit7I@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox