From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jagan Teki <jagan-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Matteo Lisi <matteo.lisi-4s7YQHO/iPVBDgjK7y7TUQ@public.gmane.org>,
Michael Trimarchi
<michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>,
Jagan Teki
<jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
Subject: Re: [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node
Date: Fri, 24 Mar 2017 13:16:36 +0800 [thread overview]
Message-ID: <20170324051632.GD30608@dragon> (raw)
In-Reply-To: <1490204897-14525-6-git-send-email-jagan-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>
On Wed, Mar 22, 2017 at 11:18:10PM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
>
> Add touchscreen node as i2c1 slave device on Engicam Is.IoT MX6UL
> modules, the touchscreen controlled 'st,stmpe-ts' connected via
> i2c with st,stmpe811 mfb interface.
s/mfb/mfd?
>
> Cc: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Matteo Lisi <matteo.lisi-4s7YQHO/iPVBDgjK7y7TUQ@public.gmane.org>
> Cc: Michael Trimarchi <michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
> Signed-off-by: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
> ---
> arch/arm/boot/dts/imx6ul-isiot-common.dtsi | 34 ++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> index 9660e20..b149b5e 100644
> --- a/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-isiot-common.dtsi
> @@ -40,6 +40,34 @@
> * OTHER DEALINGS IN THE SOFTWARE.
> */
>
> +&i2c1 {
> + touch: stmpe811@44 {
Label a MFD device 'touch'? Also, the node name should be generic. Not
sure what should be used for MFD device though.
> + compatible = "st,stmpe811";
> + reg = <0x44>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_stmpe_ts>;
If this is for stmpe-ts, shouldn't be put into touchscreen child node?
> + interrupt-parent = <&gpio1>;
> + interrupts = <18 IRQ_TYPE_EDGE_FALLING>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> +
> + stmpe_touchscreen {
'stmpe: touchscreen {' might be better.
Shawn
> + compatible = "st,stmpe-ts";
> + st,sample-time = <4>;
> + st,mod-12b = <1>;
> + st,ref-sel = <0>;
> + st,adc-freq = <1>;
> + st,ave-ctrl = <1>;
> + st,touch-det-delay = <2>;
> + st,settling = <2>;
> + st,fraction-z = <7>;
> + st,i-drive = <1>;
> + };
> + };
> +};
> +
> &lcdif {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_lcdif_dat
> @@ -104,4 +132,10 @@
> MX6UL_PAD_LCD_DATA17__LCDIF_DATA17 0x79
> >;
> };
> +
> + pinctrl_stmpe_ts: stmpe-tsgrp {
> + fsl,pins = <
> + MX6UL_PAD_UART1_CTS_B__GPIO1_IO18 0x1b0b0
> + >;
> + };
> };
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-03-24 5:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 17:48 [PATCH 00/12] ARM: dts: i.MX6: Add lcdif/sound nodes on Engicam SOMs Jagan Teki
2017-03-22 17:48 ` [PATCH 04/12] ARM: dts: imx6ul-isiot: Add i2c nodes Jagan Teki
2017-03-22 17:48 ` [PATCH 06/12] ARM: dts: imx6ul-[geam|isiot]: Add sai2 node Jagan Teki
2017-03-22 17:48 ` [PATCH 07/12] ARM: dts: imx6ul-isiot: Add Sound card with codec node Jagan Teki
[not found] ` <1490204897-14525-8-git-send-email-jagan-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>
2017-03-24 5:23 ` Shawn Guo
2017-03-24 8:32 ` Jagan Teki
[not found] ` <CAMty3ZBSVgL==LsCzsODkL117WFL4Pv4kwhXhxc3wDWre3i-zA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-24 13:09 ` Shawn Guo
2017-03-22 17:48 ` [PATCH 08/12] ARM: dts: imx6ul-geam: " Jagan Teki
2017-03-22 17:48 ` [PATCH 09/12] ARM: dts: imx6qdl-icore: " Jagan Teki
2017-03-22 17:48 ` [PATCH 11/12] ARM: dts: imx6dl-icore: Add touchscreen node Jagan Teki
[not found] ` <1490204897-14525-1-git-send-email-jagan-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>
2017-03-22 17:48 ` [PATCH 01/12] ARM: dts: imx6ul-geam: Add backlight support for lcdif Jagan Teki
2017-03-22 17:48 ` [PATCH 02/12] ARM: dts: imx6ul-isiot: " Jagan Teki
2017-03-22 17:48 ` [PATCH 03/12] ARM: dts: imx6ul-isiot: Add imx6ul-isiot-common.dtsi Jagan Teki
2017-03-22 17:48 ` [PATCH 05/12] ARM: dts: imx6ul-isiot-common: Add touchscreen node Jagan Teki
[not found] ` <1490204897-14525-6-git-send-email-jagan-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>
2017-03-24 5:16 ` Shawn Guo [this message]
2017-03-24 6:59 ` Jagan Teki
[not found] ` <CAMty3ZBfdjrbvL7F9CbhfD_Wdowr4zM_Rdot=TGKMxq0JPyHjg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-24 7:25 ` Shawn Guo
2017-03-24 7:32 ` Jagan Teki
[not found] ` <CAMty3ZAiSPGKzJK9EcgaPMf55A5W+bW8PvkHOAjRawWA_2_aVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-24 7:35 ` Shawn Guo
2017-03-22 17:48 ` [PATCH 10/12] ARM: dts: imx6dl-icore: Add LVDS support Jagan Teki
2017-03-22 17:48 ` [PATCH 12/12] ARM: dts: imx6qdl-icore-rqs: Add CAN nodes Jagan Teki
2017-03-24 5:19 ` [PATCH 00/12] ARM: dts: i.MX6: Add lcdif/sound nodes on Engicam SOMs Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324051632.GD30608@dragon \
--to=shawnguo-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org \
--cc=jagan-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matteo.lisi-4s7YQHO/iPVBDgjK7y7TUQ@public.gmane.org \
--cc=michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).