From: Sebastian Reichel <sre@kernel.org>
To: Liam Breck <liam@networkimprov.net>
Cc: Tony Lindgren <tony@atomide.com>,
linux-pm@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, Liam Breck <kernel@networkimprov.net>
Subject: Re: [PATCH v1 1/7] devicetree: power: battery: Add properties for pre-charge and end-charge current
Date: Fri, 24 Mar 2017 10:01:58 +0100 [thread overview]
Message-ID: <20170324090158.tl55neisjws66naf@earth> (raw)
In-Reply-To: <20170321220921.5834-2-liam@networkimprov.net>
[-- Attachment #1: Type: text/plain, Size: 1832 bytes --]
Hi,
On Tue, Mar 21, 2017 at 03:09:15PM -0700, Liam Breck wrote:
> From: Liam Breck <kernel@networkimprov.net>
>
> precharge-current-microamp and endcharge-current-microamp are used
> by battery chargers at the beginning and end of a charging cycle.
>
> Depends-on: https://patchwork.kernel.org/patch/9633605/
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Liam Breck <kernel@networkimprov.net>
Acked-by: Sebastian Reichel <sre@kernel.org>
I think it makes sense to merge this into the patch adding
simple-battery.
> Documentation/devicetree/bindings/power/supply/battery.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/battery.txt b/Documentation/devicetree/bindings/power/supply/battery.txt
> index 53a68c0..494374a 100644
> --- a/Documentation/devicetree/bindings/power/supply/battery.txt
> +++ b/Documentation/devicetree/bindings/power/supply/battery.txt
> @@ -12,6 +12,8 @@ Optional Properties:
> - voltage-min-design-microvolt: drained battery voltage
> - energy-full-design-microwatt-hours: battery design energy
> - charge-full-design-microamp-hours: battery design capacity
> + - precharge-current-microamp: current for pre-charge phase
> + - endcharge-current-microamp: current for charge termination phase
>
> Battery properties are named, where possible, for the corresponding
> elements in enum power_supply_property, defined in
> @@ -28,6 +30,8 @@ Example:
> voltage-min-design-microvolt = <3200000>;
> energy-full-design-microwatt-hours = <5290000>;
> charge-full-design-microamp-hours = <1430000>;
> + precharge-current-microamp = <256000>;
> + endcharge-current-microamp = <128000>;
> };
>
> charger: charger@11 {
> --
> 2.9.3
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-03-24 9:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170321220921.5834-1-liam@networkimprov.net>
2017-03-21 22:09 ` [PATCH v1 1/7] devicetree: power: battery: Add properties for pre-charge and end-charge current Liam Breck
2017-03-24 9:01 ` Sebastian Reichel [this message]
2017-03-25 0:34 ` Liam Breck
2017-03-29 0:43 ` Rob Herring
[not found] ` <20170321220921.5834-2-liam-RYWXG+zxWwBdeoIcmNTgJF6hYfS7NtTn@public.gmane.org>
2017-03-22 12:04 ` Hans de Goede
2017-03-29 0:39 ` Rob Herring
2017-03-29 1:42 ` Liam Breck
2017-03-21 22:09 ` [PATCH v1 2/7] devicetree: power: Add docs for TI BQ24190 battery charger Liam Breck
[not found] ` <20170321220921.5834-3-liam-RYWXG+zxWwBdeoIcmNTgJF6hYfS7NtTn@public.gmane.org>
2017-03-22 12:04 ` Hans de Goede
2017-03-29 0:47 ` Rob Herring
2017-03-29 1:48 ` Liam Breck
2017-03-24 9:00 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324090158.tl55neisjws66naf@earth \
--to=sre@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=kernel@networkimprov.net \
--cc=liam@networkimprov.net \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox