From: Ralph Sennhauser <ralph.sennhauser@gmail.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: linux-gpio@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Imre Kaloz <kaloz@openwrt.org>,
Jason Cooper <jason@lakedaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Thierry Reding <thierry.reding@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
"moderated list:ARM/Marvell Kirkwood"
<linux-arm-kernel@lists.infradead.org>and,
"open list:OPEN FIRMWARE AND" <devicetree@vger.kernel.org>,
FLATTENED, open list <linux-kernel@vger.kernel.org>,
"open list:PWM SUBSYSTEM" <linux-pwm@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] mvebu: xp: Add pwm properties to .dtsi files
Date: Fri, 24 Mar 2017 09:11:28 +0100 [thread overview]
Message-ID: <20170324091128.329364eb@gmail.com> (raw)
In-Reply-To: <871stodjze.fsf@free-electrons.com>
On Thu, 23 Mar 2017 17:40:53 +0100
Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:
> Hi Ralph,
>
> On sam., mars 18 2017, Ralph Sennhauser <ralph.sennhauser@gmail.com>
> wrote:
>
> It seems that I don't receive the 1st patch of the series.
Hi Gregory,
it makes no sense to only send part of a series to a recipient. Will
have to improve my use of --cc-cmd it seems. Will pay attention to this
for v3.
Sorry
Ralph
>
> Also could you refresh my mind to expose why these patchse were not
> apply the first time and why we should apply them now?
>
> Thanks,
>
> Gregory
>
>
> > From: Andrew Lunn <andrew@lunn.ch>
> >
> > Add properties to the gpio nodes to allow them to be also used as
> > pwm lines.
> >
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > URL: https://patchwork.ozlabs.org/patch/427294/
> > Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
> > ---
> > arch/arm/boot/dts/armada-370.dtsi | 10 ++++++++--
> > arch/arm/boot/dts/armada-xp-mv78230.dtsi | 10 ++++++++--
> > arch/arm/boot/dts/armada-xp-mv78260.dtsi | 8 ++++++--
> > arch/arm/boot/dts/armada-xp-mv78460.dtsi | 10 ++++++++--
> > 4 files changed, 30 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/armada-370.dtsi
> > b/arch/arm/boot/dts/armada-370.dtsi index cc011c8..aa9fe72 100644
> > --- a/arch/arm/boot/dts/armada-370.dtsi
> > +++ b/arch/arm/boot/dts/armada-370.dtsi
> > @@ -138,24 +138,30 @@
> >
> > gpio0: gpio@18100 {
> > compatible = "marvell,orion-gpio";
> > - reg = <0x18100 0x40>;
> > + reg = <0x18100 0x40>, <0x181c0
> > 0x08>;
> > + reg-names = "gpio", "pwm";
> > ngpios = <32>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > + #pwm-cells = <2>;
> > interrupt-controller;
> > #interrupt-cells = <2>;
> > interrupts = <82>, <83>, <84>,
> > <85>;
> > + clocks = <&coreclk 0>;
> > };
> >
> > gpio1: gpio@18140 {
> > compatible = "marvell,orion-gpio";
> > - reg = <0x18140 0x40>;
> > + reg = <0x18140 0x40>, <0x181c8
> > 0x08>;
> > + reg-names = "gpio", "pwm";
> > ngpios = <32>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > + #pwm-cells = <2>;
> > interrupt-controller;
> > #interrupt-cells = <2>;
> > interrupts = <87>, <88>, <89>,
> > <90>;
> > + clocks = <&coreclk 0>;
> > };
> >
> > gpio2: gpio@18180 {
> > diff --git a/arch/arm/boot/dts/armada-xp-mv78230.dtsi
> > b/arch/arm/boot/dts/armada-xp-mv78230.dtsi index 07c5090..fc3934f
> > 100644 --- a/arch/arm/boot/dts/armada-xp-mv78230.dtsi
> > +++ b/arch/arm/boot/dts/armada-xp-mv78230.dtsi
> > @@ -203,24 +203,30 @@
> > internal-regs {
> > gpio0: gpio@18100 {
> > compatible = "marvell,orion-gpio";
> > - reg = <0x18100 0x40>;
> > + reg = <0x18100 0x40>, <0x181c0
> > 0x08>;
> > + reg-names = "gpio", "pwm";
> > ngpios = <32>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > + #pwm-cells = <2>;
> > interrupt-controller;
> > #interrupt-cells = <2>;
> > interrupts = <82>, <83>, <84>,
> > <85>;
> > + clocks = <&coreclk 0>;
> > };
> >
> > gpio1: gpio@18140 {
> > compatible = "marvell,orion-gpio";
> > - reg = <0x18140 0x40>;
> > + reg = <0x18140 0x40>, <0x181c8
> > 0x08>;
> > + reg-names = "gpio", "pwm";
> > ngpios = <17>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > + #pwm-cells = <2>;
> > interrupt-controller;
> > #interrupt-cells = <2>;
> > interrupts = <87>, <88>, <89>;
> > + clocks = <&coreclk 0>;
> > };
> > };
> > };
> > diff --git a/arch/arm/boot/dts/armada-xp-mv78260.dtsi
> > b/arch/arm/boot/dts/armada-xp-mv78260.dtsi index 64e936a..04dda6a
> > 100644 --- a/arch/arm/boot/dts/armada-xp-mv78260.dtsi
> > +++ b/arch/arm/boot/dts/armada-xp-mv78260.dtsi
> > @@ -286,24 +286,28 @@
> > internal-regs {
> > gpio0: gpio@18100 {
> > compatible = "marvell,orion-gpio";
> > - reg = <0x18100 0x40>;
> > + reg = <0x18100 0x40>, <0x181c0
> > 0x08>;
> > + reg-names = "gpio", "pwm";
> > ngpios = <32>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > + #pwm-cells = <2>;
> > interrupt-controller;
> > #interrupt-cells = <2>;
> > interrupts = <82>, <83>, <84>,
> > <85>;
> > + clocks = <&coreclk 0>;
> > };
> >
> > gpio1: gpio@18140 {
> > compatible = "marvell,orion-gpio";
> > - reg = <0x18140 0x40>;
> > + reg = <0x18140 0x40>, <0x181c8
> > 0x08>; ngpios = <32>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> > #interrupt-cells = <2>;
> > interrupts = <87>, <88>, <89>,
> > <90>;
> > + clocks = <&coreclk 0>;
> > };
> >
> > gpio2: gpio@18180 {
> > diff --git a/arch/arm/boot/dts/armada-xp-mv78460.dtsi
> > b/arch/arm/boot/dts/armada-xp-mv78460.dtsi index d1383dd..fb6d28a
> > 100644 --- a/arch/arm/boot/dts/armada-xp-mv78460.dtsi
> > +++ b/arch/arm/boot/dts/armada-xp-mv78460.dtsi
> > @@ -324,24 +324,30 @@
> > internal-regs {
> > gpio0: gpio@18100 {
> > compatible = "marvell,orion-gpio";
> > - reg = <0x18100 0x40>;
> > + reg = <0x18100 0x40>, <0x181c0
> > 0x08>;
> > + reg-names = "gpio", "pwm";
> > ngpios = <32>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > + #pwm-cells = <2>;
> > interrupt-controller;
> > #interrupt-cells = <2>;
> > interrupts = <82>, <83>, <84>,
> > <85>;
> > + clocks = <&coreclk 0>;
> > };
> >
> > gpio1: gpio@18140 {
> > compatible = "marvell,orion-gpio";
> > - reg = <0x18140 0x40>;
> > + reg = <0x18140 0x40>, <0x181c8
> > 0x08>;
> > + reg-names = "gpio", "pwm";
> > ngpios = <32>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > + #pwm-cells = <2>;
> > interrupt-controller;
> > #interrupt-cells = <2>;
> > interrupts = <87>, <88>, <89>,
> > <90>;
> > + clocks = <&coreclk 0>;
> > };
> >
> > gpio2: gpio@18180 {
> > --
> > 2.10.2
> >
>
next prev parent reply other threads:[~2017-03-24 8:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170318154305.28348-1-ralph.sennhauser@gmail.com>
2017-03-18 15:43 ` [PATCH v2 1/4] gpio: mvebu: Add limited PWM support Ralph Sennhauser
2017-03-24 15:18 ` Rob Herring
2017-03-24 22:21 ` Ralph Sennhauser
2017-03-18 15:43 ` [PATCH v2 2/4] mvebu: xp: Add pwm properties to .dtsi files Ralph Sennhauser
2017-03-23 16:40 ` Gregory CLEMENT
2017-03-23 21:22 ` Andrew Lunn
2017-03-24 8:11 ` Ralph Sennhauser [this message]
2017-03-18 15:43 ` [PATCH v2 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan Ralph Sennhauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324091128.329364eb@gmail.com \
--to=ralph.sennhauser@gmail.com \
--cc=andrew@lunn.ch \
--cc=gnurou@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=kaloz@openwrt.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).