From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 24 Mar 2017 09:11:28 +0100 From: Ralph Sennhauser Subject: Re: [PATCH v2 2/4] mvebu: xp: Add pwm properties to .dtsi files Message-ID: <20170324091128.329364eb@gmail.com> In-Reply-To: <871stodjze.fsf@free-electrons.com> References: <20170318154305.28348-1-ralph.sennhauser@gmail.com> <20170318154305.28348-3-ralph.sennhauser@gmail.com> <871stodjze.fsf@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit To: Gregory CLEMENT Cc: linux-gpio@vger.kernel.org, Andrew Lunn , Imre Kaloz , Jason Cooper , Sebastian Hesselbarth , Rob Herring , Mark Rutland , Russell King , Thierry Reding , Linus Walleij , Alexandre Courbot , "moderated list:ARM/Marvell Kirkwood" and, "open list:OPEN FIRMWARE AND" , FLATTENED, open list , "open list:PWM SUBSYSTEM" List-ID: On Thu, 23 Mar 2017 17:40:53 +0100 Gregory CLEMENT wrote: > Hi Ralph, > > On sam., mars 18 2017, Ralph Sennhauser > wrote: > > It seems that I don't receive the 1st patch of the series. Hi Gregory, it makes no sense to only send part of a series to a recipient. Will have to improve my use of --cc-cmd it seems. Will pay attention to this for v3. Sorry Ralph > > Also could you refresh my mind to expose why these patchse were not > apply the first time and why we should apply them now? > > Thanks, > > Gregory > > > > From: Andrew Lunn > > > > Add properties to the gpio nodes to allow them to be also used as > > pwm lines. > > > > Signed-off-by: Andrew Lunn > > URL: https://patchwork.ozlabs.org/patch/427294/ > > Signed-off-by: Ralph Sennhauser > > --- > > arch/arm/boot/dts/armada-370.dtsi | 10 ++++++++-- > > arch/arm/boot/dts/armada-xp-mv78230.dtsi | 10 ++++++++-- > > arch/arm/boot/dts/armada-xp-mv78260.dtsi | 8 ++++++-- > > arch/arm/boot/dts/armada-xp-mv78460.dtsi | 10 ++++++++-- > > 4 files changed, 30 insertions(+), 8 deletions(-) > > > > diff --git a/arch/arm/boot/dts/armada-370.dtsi > > b/arch/arm/boot/dts/armada-370.dtsi index cc011c8..aa9fe72 100644 > > --- a/arch/arm/boot/dts/armada-370.dtsi > > +++ b/arch/arm/boot/dts/armada-370.dtsi > > @@ -138,24 +138,30 @@ > > > > gpio0: gpio@18100 { > > compatible = "marvell,orion-gpio"; > > - reg = <0x18100 0x40>; > > + reg = <0x18100 0x40>, <0x181c0 > > 0x08>; > > + reg-names = "gpio", "pwm"; > > ngpios = <32>; > > gpio-controller; > > #gpio-cells = <2>; > > + #pwm-cells = <2>; > > interrupt-controller; > > #interrupt-cells = <2>; > > interrupts = <82>, <83>, <84>, > > <85>; > > + clocks = <&coreclk 0>; > > }; > > > > gpio1: gpio@18140 { > > compatible = "marvell,orion-gpio"; > > - reg = <0x18140 0x40>; > > + reg = <0x18140 0x40>, <0x181c8 > > 0x08>; > > + reg-names = "gpio", "pwm"; > > ngpios = <32>; > > gpio-controller; > > #gpio-cells = <2>; > > + #pwm-cells = <2>; > > interrupt-controller; > > #interrupt-cells = <2>; > > interrupts = <87>, <88>, <89>, > > <90>; > > + clocks = <&coreclk 0>; > > }; > > > > gpio2: gpio@18180 { > > diff --git a/arch/arm/boot/dts/armada-xp-mv78230.dtsi > > b/arch/arm/boot/dts/armada-xp-mv78230.dtsi index 07c5090..fc3934f > > 100644 --- a/arch/arm/boot/dts/armada-xp-mv78230.dtsi > > +++ b/arch/arm/boot/dts/armada-xp-mv78230.dtsi > > @@ -203,24 +203,30 @@ > > internal-regs { > > gpio0: gpio@18100 { > > compatible = "marvell,orion-gpio"; > > - reg = <0x18100 0x40>; > > + reg = <0x18100 0x40>, <0x181c0 > > 0x08>; > > + reg-names = "gpio", "pwm"; > > ngpios = <32>; > > gpio-controller; > > #gpio-cells = <2>; > > + #pwm-cells = <2>; > > interrupt-controller; > > #interrupt-cells = <2>; > > interrupts = <82>, <83>, <84>, > > <85>; > > + clocks = <&coreclk 0>; > > }; > > > > gpio1: gpio@18140 { > > compatible = "marvell,orion-gpio"; > > - reg = <0x18140 0x40>; > > + reg = <0x18140 0x40>, <0x181c8 > > 0x08>; > > + reg-names = "gpio", "pwm"; > > ngpios = <17>; > > gpio-controller; > > #gpio-cells = <2>; > > + #pwm-cells = <2>; > > interrupt-controller; > > #interrupt-cells = <2>; > > interrupts = <87>, <88>, <89>; > > + clocks = <&coreclk 0>; > > }; > > }; > > }; > > diff --git a/arch/arm/boot/dts/armada-xp-mv78260.dtsi > > b/arch/arm/boot/dts/armada-xp-mv78260.dtsi index 64e936a..04dda6a > > 100644 --- a/arch/arm/boot/dts/armada-xp-mv78260.dtsi > > +++ b/arch/arm/boot/dts/armada-xp-mv78260.dtsi > > @@ -286,24 +286,28 @@ > > internal-regs { > > gpio0: gpio@18100 { > > compatible = "marvell,orion-gpio"; > > - reg = <0x18100 0x40>; > > + reg = <0x18100 0x40>, <0x181c0 > > 0x08>; > > + reg-names = "gpio", "pwm"; > > ngpios = <32>; > > gpio-controller; > > #gpio-cells = <2>; > > + #pwm-cells = <2>; > > interrupt-controller; > > #interrupt-cells = <2>; > > interrupts = <82>, <83>, <84>, > > <85>; > > + clocks = <&coreclk 0>; > > }; > > > > gpio1: gpio@18140 { > > compatible = "marvell,orion-gpio"; > > - reg = <0x18140 0x40>; > > + reg = <0x18140 0x40>, <0x181c8 > > 0x08>; ngpios = <32>; > > gpio-controller; > > #gpio-cells = <2>; > > interrupt-controller; > > #interrupt-cells = <2>; > > interrupts = <87>, <88>, <89>, > > <90>; > > + clocks = <&coreclk 0>; > > }; > > > > gpio2: gpio@18180 { > > diff --git a/arch/arm/boot/dts/armada-xp-mv78460.dtsi > > b/arch/arm/boot/dts/armada-xp-mv78460.dtsi index d1383dd..fb6d28a > > 100644 --- a/arch/arm/boot/dts/armada-xp-mv78460.dtsi > > +++ b/arch/arm/boot/dts/armada-xp-mv78460.dtsi > > @@ -324,24 +324,30 @@ > > internal-regs { > > gpio0: gpio@18100 { > > compatible = "marvell,orion-gpio"; > > - reg = <0x18100 0x40>; > > + reg = <0x18100 0x40>, <0x181c0 > > 0x08>; > > + reg-names = "gpio", "pwm"; > > ngpios = <32>; > > gpio-controller; > > #gpio-cells = <2>; > > + #pwm-cells = <2>; > > interrupt-controller; > > #interrupt-cells = <2>; > > interrupts = <82>, <83>, <84>, > > <85>; > > + clocks = <&coreclk 0>; > > }; > > > > gpio1: gpio@18140 { > > compatible = "marvell,orion-gpio"; > > - reg = <0x18140 0x40>; > > + reg = <0x18140 0x40>, <0x181c8 > > 0x08>; > > + reg-names = "gpio", "pwm"; > > ngpios = <32>; > > gpio-controller; > > #gpio-cells = <2>; > > + #pwm-cells = <2>; > > interrupt-controller; > > #interrupt-cells = <2>; > > interrupts = <87>, <88>, <89>, > > <90>; > > + clocks = <&coreclk 0>; > > }; > > > > gpio2: gpio@18180 { > > -- > > 2.10.2 > > >