From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 3/3] ARM: dts: sun8i: add device tree for Lichee Pi Zero with Dock Date: Fri, 24 Mar 2017 16:55:18 +0100 Message-ID: <20170324155518.xcbmluz4ehltfxwt@lukather> References: <20170322223427.YNp8w8sn@smtp3m.mail.yandex.net> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="73trmuk5bdacvw5f" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20170322223427.YNp8w8sn-jDEamKawf7I0PDqKvflMoHmW9unr2Ajn@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Icenowy Zheng Cc: linux-kernel , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Chen-Yu Tsai List-Id: devicetree@vger.kernel.org --73trmuk5bdacvw5f Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 23, 2017 at 03:34:18AM +0800, Icenowy Zheng wrote: >=20 > 2017=E5=B9=B43=E6=9C=8823=E6=97=A5 03:24=E4=BA=8E Maxime Ripard =E5=86=99=E9=81=93=EF=BC=9A > > > > On Fri, Mar 17, 2017 at 11:43:43PM +0800, Icenowy Zheng wrote:=20 > > > Lichee Pi Zero features a dock, which adds some functions, and should= be=20 > > > soldered with the core board of Lichee Pi Zero.=20 > > >=20 > > > Add support for the dock as a new dts, as soldering is needed to make= =20 > > > the dock usable and there's functions enabled on the dock that is=20 > > > unavailable at the 2.54mm pins of the core board.=20 > > >=20 > > > Signed-off-by: Icenowy Zheng =20 > > > ---=20 > > >=C2=A0 arch/arm/boot/dts/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 3 +-=20 > > >=C2=A0 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 98 +++++++= +++++++++++++++=20 > > >=C2=A0 2 files changed, 100 insertions(+), 1 deletion(-)=20 > > >=C2=A0 create mode 100644 arch/arm/boot/dts/sun8i-v3s-licheepi-zero-do= ck.dts=20 > > >=20 > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile= =20 > > > index 43c27b624f94..de52d403f818 100644=20 > > > --- a/arch/arm/boot/dts/Makefile=20 > > > +++ b/arch/arm/boot/dts/Makefile=20 > > > @@ -878,7 +878,8 @@ dtb-$(CONFIG_MACH_SUN8I) +=3D \=20 > > >=C2=A0 sun8i-h3-orangepi-plus.dtb \=20 > > >=C2=A0 sun8i-h3-orangepi-plus2e.dtb \=20 > > >=C2=A0 sun8i-r16-parrot.dtb \=20 > > > - sun8i-v3s-licheepi-zero.dtb=20 > > > + sun8i-v3s-licheepi-zero.dtb \=20 > > > + sun8i-v3s-licheepi-zero-dock.dtb=20 > > >=C2=A0 dtb-$(CONFIG_MACH_SUN9I) +=3D \=20 > > >=C2=A0 sun9i-a80-optimus.dtb \=20 > > >=C2=A0 sun9i-a80-cubieboard4.dtb=20 > > > diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arc= h/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts=20 > > > new file mode 100644=20 > > > index 000000000000..956fa47fde53=20 > > > --- /dev/null=20 > > > +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts=20 > > > @@ -0,0 +1,98 @@=20 > > > +/*=20 > > > + * Copyright (C) 2016 Icenowy Zheng =20 > > > + *=20 > > > + * This file is dual-licensed: you can use it either under the terms= =20 > > > + * of the GPL or the X11 license, at your option. Note that this dua= l=20 > > > + * licensing only applies to this file, and not this project as a=20 > > > + * whole.=20 > > > + *=20 > > > + *=C2=A0 a) This file is free software; you can redistribute it and/= or=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 modify it under the terms of the GNU Gene= ral Public License as=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 published by the Free Software Foundation= ; either version 2 of the=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 License, or (at your option) any later ve= rsion.=20 > > > + *=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 This file is distributed in the hope that= it will be useful,=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 but WITHOUT ANY WARRANTY; without even th= e implied warranty of=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 MERCHANTABILITY or FITNESS FOR A PARTICUL= AR PURPOSE.=C2=A0 See the=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 GNU General Public License for more detai= ls.=20 > > > + *=20 > > > + * Or, alternatively,=20 > > > + *=20 > > > + *=C2=A0 b) Permission is hereby granted, free of charge, to any per= son=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 obtaining a copy of this software and ass= ociated documentation=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 files (the "Software"), to deal in the So= ftware without=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 restriction, including without limitation= the rights to use,=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 copy, modify, merge, publish, distribute,= sublicense, and/or=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 sell copies of the Software, and to permi= t persons to whom the=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 Software is furnished to do so, subject t= o the following=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 conditions:=20 > > > + *=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 The above copyright notice and this permi= ssion notice shall be=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 included in all copies or substantial por= tions of the Software.=20 > > > + *=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT= WARRANTY OF ANY KIND,=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 EXPRESS OR IMPLIED, INCLUDING BUT NOT LIM= ITED TO THE WARRANTIES=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 OF MERCHANTABILITY, FITNESS FOR A PARTICU= LAR PURPOSE AND=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 NONINFRINGEMENT. IN NO EVENT SHALL THE AU= THORS OR COPYRIGHT=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES = OR OTHER LIABILITY,=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 WHETHER IN AN ACTION OF CONTRACT, TORT OR= OTHERWISE, ARISING=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 FROM, OUT OF OR IN CONNECTION WITH THE SO= FTWARE OR THE USE OR=20 > > > + *=C2=A0=C2=A0=C2=A0=C2=A0 OTHER DEALINGS IN THE SOFTWARE.=20 > > > + */=20 > > > +=20 > > > +#include "sun8i-v3s-licheepi-zero.dts"=20 > > > +=20 > > > +#include =20 > > > +=20 > > > +/ {=20 > > > + model =3D "Lichee Pi Zero with Dock";=20 > > > + compatible =3D "licheepi,licheepi-zero-dock", "licheepi,licheepi-ze= ro",=20 > > > + =C2=A0=C2=A0=C2=A0=C2=A0 "allwinner,sun8i-v3s";=20 > > > +};=20 > > > +=20 > > > +&leds {=20 > > > + /* The LEDs conflict with MMC1 slot */=20 > > > > How does it conflicts?=20 >=20 > They both use PGx. So they use the same bank? How is that a conflict? > > > +&mmc1 {=20 > > > + pinctrl-0 =3D <&mmc1_pins>;=20 > > > + pinctrl-names =3D "default";=20 > > > + broken-cd;=20 > > > > There's no card-detect on a GPIO?=20 >=20 > Yes. >=20 > All SD slots on Lichee Pi series have no card-detect. Weird... Ok. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. --73trmuk5bdacvw5f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJY1UFmAAoJEBx+YmzsjxAgRzMP/RDkeV+gtNVwccZNvQIili0g 0PDtpThjeocjNxnyzj8uGs57eQFg/ZWWCg0lORnJJHPs4XILRXdyKUZ72tD02VPF LL6mjgILqFZYquGoawnSaIqiGDDmFoI6VCkW2OrMShQn64/u2tl5JcmdWZU3kPrw DqW0aM0dGXJZ51Qc58f+Gp44ESqSFFFQJVP4O8uwlIoXqAxMcnectySNNEqL6hhL upE0Pk/ODLX8P2P6z8E/fuI6pCmk14Refur2JTjz6XsSybDA1yzPHSE/FI3QYXAt x/mjMUn+DrqJ5A8VtPDmUaJya4qzigB+zDsc778uzA4LisBeicotwrP5mmCjCK0b XNCaJVn/smW7BBMl9zU2Olpi3DVQ6u9ZQUNVTGCh4EW/yAustp2Dl275VR/xQkE+ XHafpTVRm1IJNLnn9KNGNUB7uXCD5AzBij4yMy2NtjSmUTS2mQI5Ikhk76DUi/BL DjkftXwTyYnJoIiOju9fnLgd+jTdF/KMAVJncsK+scMORanJGyrHeL5xoi62kUZ+ pUMqs0FugAo5bqFKtGCFqH2FnA5piqL2YkeRUD3gsBff0JHHVOcZ51FFxpjOLwTl 3tiBONGqrho9v5YCGpQbDvESaOdLdRvaClB4M/WzqhkdVNl0f+9Kv52aUT10cLvs +q+F+YZSsOPRILOUmoZh =sPTg -----END PGP SIGNATURE----- --73trmuk5bdacvw5f--