devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, Kishon Vijay Abraham I <kishon@ti.com>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	Marcel Partap <mpartap@gmx.net>,
	Michael Scott <michael.scott@linaro.org>
Subject: Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support
Date: Sat, 25 Mar 2017 15:10:29 -0700	[thread overview]
Message-ID: <20170325221029.GF10760@atomide.com> (raw)
In-Reply-To: <201703260432.1EcS6tcy%fengguang.wu@intel.com>

* kbuild test robot <lkp@intel.com> [170325 13:45]:
> Hi Tony,
> 
> [auto build test ERROR on phy/next]
> [also build test ERROR on v4.11-rc3 next-20170324]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Tony-Lindgren/phy-cpcap-usb-Add-CPCAP-PMIC-USB-support/20170324-061112
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git next
> config: x86_64-randconfig-a0-03260238 (attached as .config)
> compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/built-in.o: In function `cpcap_usb_detect':
> >> phy-cpcap-usb.c:(.text+0x18ad): undefined reference to `iio_read_channel_processed'
>    drivers/built-in.o: In function `cpcap_usb_phy_probe':
> >> phy-cpcap-usb.c:(.text+0x1c5e): undefined reference to `devm_iio_channel_get'
> >> phy-cpcap-usb.c:(.text+0x1c92): undefined reference to `iio_get_channel_type'

OK thanks for the report, we need IIO for VBUS level, here's
a patch to fix it.

Regards,

Tony

8< -----------------------
>From tony Mon Sep 17 00:00:00 2001
From: Tony Lindgren <tony@atomide.com>
Date: Sat, 25 Mar 2017 15:04:37 -0700
Subject: [PATCH] phy: cpcap-usb: Fix build by adding a dependency to
 CONFIG_IIO

We need the ADC output provided by IIO to detect VBUS level.
Otherwise we can get:

drivers/built-in.o: In function `cpcap_usb_detect':
phy-cpcap-usb.c:(.text+0x18ad): undefined reference to
`iio_read_channel_processed'
drivers/built-in.o: In function `cpcap_usb_phy_probe':
phy-cpcap-usb.c:(.text+0x1c5e): undefined reference to
`devm_iio_channel_get'
phy-cpcap-usb.c:(.text+0x1c92): undefined reference to`iio_get_channel_type'

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 drivers/phy/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -49,7 +49,7 @@ config PHY_BERLIN_SATA
 
 config PHY_CPCAP_USB
 	tristate "CPCAP USB PHY driver"
-	depends on USB_SUPPORT
+	depends on USB_SUPPORT && IIO
 	select GENERIC_PHY
 	select USB_PHY
 	help
-- 
2.12.1

  reply	other threads:[~2017-03-25 22:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22 23:46 [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support Tony Lindgren
     [not found] ` <20170322234602.5888-1-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-03-25 20:42   ` kbuild test robot
2017-03-25 22:10     ` Tony Lindgren [this message]
2017-03-27  6:25   ` Kishon Vijay Abraham I
     [not found]     ` <d47b0f99-1ef8-3bff-0fbe-edb95ed41e23-l0cyMroinI0@public.gmane.org>
2017-03-27 15:05       ` Tony Lindgren
     [not found]         ` <20170327150518.GH10760-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-03-30 11:49           ` Kishon Vijay Abraham I
     [not found]             ` <3661b0cc-bf79-0347-ae4c-db6bdfdf6293-l0cyMroinI0@public.gmane.org>
2017-04-04  3:27               ` Tony Lindgren
2017-03-29  2:04   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170325221029.GF10760@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kbuild-all@01.org \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=michael.scott@linaro.org \
    --cc=mpartap@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).