[PATCH 0/2] drm/sun4i: Add display backend interrupt to dt binding

[PATCH 0/2] drm/sun4i: Add display backend interrupt to dt binding

[Chen-Yu Tsai]

Hi Maxime,

As promised, here is the patch adding the interrupt line for the display
backend to the sun5i shared dtsi, and another one adding it to the device
tree bindings.

The display backend has an undocumented (in the user manual) interrupt
that, according to vendor code, is raised when the current scanout is
completed. This might be a better fit for DRM/KMS vblank signalling,
rather than the TCON's vblank interrupt. If true, it would allow us
to cut out the TCON from the crtc in the driver, instead keeping it
solely as an encoder, simplifying some of the inter-component code.

Regardless, the interrupt line exists and should be added to the
device tree.


Regards
ChenYu

Chen-Yu Tsai (2):
  drm/sun4i: Add display backend interrupt to device tree binding
  ARM: dts: sun5i: Add interrupt for display backend

 Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 2 ++
 arch/arm/boot/dts/sun5i.dtsi                                  | 1 +
 2 files changed, 3 insertions(+)

-- 
2.11.0

[PATCH 1/2] drm/sun4i: Add display backend interrupt to device tree binding

[Chen-Yu Tsai]

The display backend has an interrupt line. Add it to the device tree
binding.

Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
---
 Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
index b82c00449468..57a8d0610062 100644
--- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
+++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
@@ -94,6 +94,7 @@ Required properties:
     * allwinner,sun6i-a31-display-backend
     * allwinner,sun8i-a33-display-backend
   - reg: base address and size of the memory-mapped region.
+  - interrupts: interrupt associated to this IP
   - clocks: phandles to the clocks feeding the frontend and backend
     * ahb: the backend interface clock
     * mod: the backend module clock
@@ -265,6 +266,7 @@ fe0: display-frontend@1e00000 {
 be0: display-backend@1e60000 {
 	compatible = "allwinner,sun5i-a13-display-backend";
 	reg = <0x01e60000 0x10000>;
+	interrupts = <47>;
 	clocks = <&ahb_gates 44>, <&de_be_clk>,
 		 <&dram_gates 26>;
 	clock-names = "ahb", "mod",
-- 
2.11.0

Re: [PATCH 1/2] drm/sun4i: Add display backend interrupt to device tree binding

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

On Mon, Mar 27, 2017 at 10:38:46PM +0800, Chen-Yu Tsai wrote:
> The display backend has an interrupt line. Add it to the device tree
> binding.
> 
> Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>

The patches prefix for the binding documentation is usually
dt-bindings:

I've changed that and applied that patch, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH 1/2] drm/sun4i: Add display backend interrupt to device tree binding

[Rob Herring]

On Mon, Mar 27, 2017 at 10:38:46PM +0800, Chen-Yu Tsai wrote:
> The display backend has an interrupt line. Add it to the device tree
> binding.
> 
> Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 2 ++
>  1 file changed, 2 insertions(+)

Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

[PATCH 2/2] ARM: dts: sun5i: Add interrupt for display backend

[Chen-Yu Tsai]

The display backend on sun5i shares the same interrupt line as the
display frontend. Add it.

Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
---

This won't directly apply to old releases. We may want to backport
them though?

---
 arch/arm/boot/dts/sun5i.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/sun5i.dtsi b/arch/arm/boot/dts/sun5i.dtsi
index fc338ce7af79..5175f9cc9bed 100644
--- a/arch/arm/boot/dts/sun5i.dtsi
+++ b/arch/arm/boot/dts/sun5i.dtsi
@@ -689,6 +689,7 @@
 		be0: display-backend@01e60000 {
 			compatible = "allwinner,sun5i-a13-display-backend";
 			reg = <0x01e60000 0x10000>;
+			interrupts = <47>;
 			clocks = <&ccu CLK_AHB_DE_BE>, <&ccu CLK_DE_BE>,
 				 <&ccu CLK_DRAM_DE_BE>;
 			clock-names = "ahb", "mod",
-- 
2.11.0

Re: [PATCH 2/2] ARM: dts: sun5i: Add interrupt for display backend

[Maxime Ripard]

[-- Attachment #1.1: Type: text/plain, Size: 574 bytes --]

On Mon, Mar 27, 2017 at 10:38:47PM +0800, Chen-Yu Tsai wrote:
> The display backend on sun5i shares the same interrupt line as the
> display frontend. Add it.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

And ideally, patches prefix shouldn't have dts here too. I've dropped
it and applied, thanks!

> This won't directly apply to old releases. We may want to backport
> them though?

Yep, probably. Do you want to send it to stable?

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/2] ARM: dts: sun5i: Add interrupt for display backend

[Chen-Yu Tsai]

On Wed, Mar 29, 2017 at 3:13 PM, Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> On Mon, Mar 27, 2017 at 10:38:47PM +0800, Chen-Yu Tsai wrote:
>> The display backend on sun5i shares the same interrupt line as the
>> display frontend. Add it.
>>
>> Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
>
> And ideally, patches prefix shouldn't have dts here too. I've dropped
> it and applied, thanks!

Seems like this was a recent policy change? Or almost everyone was getting
it wrong in the past.

>> This won't directly apply to old releases. We may want to backport
>> them though?
>
> Yep, probably. Do you want to send it to stable?

It won't apply, due to the recent sun5i merger. We could wait until
it lands in Linus' tree, then send a backport patch to stable, to
keep the noise to a minimum.

ChenYu