* [PATCH v2] of: add stubs for of_n_{addr, size}_cells
@ 2017-03-28 9:37 Tobias Regnery
2017-03-28 12:38 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Regnery @ 2017-03-28 9:37 UTC (permalink / raw)
To: robh+dt, devicetree, linux-kernel; +Cc: horms, arnd, Tobias Regnery
With CONFIG_OF=n and CONFIG_COMPILE_TEST=y the rcar pci-e driver fails to
build on arm:
drivers/pci/host/pcie-rcar.c: In function 'pci_dma_range_parser_init':
drivers/pci/host/pcie-rcar.c:1035:16: error: implicit declaration of function 'of_n_addr_cells' [-Werror=implicit-function-declaration]
parser->pna = of_n_addr_cells(node);
^~~~~~~~~~~~~~~
Fix this by adding an inline stub for of_n_addr_cells
While at it also provide a stub for of_n_size_cells for consistency reasons.
Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
---
Changes in v2:
- add a stub for of_n_size_cells as suggested by Arnd
include/linux/of.h | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/include/linux/of.h b/include/linux/of.h
index 21e6323de0f3..27727355e199 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -710,6 +710,16 @@ static inline struct device_node *of_get_cpu_node(int cpu,
return NULL;
}
+static inline int of_n_addr_cells(struct device_node *np)
+{
+ return 0;
+}
+
+static inline int of_n_size_cells(struct device_node *np)
+{
+ return 0;
+}
+
static inline int of_property_read_u64(const struct device_node *np,
const char *propname, u64 *out_value)
{
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] of: add stubs for of_n_{addr, size}_cells
2017-03-28 9:37 [PATCH v2] of: add stubs for of_n_{addr, size}_cells Tobias Regnery
@ 2017-03-28 12:38 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2017-03-28 12:38 UTC (permalink / raw)
To: Tobias Regnery
Cc: Rob Herring, devicetree, Linux Kernel Mailing List, Simon Horman
On Tue, Mar 28, 2017 at 11:37 AM, Tobias Regnery
<tobias.regnery@gmail.com> wrote:
> With CONFIG_OF=n and CONFIG_COMPILE_TEST=y the rcar pci-e driver fails to
> build on arm:
>
> drivers/pci/host/pcie-rcar.c: In function 'pci_dma_range_parser_init':
> drivers/pci/host/pcie-rcar.c:1035:16: error: implicit declaration of function 'of_n_addr_cells' [-Werror=implicit-function-declaration]
> parser->pna = of_n_addr_cells(node);
> ^~~~~~~~~~~~~~~
>
> Fix this by adding an inline stub for of_n_addr_cells
>
> While at it also provide a stub for of_n_size_cells for consistency reasons.
>
> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
> ---
> Changes in v2:
> - add a stub for of_n_size_cells as suggested by Arnd
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-28 12:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-28 9:37 [PATCH v2] of: add stubs for of_n_{addr, size}_cells Tobias Regnery
2017-03-28 12:38 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).