From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH v2,2/3] tty/serial: meson_uart: add documentation for the dt-bindings Date: Tue, 28 Mar 2017 11:05:51 +0100 Message-ID: <20170328100551.GA24221@leverpostej> References: <20170328092545.4644-1-hgkr.klein@gmail.com> <20170328092545.4644-3-hgkr.klein@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170328092545.4644-3-hgkr.klein-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Helmut Klein Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Mar 28, 2017 at 11:25:44AM +0200, Helmut Klein wrote: > Add the documentation for the device tree binding of meson_uart > > Signed-off-by: Helmut Klein > --- > .../bindings/serial/amlogic,meson_uart.txt | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt > > diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt b/Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt > new file mode 100644 > index 000000000000..6f94ba25760d > --- /dev/null > +++ b/Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt > @@ -0,0 +1,25 @@ > +* Amlogic Meson UART, used in multiple SoCs (e.g. S905, s905X, ...) > + > +Required properties: > +- compatible : "amlogic,meson-uart" > +- reg : offset and length of the register set for the device. > +- interrupts : device interrupt > +- clocks : the baud rate clock for the UART and optionally the core clock for the none AO uarts > +e.g. > +uart_A: serial@84c0 { > + compatible = "amlogic,meson-uart"; > + reg = <0x0 0x84c0 0x0 0x14>; > + pinctrl-0 = <&uart_a_pins &uart_a_cts_rts_pins>; > + interrupts = ; > + clocks = <&xtal>, <&clkc CLKID_UART0>; > + clock-names = "xtal", "core"; Please define these explicitly above, e.g. - clocks: a list of phandle + clock-specifier pairs, one for each entry in clock names. - clock-names: contains: * "xtal" for the baud rate clock * "core" for the non-AO UARTs (optional) Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html