From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] input: matrix_keypad: add option to drive inactive columns Date: Wed, 29 Mar 2017 00:15:02 -0700 Message-ID: <20170329071502.GC38261@dtor-ws> References: <20170322201650.9072-1-drivshin@awxrd.com> <20170329020229.dm3y57dlzjwilifm@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170329020229.dm3y57dlzjwilifm@rob-hp-laptop> Sender: linux-input-owner@vger.kernel.org To: Rob Herring Cc: David Rivshin , Mark Rutland , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Tue, Mar 28, 2017 at 09:02:29PM -0500, Rob Herring wrote: > On Wed, Mar 22, 2017 at 04:16:50PM -0400, David Rivshin wrote: > > From: David Rivshin > > > > The gpio-matrix-keypad driver normally sets inactive columns as inputs > > while scanning. This does not work for all hardware, which may require > > the inactive columns to be actively driven in order to overcome any > > pull-ups/downs on the columns. > > > > Signed-off-by: David Rivshin > > --- > > .../devicetree/bindings/input/gpio-matrix-keypad.txt | 2 ++ > > drivers/input/keyboard/matrix_keypad.c | 13 +++++++++---- > > include/linux/input/matrix_keypad.h | 3 +++ > > 3 files changed, 14 insertions(+), 4 deletions(-) > > Acked-by: Rob Herring Applied, thank you. -- Dmitry