From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergio Prado Subject: Re: [PATCH v5 2/2] mmc: host: s3cmci: allow probing from device tree Date: Fri, 31 Mar 2017 19:46:22 -0300 Message-ID: <20170331224622.GA11126@sprado-desktop> References: <1489799633-29278-1-git-send-email-sergio.prado@e-labworks.com> <1489799633-29278-3-git-send-email-sergio.prado@e-labworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ulf Hansson Cc: Arnd Bergmann , Rob Herring , Mark Rutland , "linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux Kernel Mailing List , "ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org" , Linux ARM List-Id: devicetree@vger.kernel.org On Fri, Mar 31, 2017 at 01:11:59PM +0200, Ulf Hansson wrote: > On 31 March 2017 at 09:25, Arnd Bergmann wrote: > > On Sat, Mar 18, 2017 at 2:13 AM, Sergio Prado > > wrote: > > > >> > >> +static const struct of_device_id s3cmci_dt_match[] = { > >> + { > >> + .compatible = "samsung,s3c2410-sdi", > >> + .data = (void *)0, > >> + }, > >> + { > >> + .compatible = "samsung,s3c2412-sdi", > >> + .data = (void *)1, > >> + }, > >> + { > >> + .compatible = "samsung,s3c2440-sdi", > >> + .data = (void *)1, > >> + }, > >> + { /* sentinel */ }, > >> +}; > >> +MODULE_DEVICE_TABLE(of, sdhci_s3c_dt_match); > >> + > > > > The names don't match: > > > > In file included from /git/arm-soc/drivers/mmc/host/s3cmci.c:14:0: > > /git/arm-soc/drivers/mmc/host/s3cmci.c:1844:25: error: > > 'sdhci_s3c_dt_match' undeclared here (not in a function); did you mean > > 's3cmci_dt_match'? > > MODULE_DEVICE_TABLE(of, sdhci_s3c_dt_match); > > ^ > > /git/arm-soc/include/linux/module.h:212:21: note: in definition of > > macro 'MODULE_DEVICE_TABLE' > > extern const typeof(name) __mod_##type##__##name##_device_table \ > > ^~~~ > > /git/arm-soc/include/linux/module.h:212:27: error: > > '__mod_of__sdhci_s3c_dt_match_device_table' aliased to undefined > > symbol 'sdhci_s3c_dt_match' > > extern const typeof(name) __mod_##type##__##name##_device_table \ > > ^ > > /git/arm-soc/drivers/mmc/host/s3cmci.c:1844:1: note: in expansion of > > macro 'MODULE_DEVICE_TABLE' > > MODULE_DEVICE_TABLE(of, sdhci_s3c_dt_match); > > ^~~~~~~~~~~~~~~~~~~ > > /git/arm-soc/scripts/Makefile.build:314: recipe for target > > 'drivers/mmc/host/s3cmci.o' failed > > > > Can you send a fix? > > Never mind, I am dropping the patches from my next branch as those > clearly haven't been built/tested by Sergio properly. It's better that > he re-spins them. > > Arnd, thanks for reporting and even fixing some of the problems! > > Kind regards > Uffe Arnd, thanks for reporting the error. I have built/tested the patches, but only as a built-in feature, and this error occurs when enabled as a module. I will re-spins them and send v6. Best regards, Sergio Prado -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html