[PATCH] arm64: dts: hi6220: enable DMA in spi0

[PATCH] arm64: dts: hi6220: enable DMA in spi0

[Guodong Xu]

From: Wang Xiaoyin <hw.wangxiaoyin-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>

Enable DMA in spi0.

Cc: Antonio Borneo <borneo.antonio-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Signed-off-by: Zhong Kaihua <zhongkaihua-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Signed-off-by: Guodong Xu <guodong.xu-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Signed-off-by: Wang Xiaoyin <hw.wangxiaoyin-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
---
 arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
index 470461d..e40625f 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
@@ -682,7 +682,8 @@
 			reg = <0x0 0xf7106000 0x0 0x1000>;
 			interrupts = <0 50 4>;
 			bus-id = <0>;
-			enable-dma = <0>;
+			dmas =  <&dma0 0 &dma0 1>;
+			dma-names = "rx", "tx";
 			clocks = <&sys_ctrl HI6220_SPI_CLK>;
 			clock-names = "apb_pclk";
 			pinctrl-names = "default";
-- 
2.10.2

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] arm64: dts: hi6220: enable DMA in spi0

[Antonio Borneo]

On Tue, Mar 21, 2017 at 8:08 AM, Guodong Xu <guodong.xu@linaro.org> wrote:
> From: Wang Xiaoyin <hw.wangxiaoyin@hisilicon.com>
>
> Enable DMA in spi0.

Hi Guodong, Xiaoyin,

added linux-spi in copy.

Actually the patch does not enable the DMA. The commit message is not correct.

> Cc: Antonio Borneo <borneo.antonio@gmail.com>
> Signed-off-by: Zhong Kaihua <zhongkaihua@huawei.com>
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
> Signed-off-by: Wang Xiaoyin <hw.wangxiaoyin@hisilicon.com>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 470461d..e40625f 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -682,7 +682,8 @@
>                         reg = <0x0 0xf7106000 0x0 0x1000>;
>                         interrupts = <0 50 4>;
>                         bus-id = <0>;
> -                       enable-dma = <0>;
> +                       dmas =  <&dma0 0 &dma0 1>;
> +                       dma-names = "rx", "tx";

The controller spi0 is a standard ARM PL022.
This patch removes the nonexistent property "enable-dma" and specifies
which DMA controller and which DMA channels are connected to spi0.
The values are coherent with the documentation available for hi6220.

Apart from the commit message, I'm fine with this patch.

On PL022 the DMA is not enabled in the DT node of the controller but
in the DT node of each spi device, through the property
"pl022,com-mode".
A separate patch should eventually enable the DMA for those spi
devices that require it.

Best Regards,
Antonio

>                         clocks = <&sys_ctrl HI6220_SPI_CLK>;
>                         clock-names = "apb_pclk";
>                         pinctrl-names = "default";
> --
> 2.10.2
>

Re: [PATCH] arm64: dts: hi6220: enable DMA in spi0

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 996 bytes --]

Hi Wang,

[auto build test ERROR on robh/for-next]
[also build test ERROR on v4.11-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Guodong-Xu/arm64-dts-hi6220-enable-DMA-in-spi0/20170323-100144
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm64 

All errors (new ones prefixed by >>):

>> ERROR: Input tree has errors, aborting (use -f to force output)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33980 bytes --]