Devicetree
 help / color / mirror / Atom feed
From: Icenowy Zheng <icenowy@aosc.io>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	devicetree@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@googlegroups.com, Chen-Yu Tsai <wens@csie.org>
Subject: Re: [linux-sunxi] Re: [PATCH 10/11] arm64: allwinner: a64: enable AXP803 regulators for Pine64
Date: Wed, 05 Apr 2017 14:15:43 +0800	[thread overview]
Message-ID: <20170405061552.C15201033DF@relay.mailchannels.net> (raw)


2017年4月5日 14:13于 Maxime Ripard <maxime.ripard@free-electrons.com>写道:
>
> On Wed, Apr 05, 2017 at 02:01:44AM +0800, Icenowy Zheng wrote: 
> > Add support of AXP803 regulators in the Pine64 device tree, in order to 
> > enable many future functionalities, e.g. Wi-Fi. 
> > 
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> 
> > --- 
> >  .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 109 +++++++++++++++++++++ 
> >  1 file changed, 109 insertions(+) 
> > 
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts 
> > index 2132d8e6cb3d..7da074f95065 100644 
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts 
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts 
> > @@ -106,6 +106,115 @@ 
> >  }; 
> >  }; 
> >  
> > +#include "axp803.dtsi" 
> > + 
> > +&reg_aldo1 { 
> > + regulator-min-microvolt = <2800000>; 
> > + regulator-max-microvolt = <2800000>; 
> > + regulator-name = "vcc-csi"; 
> > +}; 
> > + 
> > +&reg_aldo2 { 
> > + regulator-always-on; 
> > + regulator-min-microvolt = <1800000>; 
> > + regulator-max-microvolt = <3300000>; 
> > + regulator-name = "vcc-pl"; 
> > +}; 
> > + 
> > +&reg_aldo3 { 
> > + regulator-always-on; 
> > + regulator-min-microvolt = <2700000>; 
> > + regulator-max-microvolt = <3300000>; 
> > + regulator-name = "vcc-pll-avcc"; 
> > +}; 
> > + 
> > +&reg_dc1sw { 
> > + regulator-name = "vcc-phy"; 
> > +}; 
> > + 
> > +&reg_dcdc1 { 
> > + regulator-always-on; 
> > + regulator-min-microvolt = <3300000>; 
> > + regulator-max-microvolt = <3300000>; 
> > + regulator-name = "vcc-3v3"; 
> > +}; 
> > + 
> > +&reg_dcdc2 { 
> > + regulator-always-on; 
> > + regulator-min-microvolt = <1000000>; 
> > + regulator-max-microvolt = <1300000>; 
> > + regulator-name = "vdd-cpux"; 
> > +}; 
> > + 
> > +/* DCDC3 is polyphased with DCDC2 */ 
> > + 
> > +&reg_dcdc5 { 
> > + regulator-always-on; 
> > + regulator-min-microvolt = <1500000>; 
> > + regulator-max-microvolt = <1500000>; 
> > + regulator-name = "vcc-dram"; 
> > +}; 
> > + 
> > +&reg_dcdc6 { 
> > + regulator-always-on; 
> > + regulator-min-microvolt = <1100000>; 
> > + regulator-max-microvolt = <1100000>; 
> > + regulator-name = "vdd-sys"; 
> > +}; 
> > + 
> > +&reg_dldo1 { 
> > + regulator-min-microvolt = <3300000>; 
> > + regulator-max-microvolt = <3300000>; 
> > + regulator-name = "vcc-hdmi"; 
> > +}; 
> > + 
> > +&reg_dldo2 { 
> > + regulator-min-microvolt = <3300000>; 
> > + regulator-max-microvolt = <3300000>; 
> > + regulator-name = "vcc-mipi"; 
> > +}; 
> > + 
> > +&reg_dldo3 { 
> > + regulator-min-microvolt = <3300000>; 
> > + regulator-max-microvolt = <3300000>; 
> > + regulator-name = "avdd-csi"; 
> > +}; 
> > + 
> > +&reg_dldo4 { 
> > + regulator-min-microvolt = <3300000>; 
> > + regulator-max-microvolt = <3300000>; 
> > + regulator-name = "vcc-wifi"; 
> > +}; 
> > + 
> > +&reg_eldo1 { 
> > + regulator-min-microvolt = <1800000>; 
> > + regulator-max-microvolt = <1800000>; 
> > + regulator-name = "cpvdd"; 
> > +}; 
> > + 
> > +&reg_eldo3 { 
> > + regulator-min-microvolt = <1800000>; 
> > + regulator-max-microvolt = <1800000>; 
> > + regulator-name = "vdd-1v8-csi"; 
> > +}; 
> > + 
> > +&reg_fldo1 { 
> > + regulator-min-microvolt = <1200000>; 
> > + regulator-max-microvolt = <1200000>; 
> > + regulator-name = "vcc-1v2-hsic"; 
> > +}; 
> > + 
> > +&reg_fldo2 { 
> > + regulator-always-on; 
> > + regulator-min-microvolt = <1100000>; 
> > + regulator-max-microvolt = <1100000>; 
> > + regulator-name = "vdd-cpus"; 
> > +}; 
>
> Why do you need to always power the AR100 on? 

It's for CPUS power domain, not the AR100 processor.

Kill it will lead to instantly system hang.

>
> Maxime 
>
> -- 
> Maxime Ripard, Free Electrons 
> Embedded Linux and Kernel engineering 
> http://free-electrons.com 
>
> -- 
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group. 
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. 
> For more options, visit https://groups.google.com/d/optout. 

             reply	other threads:[~2017-04-05  6:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05  6:15 Icenowy Zheng [this message]
     [not found] ` <20170405061552.C15201033DF-Y9/x5g2N/Tt0ykcd9G8QkxTxI0vvWBSX@public.gmane.org>
2017-04-05  8:08   ` Re: [PATCH 10/11] arm64: allwinner: a64: enable AXP803 regulators for Pine64 Maxime Ripard
2017-04-05  8:25     ` Icenowy Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170405061552.C15201033DF@relay.mailchannels.net \
    --to=icenowy@aosc.io \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox