From: Christopher Bostic <cbostic@linux.vnet.ibm.com>
To: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
rostedt@goodmis.org, mingo@redhat.com,
gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Jeremy Kerr <jk@ozlabs.org>,
joel@jms.id.au, linux-kernel@vger.kernel.org, andrew@aj.id.au,
alistair@popple.id.au, benh@kernel.crashing.org,
Chris Bostic <cbostic@linux.vnet.ibm.com>
Subject: [PATCH v6 23/23] drivers/fsi: Use asynchronous slave mode
Date: Mon, 10 Apr 2017 14:47:06 -0500 [thread overview]
Message-ID: <20170410194706.64280-24-cbostic@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170410194706.64280-1-cbostic@linux.vnet.ibm.com>
From: Jeremy Kerr <jk@ozlabs.org>
For slaves that are behind a software-clocked master, we want FSI CFAMs
to run asynchronously to the FSI clock, so set up our slaves to be in
async mode.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Chris Bostic <cbostic@linux.vnet.ibm.com>
---
drivers/fsi/fsi-core.c | 22 +++++++++++++++++++++-
drivers/fsi/fsi-master-gpio.c | 1 +
drivers/fsi/fsi-master.h | 2 ++
3 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
index 747d0e3..a6ed34f 100644
--- a/drivers/fsi/fsi-core.c
+++ b/drivers/fsi/fsi-core.c
@@ -47,6 +47,7 @@
#define FSI_SMODE 0x0 /* R/W: Mode register */
#define FSI_SISC 0x8 /* R/W: Interrupt condition */
#define FSI_SSTAT 0x14 /* R : Slave status */
+#define FSI_LLMODE 0x100 /* R/W: Link layer mode register */
/*
* SMODE fields
@@ -62,6 +63,11 @@
#define FSI_SMODE_LBCRR_SHIFT 8 /* Clk ratio shift */
#define FSI_SMODE_LBCRR_MASK 0xf /* Clk ratio mask */
+/*
+ * LLMODE fields
+ */
+#define FSI_LLMODE_ASYNC 0x1
+
#define FSI_SLAVE_SIZE_23b 0x800000
static DEFINE_IDA(master_ida);
@@ -560,8 +566,8 @@ static void fsi_slave_release(struct device *dev)
static int fsi_slave_init(struct fsi_master *master, int link, uint8_t id)
{
+ uint32_t chip_id, llmode;
struct fsi_slave *slave;
- uint32_t chip_id;
uint8_t crc;
int rc;
@@ -597,6 +603,20 @@ static int fsi_slave_init(struct fsi_master *master, int link, uint8_t id)
return -ENODEV;
}
+ /* If we're behind a master that doesn't provide a self-running bus
+ * clock, put the slave into async mode
+ */
+ if (master->flags & FSI_MASTER_FLAG_SWCLOCK) {
+ llmode = cpu_to_be32(FSI_LLMODE_ASYNC);
+ rc = fsi_master_write(master, link, id,
+ FSI_SLAVE_BASE + FSI_LLMODE,
+ &llmode, sizeof(llmode));
+ if (rc)
+ dev_warn(&master->dev,
+ "can't set llmode on slave:%02x:%02x %d\n",
+ link, id, rc);
+ }
+
/* We can communicate with a slave; create the slave device and
* register.
*/
diff --git a/drivers/fsi/fsi-master-gpio.c b/drivers/fsi/fsi-master-gpio.c
index 5d9e0b0..d5cce88 100644
--- a/drivers/fsi/fsi-master-gpio.c
+++ b/drivers/fsi/fsi-master-gpio.c
@@ -569,6 +569,7 @@ static int fsi_master_gpio_probe(struct platform_device *pdev)
master->gpio_mux = gpio;
master->master.n_links = 1;
+ master->master.flags = FSI_MASTER_FLAG_SWCLOCK;
master->master.read = fsi_master_gpio_read;
master->master.write = fsi_master_gpio_write;
master->master.term = fsi_master_gpio_term;
diff --git a/drivers/fsi/fsi-master.h b/drivers/fsi/fsi-master.h
index d6a4885..fd39924 100644
--- a/drivers/fsi/fsi-master.h
+++ b/drivers/fsi/fsi-master.h
@@ -19,6 +19,8 @@
#include <linux/device.h>
+#define FSI_MASTER_FLAG_SWCLOCK 0x1
+
struct fsi_master {
struct device dev;
int idx;
--
1.8.2.2
prev parent reply other threads:[~2017-04-10 19:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170410194706.64280-1-cbostic@linux.vnet.ibm.com>
2017-04-10 19:46 ` [PATCH v6 02/23] drivers/fsi: Add slave definition Christopher Bostic
2017-04-10 19:46 ` [PATCH v6 03/23] drivers/fsi: Add empty master scan Christopher Bostic
2017-04-10 19:46 ` [PATCH v6 04/23] drivers/fsi: Add crc4 helpers Christopher Bostic
2017-04-10 19:46 ` [PATCH v6 07/23] drivers/fsi: Implement slave initialisation Christopher Bostic
[not found] ` <20170410194706.64280-8-cbostic-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-05-02 6:24 ` Joel Stanley
[not found] ` <CACPK8XeQnqD3TV_+38hTjb8Qf4R7Um6Eztuun-T6vTMvigw+cQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-02 18:58 ` Christopher Bostic
2017-04-10 19:46 ` [PATCH v6 08/23] drivers/fsi: Set slave SMODE to init communication Christopher Bostic
2017-04-10 19:46 ` [PATCH v6 09/23] drivers/fsi: scan slaves & register devices Christopher Bostic
2017-05-10 7:30 ` Joel Stanley
2017-05-10 18:24 ` Christopher Bostic
[not found] ` <20170410194706.64280-1-cbostic-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-04-10 19:46 ` [PATCH v6 01/23] drivers/fsi: Add fsi master definition Christopher Bostic
2017-04-10 19:46 ` [PATCH v6 05/23] drivers/fsi: Add slave & master read/write APIs Christopher Bostic
2017-04-10 19:46 ` [PATCH v6 06/23] drivers/fsi: Set up links for slave communication Christopher Bostic
2017-04-10 19:46 ` [PATCH v6 10/23] drivers/fsi: Add device read/write/peek API Christopher Bostic
[not found] ` <20170410194706.64280-11-cbostic-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-05-02 5:25 ` [v6,10/23] " Brad Bishop
2017-05-10 8:13 ` [PATCH v6 10/23] " Joel Stanley
[not found] ` <CACPK8Xewjnpvc3sN=X9tMm7NP6rQ=NHKDuxwYO4DFjRw63PP8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-10 18:38 ` Christopher Bostic
2017-04-10 19:46 ` [PATCH v6 11/23] drivers/fsi: Add master unscan Christopher Bostic
[not found] ` <20170410194706.64280-12-cbostic-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-05-10 7:31 ` Joel Stanley
[not found] ` <CACPK8Xd5g+tZ7_pTO19YhDhyAUggp2fN2YDp7-1SSP+-9qZu9w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-10 18:33 ` Christopher Bostic
2017-04-10 19:46 ` [PATCH v6 13/23] drivers/fsi: Add client driver register utilities Christopher Bostic
2017-04-10 19:46 ` [PATCH v6 15/23] drivers/fsi: expose direct-access slave API Christopher Bostic
2017-04-10 19:47 ` [PATCH v6 18/23] drivers/fsi: Document FSI master sysfs files in ABI Christopher Bostic
2017-05-10 7:30 ` Joel Stanley
[not found] ` <CACPK8Xc4kv1Y_82ShYAfNjzf480Ab1ws95QSxPT8VE2XF+nueA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-10 18:20 ` Christopher Bostic
2017-04-10 19:47 ` [PATCH v6 19/23] drivers/fsi: Add GPIO based FSI master Christopher Bostic
[not found] ` <20170410194706.64280-20-cbostic-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-05-10 7:30 ` Joel Stanley
[not found] ` <CACPK8Xf1Y31+HBHb0ErpnZ4xVM+bzfHV-khj-kz8Unk1cTx6gw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-10 18:15 ` Christopher Bostic
[not found] ` <c05599db-7767-e712-7199-7d5a4ac6486f-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-05-11 1:58 ` Jeremy Kerr
[not found] ` <a079022b-8434-a204-c9b4-696a0580fc8c-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>
2017-05-11 16:14 ` Christopher Bostic
2017-04-10 19:47 ` [PATCH v6 21/23] drivers/fsi: Add SCOM FSI client device driver Christopher Bostic
2017-04-10 19:47 ` [PATCH v6 22/23] drivers/ fsi: Add hub master support Christopher Bostic
2017-04-10 19:46 ` [PATCH v6 12/23] drivers/fsi: Add documentation for GPIO bindings Christopher Bostic
2017-04-10 19:46 ` [PATCH v6 14/23] drivers/fsi: Add sysfs files for FSI master & slave accesses Christopher Bostic
2017-04-10 19:46 ` [PATCH v6 16/23] drivers/fsi: Add tracepoints for low-level operations Christopher Bostic
2017-04-10 19:47 ` [PATCH v6 17/23] drivers/fsi: Add error handling for slave communication errors Christopher Bostic
2017-04-10 19:47 ` [PATCH v6 20/23] drivers/fsi/gpio: Add tracepoints for GPIO master Christopher Bostic
2017-04-10 19:47 ` Christopher Bostic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410194706.64280-24-cbostic@linux.vnet.ibm.com \
--to=cbostic@linux.vnet.ibm.com \
--cc=alistair@popple.id.au \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=robh+dt@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).