From: Lee Jones <lee.jones@linaro.org>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Liam Girdwood <lgirdwood@gmail.com>,
devicetree@vger.kernel.org, linux-sunxi@googlegroups.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 08/11] mfd: axp20x: add axp20x-regulator cell for AXP803
Date: Tue, 11 Apr 2017 15:03:34 +0100 [thread overview]
Message-ID: <20170411140334.7dqrrvjsyoqa2jdf@dell> (raw)
In-Reply-To: <20170407183441.58750-9-icenowy@aosc.io>
On Sat, 08 Apr 2017, Icenowy Zheng wrote:
> As axp20x-regulator now supports AXP803, add a cell for it.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> drivers/mfd/axp20x.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 2268a6a9aa2c..08b9bbd5bd71 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -839,6 +839,8 @@ static struct mfd_cell axp803_cells[] = {
> .name = "axp20x-pek",
> .num_resources = ARRAY_SIZE(axp803_pek_resources),
> .resources = axp803_pek_resources,
> + }, {
> + .name = "axp20x-regulator",
I'd prefer it if you placed single lined entries on one line.
Like this:
{ .name = "axp20x-regulator" }
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-04-11 14:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 18:34 [PATCH v2 00/11] AXP803 PMIC support for Pine64 Icenowy Zheng
[not found] ` <20170407183441.58750-1-icenowy-h8G6r0blFSE@public.gmane.org>
2017-04-07 18:34 ` [PATCH v2 01/11] arm64: allwinner: a64: enable RSB on A64 Icenowy Zheng
2017-04-07 18:34 ` [PATCH v2 02/11] arm64: allwinner: a64: add NMI controller " Icenowy Zheng
2017-04-07 18:34 ` [PATCH v2 03/11] dt-bindings: add device tree binding for X-Powers AXP803 PMIC Icenowy Zheng
[not found] ` <20170407183441.58750-4-icenowy-h8G6r0blFSE@public.gmane.org>
2017-04-11 14:04 ` Lee Jones
2017-04-11 15:00 ` Icenowy Zheng
2017-04-11 15:02 ` Chen-Yu Tsai
[not found] ` <CAGb2v65UiFqjYES3hF-S6THZ5Xu-HRS9R7Ngk8xeP1rZajsr7w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-11 16:29 ` Lee Jones
2017-04-13 19:56 ` Rob Herring
2017-04-07 18:34 ` [PATCH v2 04/11] mfd: axp20x: support AXP803 variant Icenowy Zheng
[not found] ` <20170407183441.58750-5-icenowy-h8G6r0blFSE@public.gmane.org>
2017-04-11 14:04 ` Lee Jones
2017-04-07 18:34 ` [PATCH v2 05/11] arm64: allwinner: a64: add AXP803 node to Pine64 device tree Icenowy Zheng
2017-04-07 18:34 ` [PATCH v2 06/11] dt-bindings: add AXP803's regulator info Icenowy Zheng
[not found] ` <20170407183441.58750-7-icenowy-h8G6r0blFSE@public.gmane.org>
2017-04-11 14:03 ` Lee Jones
2017-04-13 19:57 ` Rob Herring
2017-04-07 18:34 ` [PATCH v2 07/11] regulator: axp20x-regulator: add support for AXP803 Icenowy Zheng
[not found] ` <20170407183441.58750-8-icenowy-h8G6r0blFSE@public.gmane.org>
2017-04-11 14:03 ` Lee Jones
2017-04-07 18:34 ` [PATCH v2 08/11] mfd: axp20x: add axp20x-regulator cell " Icenowy Zheng
2017-04-11 14:03 ` Lee Jones [this message]
2017-04-07 18:34 ` [PATCH v2 09/11] arm64: allwinner: a64: add DTSI file for AXP803 PMIC Icenowy Zheng
2017-04-07 18:34 ` [PATCH v2 10/11] arm64: allwinner: a64: enable AXP803 regulators for Pine64 Icenowy Zheng
2017-04-07 18:34 ` [PATCH v2 11/11] arm64: allwinner: a64: enable Wi-Fi " Icenowy Zheng
[not found] ` <20170407183441.58750-12-icenowy-h8G6r0blFSE@public.gmane.org>
2017-04-14 16:56 ` Andreas Färber
[not found] ` <e51897d2-aa9d-1f4b-3fe0-e88246a9e438-l3A5Bk7waGM@public.gmane.org>
2017-04-17 7:59 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411140334.7dqrrvjsyoqa2jdf@dell \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox