From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH V2] PM / OPP: Use - instead of @ for DT entries Date: Fri, 14 Apr 2017 07:20:10 -0700 Message-ID: <20170414142010.GS5339@atomide.com> References: <70e7c7ee13722ab9c73cb073f88502eaf1ada5f5.1491816050.git.viresh.kumar@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <70e7c7ee13722ab9c73cb073f88502eaf1ada5f5.1491816050.git.viresh.kumar@linaro.org> Sender: linux-pm-owner@vger.kernel.org To: Viresh Kumar Cc: Rafael Wysocki , Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Viresh Kumar , Nishanth Menon , Stephen Boyd , =?utf-8?Q?Beno=C3=AEt?= Cousson , Rob Herring , Mark Rutland , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Maxime Ripard , Chen-Yu Tsai , Masahiro Yamada List-Id: devicetree@vger.kernel.org * Viresh Kumar [170410 02:24]: > Compiling the DT file with W=1, DTC warns like follows: > > Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a > unit name, but no reg property > > Fix this by replacing '@' with '-' as the OPP nodes will never have a > "reg" property. > > Reported-by: Krzysztof Kozlowski > Reported-by: Masahiro Yamada > Suggested-by: Mark Rutland > Signed-off-by: Viresh Kumar > Acked-by: Maxime Ripard (sunxi) > Reviewed-by: Chanwoo Choi > Reviewed-by: Krzysztof Kozlowski Looks good to me too: Acked-by: Tony Lindgren