* [PATCH 1/4] mfd: Add ROHM BD9571MWV-M PMIC DT bindings
@ 2017-04-16 18:07 Marek Vasut
2017-04-20 12:35 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2017-04-16 18:07 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Marek Vasut, devicetree, Rob Herring, Geert Uytterhoeven
Add DT bindings for the ROHM BD9571MWV-M PMIC. This PMIC has
the following features:
- multiple voltage monitors for 1V8, 2V5, 3V3 voltage rail
- one voltage regulator for DVFS
- two GPIOs
Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: devicetree@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-renesas-soc@vger.kernel.org
---
.../devicetree/bindings/mfd/bd9571mwv.txt | 49 ++++++++++++++++++++++
1 file changed, 49 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/bd9571mwv.txt
diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt b/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
new file mode 100644
index 000000000000..0952ee3bc30b
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
@@ -0,0 +1,49 @@
+* ROHM BD9571MWV Power Management Integrated Circuit (PMIC) bindings
+
+Required properties:
+ - compatible : Should be "rohm,bd9571mwv".
+ - reg : I2C slave address.
+ - interrupt-parent : Phandle to the parent interrupt controller.
+ - interrupts : The interrupt line the device is connected to.
+ - interrupt-controller : Marks the device node as an interrupt controller.
+ - #interrupt-cells : The number of cells to describe an IRQ, should be 2.
+ The first cell is the IRQ number.
+ The second cell is the flags, encoded as trigger
+ masks from ../interrupt-controller/interrupts.txt.
+ - gpio-controller : Marks the device node as a GPIO Controller.
+ - #gpio-cells : Should be two. The first cell is the pin number and
+ the second cell is used to specify flags.
+ See ../gpio/gpio.txt for more information.
+ - regulators: : List of child nodes that specify the regulator
+ initialization data. Child nodes must be named
+ after their hardware counterparts:
+ - vd18
+ - vd25
+ - vd33
+ - dvfs
+ Each child node is defined using the standard
+ binding for regulators.
+
+Example:
+
+ pmic: bd9571mwv@30 {
+ compatible = "rohm,bd9571mwv";
+ reg = <0x30>;
+ interrupt-parent = <&gpio2>;
+ interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ regulators {
+ dvfs: dvfs {
+ compatible = "regulator-fixed";
+ regulator-name = "dvfs";
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <1030000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ };
+ };
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/4] mfd: Add ROHM BD9571MWV-M PMIC DT bindings
2017-04-16 18:07 [PATCH 1/4] mfd: Add ROHM BD9571MWV-M PMIC DT bindings Marek Vasut
@ 2017-04-20 12:35 ` Geert Uytterhoeven
[not found] ` <CAMuHMdUUkZ_si8DAmvY_KvNF8tO=q2wHzjqRCjxXJD3-XxxJFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2017-04-20 12:35 UTC (permalink / raw)
To: Marek Vasut
Cc: Linux-Renesas, Marek Vasut, devicetree@vger.kernel.org,
Rob Herring, Geert Uytterhoeven
Hi Marek,
On Sun, Apr 16, 2017 at 8:07 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> Add DT bindings for the ROHM BD9571MWV-M PMIC. This PMIC has
> the following features:
> - multiple voltage monitors for 1V8, 2V5, 3V3 voltage rail
> - one voltage regulator for DVFS
> - two GPIOs
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: devicetree@vger.kernel.org
> Cc: Rob Herring <robh@kernel.org>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: linux-renesas-soc@vger.kernel.org
> ---
> .../devicetree/bindings/mfd/bd9571mwv.txt | 49 ++++++++++++++++++++++
> 1 file changed, 49 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/bd9571mwv.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt b/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
> new file mode 100644
> index 000000000000..0952ee3bc30b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
> @@ -0,0 +1,49 @@
> +* ROHM BD9571MWV Power Management Integrated Circuit (PMIC) bindings
> +
> +Required properties:
> + - compatible : Should be "rohm,bd9571mwv".
> + - reg : I2C slave address.
> + - interrupt-parent : Phandle to the parent interrupt controller.
> + - interrupts : The interrupt line the device is connected to.
> + - interrupt-controller : Marks the device node as an interrupt controller.
> + - #interrupt-cells : The number of cells to describe an IRQ, should be 2.
> + The first cell is the IRQ number.
> + The second cell is the flags, encoded as trigger
> + masks from ../interrupt-controller/interrupts.txt.
> + - gpio-controller : Marks the device node as a GPIO Controller.
> + - #gpio-cells : Should be two. The first cell is the pin number and
> + the second cell is used to specify flags.
> + See ../gpio/gpio.txt for more information.
> + - regulators: : List of child nodes that specify the regulator
> + initialization data. Child nodes must be named
> + after their hardware counterparts:
> + - vd18
> + - vd25
> + - vd33
> + - dvfs
Missing vd09, which is used for VDD0.8 on Salvator-X.
> + Each child node is defined using the standard
> + binding for regulators.
> +
> +Example:
> +
> + pmic: bd9571mwv@30 {
> + compatible = "rohm,bd9571mwv";
> + reg = <0x30>;
> + interrupt-parent = <&gpio2>;
> + interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + regulators {
> + dvfs: dvfs {
> + compatible = "regulator-fixed";
What's the purpose of this compatible value?
> + regulator-name = "dvfs";
> + regulator-min-microvolt = <750000>;
> + regulator-max-microvolt = <1030000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> + };
> + };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/4] mfd: Add ROHM BD9571MWV-M PMIC DT bindings
[not found] ` <CAMuHMdUUkZ_si8DAmvY_KvNF8tO=q2wHzjqRCjxXJD3-XxxJFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2017-04-20 12:51 ` Marek Vasut
[not found] ` <dbfbadbd-9850-4a8e-581f-abd5ae39e841-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2017-04-20 12:51 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linux-Renesas, Marek Vasut,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring,
Geert Uytterhoeven
On 04/20/2017 02:35 PM, Geert Uytterhoeven wrote:
> Hi Marek,
Hi!
> On Sun, Apr 16, 2017 at 8:07 PM, Marek Vasut <marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> Add DT bindings for the ROHM BD9571MWV-M PMIC. This PMIC has
>> the following features:
>> - multiple voltage monitors for 1V8, 2V5, 3V3 voltage rail
>> - one voltage regulator for DVFS
>> - two GPIOs
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> Cc: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>> Cc: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
>> Cc: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> ---
>> .../devicetree/bindings/mfd/bd9571mwv.txt | 49 ++++++++++++++++++++++
>> 1 file changed, 49 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/bd9571mwv.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt b/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
>> new file mode 100644
>> index 000000000000..0952ee3bc30b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
>> @@ -0,0 +1,49 @@
>> +* ROHM BD9571MWV Power Management Integrated Circuit (PMIC) bindings
>> +
>> +Required properties:
>> + - compatible : Should be "rohm,bd9571mwv".
>> + - reg : I2C slave address.
>> + - interrupt-parent : Phandle to the parent interrupt controller.
>> + - interrupts : The interrupt line the device is connected to.
>> + - interrupt-controller : Marks the device node as an interrupt controller.
>> + - #interrupt-cells : The number of cells to describe an IRQ, should be 2.
>> + The first cell is the IRQ number.
>> + The second cell is the flags, encoded as trigger
>> + masks from ../interrupt-controller/interrupts.txt.
>> + - gpio-controller : Marks the device node as a GPIO Controller.
>> + - #gpio-cells : Should be two. The first cell is the pin number and
>> + the second cell is used to specify flags.
>> + See ../gpio/gpio.txt for more information.
>> + - regulators: : List of child nodes that specify the regulator
>> + initialization data. Child nodes must be named
>> + after their hardware counterparts:
>> + - vd18
>> + - vd25
>> + - vd33
>> + - dvfs
>
> Missing vd09, which is used for VDD0.8 on Salvator-X.
This is not supported by the driver, I don't think we should prematurely
add it into the bindings. We can add it later though.
>> + Each child node is defined using the standard
>> + binding for regulators.
>> +
>> +Example:
>> +
>> + pmic: bd9571mwv@30 {
>> + compatible = "rohm,bd9571mwv";
>> + reg = <0x30>;
>> + interrupt-parent = <&gpio2>;
>> + interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> +
>> + regulators {
>> + dvfs: dvfs {
>> + compatible = "regulator-fixed";
>
> What's the purpose of this compatible value?
The purpose is for it to be removed in V2 , thanks for catching this one.
>> + regulator-name = "dvfs";
>> + regulator-min-microvolt = <750000>;
>> + regulator-max-microvolt = <1030000>;
>> + regulator-boot-on;
>> + regulator-always-on;
>> + };
>> + };
>> + };
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
--
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/4] mfd: Add ROHM BD9571MWV-M PMIC DT bindings
[not found] ` <dbfbadbd-9850-4a8e-581f-abd5ae39e841-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2017-04-20 14:09 ` Rob Herring
2017-04-20 16:59 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2017-04-20 14:09 UTC (permalink / raw)
To: Marek Vasut
Cc: Geert Uytterhoeven, Linux-Renesas, Marek Vasut,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Geert Uytterhoeven
On Thu, Apr 20, 2017 at 02:51:40PM +0200, Marek Vasut wrote:
> On 04/20/2017 02:35 PM, Geert Uytterhoeven wrote:
> > Hi Marek,
>
> Hi!
>
> > On Sun, Apr 16, 2017 at 8:07 PM, Marek Vasut <marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >> Add DT bindings for the ROHM BD9571MWV-M PMIC. This PMIC has
> >> the following features:
> >> - multiple voltage monitors for 1V8, 2V5, 3V3 voltage rail
> >> - one voltage regulator for DVFS
> >> - two GPIOs
> >>
> >> Signed-off-by: Marek Vasut <marek.vasut+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> >> Cc: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> >> Cc: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
> >> Cc: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> >> ---
> >> .../devicetree/bindings/mfd/bd9571mwv.txt | 49 ++++++++++++++++++++++
> >> 1 file changed, 49 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/mfd/bd9571mwv.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt b/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
> >> new file mode 100644
> >> index 000000000000..0952ee3bc30b
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
> >> @@ -0,0 +1,49 @@
> >> +* ROHM BD9571MWV Power Management Integrated Circuit (PMIC) bindings
> >> +
> >> +Required properties:
> >> + - compatible : Should be "rohm,bd9571mwv".
> >> + - reg : I2C slave address.
> >> + - interrupt-parent : Phandle to the parent interrupt controller.
> >> + - interrupts : The interrupt line the device is connected to.
> >> + - interrupt-controller : Marks the device node as an interrupt controller.
> >> + - #interrupt-cells : The number of cells to describe an IRQ, should be 2.
> >> + The first cell is the IRQ number.
> >> + The second cell is the flags, encoded as trigger
> >> + masks from ../interrupt-controller/interrupts.txt.
> >> + - gpio-controller : Marks the device node as a GPIO Controller.
> >> + - #gpio-cells : Should be two. The first cell is the pin number and
> >> + the second cell is used to specify flags.
> >> + See ../gpio/gpio.txt for more information.
> >> + - regulators: : List of child nodes that specify the regulator
> >> + initialization data. Child nodes must be named
> >> + after their hardware counterparts:
> >> + - vd18
> >> + - vd25
> >> + - vd33
> >> + - dvfs
> >
> > Missing vd09, which is used for VDD0.8 on Salvator-X.
>
> This is not supported by the driver, I don't think we should prematurely
> add it into the bindings. We can add it later though.
If it is trivial to add, then do so now. Bindings should be complete,
not what a driver supports.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/4] mfd: Add ROHM BD9571MWV-M PMIC DT bindings
2017-04-20 14:09 ` Rob Herring
@ 2017-04-20 16:59 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2017-04-20 16:59 UTC (permalink / raw)
To: Rob Herring
Cc: Geert Uytterhoeven, Linux-Renesas, Marek Vasut,
devicetree@vger.kernel.org, Geert Uytterhoeven
On 04/20/2017 04:09 PM, Rob Herring wrote:
> On Thu, Apr 20, 2017 at 02:51:40PM +0200, Marek Vasut wrote:
>> On 04/20/2017 02:35 PM, Geert Uytterhoeven wrote:
>>> Hi Marek,
>>
>> Hi!
>>
>>> On Sun, Apr 16, 2017 at 8:07 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
>>>> Add DT bindings for the ROHM BD9571MWV-M PMIC. This PMIC has
>>>> the following features:
>>>> - multiple voltage monitors for 1V8, 2V5, 3V3 voltage rail
>>>> - one voltage regulator for DVFS
>>>> - two GPIOs
>>>>
>>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>>>> Cc: devicetree@vger.kernel.org
>>>> Cc: Rob Herring <robh@kernel.org>
>>>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>>>> Cc: linux-renesas-soc@vger.kernel.org
>>>> ---
>>>> .../devicetree/bindings/mfd/bd9571mwv.txt | 49 ++++++++++++++++++++++
>>>> 1 file changed, 49 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/mfd/bd9571mwv.txt
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt b/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
>>>> new file mode 100644
>>>> index 000000000000..0952ee3bc30b
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
>>>> @@ -0,0 +1,49 @@
>>>> +* ROHM BD9571MWV Power Management Integrated Circuit (PMIC) bindings
>>>> +
>>>> +Required properties:
>>>> + - compatible : Should be "rohm,bd9571mwv".
>>>> + - reg : I2C slave address.
>>>> + - interrupt-parent : Phandle to the parent interrupt controller.
>>>> + - interrupts : The interrupt line the device is connected to.
>>>> + - interrupt-controller : Marks the device node as an interrupt controller.
>>>> + - #interrupt-cells : The number of cells to describe an IRQ, should be 2.
>>>> + The first cell is the IRQ number.
>>>> + The second cell is the flags, encoded as trigger
>>>> + masks from ../interrupt-controller/interrupts.txt.
>>>> + - gpio-controller : Marks the device node as a GPIO Controller.
>>>> + - #gpio-cells : Should be two. The first cell is the pin number and
>>>> + the second cell is used to specify flags.
>>>> + See ../gpio/gpio.txt for more information.
>>>> + - regulators: : List of child nodes that specify the regulator
>>>> + initialization data. Child nodes must be named
>>>> + after their hardware counterparts:
>>>> + - vd18
>>>> + - vd25
>>>> + - vd33
>>>> + - dvfs
>>>
>>> Missing vd09, which is used for VDD0.8 on Salvator-X.
>>
>> This is not supported by the driver, I don't think we should prematurely
>> add it into the bindings. We can add it later though.
>
> If it is trivial to add, then do so now. Bindings should be complete,
> not what a driver supports.
OK, will be in V2 . I actually figured out how that regulator works and
I can even set voltage.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-20 16:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-16 18:07 [PATCH 1/4] mfd: Add ROHM BD9571MWV-M PMIC DT bindings Marek Vasut
2017-04-20 12:35 ` Geert Uytterhoeven
[not found] ` <CAMuHMdUUkZ_si8DAmvY_KvNF8tO=q2wHzjqRCjxXJD3-XxxJFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-20 12:51 ` Marek Vasut
[not found] ` <dbfbadbd-9850-4a8e-581f-abd5ae39e841-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-20 14:09 ` Rob Herring
2017-04-20 16:59 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).