Devicetree
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Benoît Cousson"
	<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Marcel Partap" <mpartap-hi6Y0CQ0nG0@public.gmane.org>,
	"Michael Scott"
	<michael.scott-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: omap4-droid4: Stop disabling SRAM and GPMC
Date: Tue, 18 Apr 2017 14:17:09 +0200	[thread overview]
Message-ID: <20170418121709.fttvxuhrjo3d2vd3@earth> (raw)
In-Reply-To: <20170328004612.16350-1-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1907 bytes --]

Hi,

On Mon, Mar 27, 2017 at 05:46:12PM -0700, Tony Lindgren wrote:
> I disabled SRAM and GPMC originally when seeing errors with
> omap_barriers_init(). But that is no longer happening probably
> because the memory range is now properly configured to 1021 MB
> instead of 1024 MB. So let's enable SRAM and GPMC so we get
> omap_barriers_init() working and can idle the GPMC.
> 
> Cc: Marcel Partap <mpartap-hi6Y0CQ0nG0@public.gmane.org>
> Cc: Michael Scott <michael.scott-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Cc: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>

Tested-by: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

-- Sebastian

>  arch/arm/boot/dts/omap4-droid4-xt894.dts | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts/omap4-droid4-xt894.dts
> --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts
> +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts
> @@ -24,8 +24,7 @@
>  
>  	/*
>  	 * We seem to have only 1021 MB accessible, 1021 - 1022 is locked,
> -	 * then 1023 - 1024 seems to contain mbm. For SRAM, see the notes
> -	 * below about SRAM and L3_ICLK2 being unused by default,
> +	 * then 1023 - 1024 seems to contain mbm.
>  	 */
>  	memory {
>  		device_type = "memory";
> @@ -176,11 +175,6 @@
>  	};
>  };
>  
> -/* L3_2 interconnect is unused, SRAM, GPMC and L3_ICLK2 disabled */
> -&gpmc {
> -	status = "disabled";
> -};
> -
>  &hdmi {
>  	status = "okay";
>  	pinctrl-0 = <&dss_hdmi_pins>;
> @@ -356,11 +350,6 @@
>  	};
>  };
>  
> -/* L3_2 interconnect is unused, SRAM, GPMC and L3_ICLK2 disabled */
> -&ocmcram {
> -	status = "disabled";
> -};
> -
>  &omap4_pmx_core {
>  
>  	/* hdmi_hpd.gpio_63 */
> -- 
> 2.12.1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2017-04-18 12:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-28  0:46 [PATCH] ARM: dts: omap4-droid4: Stop disabling SRAM and GPMC Tony Lindgren
     [not found] ` <20170328004612.16350-1-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-04-18 12:17   ` Sebastian Reichel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170418121709.fttvxuhrjo3d2vd3@earth \
    --to=sre-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=michael.scott-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=mpartap-hi6Y0CQ0nG0@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox