From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names Date: Wed, 19 Apr 2017 08:52:06 +0200 Message-ID: <20170419065206.k5cb5gym35iabcbr@lukather> References: <20170418042205.27894-1-wens@csie.org> <20170418042205.27894-4-wens@csie.org> <20170418090447.dcxinewczubf26b7@lukather> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="n6one3dss25nzcni" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: devicetree , linux-arm-kernel , linux-kernel , linux-sunxi List-Id: devicetree@vger.kernel.org --n6one3dss25nzcni Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Tue, Apr 18, 2017 at 05:16:53PM +0800, Chen-Yu Tsai wrote: > On Tue, Apr 18, 2017 at 5:04 PM, Maxime Ripard > wrote: > > On Tue, Apr 18, 2017 at 12:22:05PM +0800, Chen-Yu Tsai wrote: > >> The pinmux setting nodes all have an address element in their node > >> names, however the pinctrl node does not have #address-cells. > >> > >> Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, > >> dropping identifiers for functions that only have one possible setting, > >> and using the pingroup name if the function is identically available on > >> different pingroups. > >> > >> Signed-off-by: Chen-Yu Tsai > > > > Applied, and I really like the new names. > > > > Would you make the same patch for everyone? > > I can. No guarantees on the schedule though. Sure, I know this isn't really the most entertaining and fulfilling patch to make ;) Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --n6one3dss25nzcni--