Re: [PATCH 1/3] ARM: dts: r8a7743: add PFC support

[Simon Horman <horms@verge.net.au>]

On Sat, Apr 15, 2017 at 12:09:42AM +0300, Sergei Shtylyov wrote:
> Define the generic R8A7743 part of the PFC device node.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
>  arch/arm/boot/dts/r8a7743.dtsi |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> Index: renesas/arch/arm/boot/dts/r8a7743.dtsi
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7743.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7743.dtsi
> @@ -1,7 +1,7 @@
>  /*
>   * Device Tree Source for the r8a7743 SoC
>   *
> - * Copyright (C) 2016 Cogent Embedded Inc.
> + * Copyright (C) 2016-2017 Cogent Embedded Inc.
>   *
>   * This file is licensed under the terms of the GNU General Public License
>   * version 2. This program is licensed "as is" without any warranty of any
> @@ -123,6 +123,11 @@
>  			#power-domain-cells = <1>;
>  		};
>  
> +		pfc: pin-controller@e6060000 {
> +			compatible = "renesas,pfc-r8a7743";
> +			reg = <0 0xe6060000 0 0x250>;
> +		};
> +

I am curious to know why pin-controller was chosen rather than pfc which
is dominant in the DT for Renesas SoCs. And as a follow-up question, do
you think it would be worth creating patches to make this uniform
across the DT for Renesas SoCs.

>  		dmac0: dma-controller@e6700000 {
>  			compatible = "renesas,dmac-r8a7743",
>  				     "renesas,rcar-dmac";
>