From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH v3 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Date: Mon, 24 Apr 2017 18:09:30 -0700 Message-ID: <20170425010930.GA120971@google.com> References: <1489651362-17077-1-git-send-email-boris.brezillon@free-electrons.com> <1489651362-17077-2-git-send-email-boris.brezillon@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1489651362-17077-2-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Boris Brezillon Cc: Richard Weinberger , linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Nicolas Ferre , Alexandre Belloni , Haavard Skinnemoen , Hans-Christian Egtvedt , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wenyou Yang , Josh Wu , David Woodhouse , Marek Vasut , Cyrille Pitchen , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Masahiro Yamada List-Id: devicetree@vger.kernel.org On Thu, Mar 16, 2017 at 09:02:40AM +0100, Boris Brezillon wrote: > diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c > new file mode 100644 > index 000000000000..f71b9e5d7d9d > --- /dev/null > +++ b/drivers/mtd/nand/atmel/nand-controller.c > @@ -0,0 +1,2198 @@ [...] > +static int > +atmel_hsmc_nand_controller_legacy_init(struct atmel_hsmc_nand_controller *nc) > +{ > + struct regmap_config regmap_conf = { > + .reg_bits = 32, > + .val_bits = 32, > + .reg_stride = 4, > + .val_bits = 32, You assigned val_bits twice. Is that just a harmless mistake, or did you mean to set something else? (sparse and other tools complain about this) > + }; Brian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html