From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Greer Subject: Re: [PATCH v2] NFC: trf7970a: Correct register settings for 27MHz clock Date: Wed, 26 Apr 2017 21:02:24 -0700 Message-ID: <20170427040224.GA13061@animalcreek.com> References: <1493257308-32503-1-git-send-email-geoff@kuvee.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1493257308-32503-1-git-send-email-geoff-R+k406RtEhcAvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Geoff Lansberry Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfc-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mgreer-luAo+O/VEmrlveNOaEYElw@public.gmane.org, justin-R+k406RtEhcAvxtiuMwx3w@public.gmane.org, colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org, wharms-fPG8STNUNVg@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Apr 26, 2017 at 09:41:48PM -0400, Geoff Lansberry wrote: Hi Geoff. > In prior commits the selected clock frequency does not propagate > correctly to what is written the the TRF7970A_MODULATOR_SYS_CLK_CTRL > register. > > Signed-off-by: Geoff Lansberry > --- > drivers/nfc/trf7970a.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c > index 5f040e6..c278b0e 100644 > --- a/drivers/nfc/trf7970a.c > +++ b/drivers/nfc/trf7970a.c > @@ -2079,6 +2079,13 @@ static int trf7970a_probe(struct spi_device *spi) > return -EINVAL; > } > > + if (clk_freq == TRF7970A_27MHZ_CLOCK_FREQUENCY) { > + trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_27MHZ; > + dev_dbg(trf->dev, "trf7970a configured for 27MHz crystal\n"); > + } else { > + trf->modulator_sys_clk_ctrl = 0; > + } > + > if (of_property_read_bool(np, "en2-rf-quirk")) > trf->quirks |= TRF7970A_QUIRK_EN2_MUST_STAY_LOW; Looks fine to me but please rebase it on top of current nfc-next/master as it doesn't apply to it right now. Thanks, Mark -- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html