From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 1/2] dt-bindings: rockchip-dw-mshc: add optional rockchip,default-num-phases Date: Fri, 28 Apr 2017 08:34:03 -0500 Message-ID: <20170428133403.mmdvtp3ohff6v7gh@rob-hp-laptop> References: <1492592434-81312-1-git-send-email-shawn.lin@rock-chips.com> <1492592434-81312-2-git-send-email-shawn.lin@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1492592434-81312-2-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Shawn Lin Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ulf Hansson , Ziyuan Xu , linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Doug Anderson , Jaehoon Chung , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Apr 19, 2017 at 05:00:33PM +0800, Shawn Lin wrote: > By default, dw_mmc-rockchip will execute tuning for each degree. > So we won't miss every point of the good sample windows. However, > probably the phases are linear inside the good sample window. > Actually we don't need to do tuning for each degree so that we could > save some time, for instance, probe the driver or resume from S3. > > Signed-off-by: Shawn Lin > --- > > Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt > index 520d61d..ea47ec0 100644 > --- a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt > +++ b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt > @@ -31,6 +31,10 @@ Optional Properties: > probing, low speeds or in case where all phases work at tuning time. > If not specified 0 deg will be used. > > +* rockchip,default-num-phases: The default number of times that the host > + execute tuning when needed. If not specified, the host will do tuning > + for 360 times, namely tuning for each degree. How is it default when you specify it? I would think default here is 360. Should this be common? Rob