From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet driver Date: Mon, 1 May 2017 18:10:30 +0200 Message-ID: <20170501161030.GF1285@lunn.ch> References: <20170501124520.3769-1-clabbe.montjoie@gmail.com> <20170501140133.GD31281@lunn.ch> <20170501144541.GB1285@lunn.ch> <20170501155856.GA1957@Red> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170501155856.GA1957@Red> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Corentin Labbe Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , Maxime Ripard , Russell King , Catalin Marinas , Will Deacon , Giuseppe Cavallaro , alexandre.torgue-qxv4g6HH51o@public.gmane.org, devicetree , linux-kernel , linux-arm-kernel , netdev List-Id: devicetree@vger.kernel.org > > > > Does the internal PHY have a phy driver? It seems like > > > > tx-delay-ps/rx-delay-ps are properties of this internal PHY, and so > > > > should be in the phy driver, if it has one. > > > > > > Nope. These affect the delay lines for the external PHY interface. > > I will add some sentences in the documentation to be more clear about that. Thanks > > > > > Oh, yes. I understood the patch wrong. > > > > None of the patches actually use these properties. Are they actually > > needed? We should avoid adding vendor specific properties, if they are > > not used. > > > > The board that use it is the BananaPi M3, but the SoC A83T still lack clocks support. > So theses properties is already used out of tree, and will be used in tree soon. Fair enough. Thanks Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html