Devicetree
 help / color / mirror / Atom feed
From: "jeffrey.lin" <yajohn@gmail.com>
To: dmitry.torokhov@gmail.com, bleung@chromium.org,
	groeck@chromium.org, Katherine.Hsieh@quantatw.com
Cc: jeffrey.lin@rad-ic.com, ealin.chiu@rad-ic.com,
	calvin.tseng@rad-ic.com, KP.li@rad-ic.com,
	albert.shieh@rad-ic.com, linux-kernel@vger.kernel.org,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] driver: input :touchscreen : Change Raydium firmware update parameter
Date: Thu,  4 May 2017 09:43:06 +0800	[thread overview]
Message-ID: <20170504014306.417-1-jeffrey.lin@rad-ic.com> (raw)
In-Reply-To: <20170503153717.328-1-jeffrey.lin@rad-ic.com>

Hi Guenter:
>> Change boot mode trigger parameter of Raydium firmware update.
>>

>That is a bit vague. What is changed to what, and why ?

>In other words, what prevents someone else from changing it back to
>the old value, using the same description ?

This bit control erase type as doing firmware update. We want just reserve more infomation after pass through production line. This's convenient
 for debug, so that it's okay as some one use old version.

>> Signed-off-by: jeffrey.lin <jeffrey.lin@rad-ic.com>
>> ---
>>  drivers/input/touchscreen/raydium_i2c_ts.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c b/drivers/input/touchscreen/raydium_i2c_ts.c
>> index a99fb5cac5a0..8a81257634ba 100644
>> --- a/drivers/input/touchscreen/raydium_i2c_ts.c
>> +++ b/drivers/input/touchscreen/raydium_i2c_ts.c
>> @@ -450,7 +450,7 @@ static bool raydium_i2c_boot_trigger(struct i2c_client *client)
>>                 { 0x08, 0x04, 0x09, 0x00, 0x50, 0xA5 },
>>                 { 0x08, 0x0C, 0x09, 0x00, 0x50, 0x00 },
>>                 { 0x06, 0x01, 0x00, 0x00, 0x00, 0x00 },
>> -               { 0x02, 0xA2, 0x00, 0x00, 0x00, 0x00 },
>> +               { 0x02, 0xA1, 0x00, 0x00, 0x00, 0x00 },
>>         };


Thanks.

Jeffrey

      parent reply	other threads:[~2017-05-04  1:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03 15:37 [PATCH] driver: input :touchscreen : Change Raydium firmware update parameter jeffrey.lin
2017-05-03 15:55 ` Guenter Roeck
2017-05-04  1:43 ` jeffrey.lin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170504014306.417-1-jeffrey.lin@rad-ic.com \
    --to=yajohn@gmail.com \
    --cc=KP.li@rad-ic.com \
    --cc=Katherine.Hsieh@quantatw.com \
    --cc=albert.shieh@rad-ic.com \
    --cc=bleung@chromium.org \
    --cc=calvin.tseng@rad-ic.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=ealin.chiu@rad-ic.com \
    --cc=groeck@chromium.org \
    --cc=jeffrey.lin@rad-ic.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox