From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: [PATCH v6 7/8] mfd: tps6105x: Add OF device ID table Date: Thu, 4 May 2017 01:21:06 -0400 Message-ID: <20170504052107.18995-8-javier@dowhile0.org> References: <20170504052107.18995-1-javier@dowhile0.org> Return-path: In-Reply-To: <20170504052107.18995-1-javier@dowhile0.org> Sender: linux-kernel-owner@vger.kernel.org To: linux-kernel@vger.kernel.org Cc: devicetree@vger.kernel.org, Wolfram Sang , Rob Herring , Tony Lindgren , Lee Jones , Aaro Koskinen , Javier Martinez Canillas List-Id: devicetree@vger.kernel.org The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID and that the MODALIAS reported will always be of the form i2c:. But this could change in the future so the correct approach is to have a OF device ID table if the devices are registered via OF. Signed-off-by: Javier Martinez Canillas Acked-by: Rob Herring Acked-by: Tony Lindgren Acked-by: Lee Jones --- Changes in v6: None Changes in v5: - Add Rob Herring's Acked-by tag. - Add Acked-by: Tony Lindgren 's Acked-by tag. - Add Lee Jones 's Acked-by tag. Changes in v4: None Changes in v3: - Add a vendor prefix to the compatible string (Rob Herring). Changes in v2: - Don't use of_match_ptr() to avoid build warning when CONFIG_OF is disabled. drivers/mfd/tps6105x.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/mfd/tps6105x.c b/drivers/mfd/tps6105x.c index baa12ea666fb..187848c93779 100644 --- a/drivers/mfd/tps6105x.c +++ b/drivers/mfd/tps6105x.c @@ -173,9 +173,17 @@ static const struct i2c_device_id tps6105x_id[] = { }; MODULE_DEVICE_TABLE(i2c, tps6105x_id); +static const struct of_device_id tps6105x_of_match[] = { + { .compatible = "ti,tps61050" }, + { .compatible = "ti,tps61052" }, + { }, +}; +MODULE_DEVICE_TABLE(of, tps6105x_of_match); + static struct i2c_driver tps6105x_driver = { .driver = { .name = "tps6105x", + .of_match_table = tps6105x_of_match, }, .probe = tps6105x_probe, .remove = tps6105x_remove, -- 2.9.3