* [PATCH] arch: arm64: Define big endian of IFC for LS1043a/LS1046a
@ 2017-05-04 9:10 Prabhakar Kushwaha
2017-05-04 9:10 ` [PATCH] arm: arm64: Add flash node for ls1088a qds and rdb Prabhakar Kushwaha
[not found] ` <1493889032-20857-1-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>
0 siblings, 2 replies; 4+ messages in thread
From: Prabhakar Kushwaha @ 2017-05-04 9:10 UTC (permalink / raw)
To: devicetree-u79uwXL29TY76Z2rM5mHXA, robh-DgEjT+Ai2ygdnm+yROfE0A,
mark.rutland-5wv7dgnIgG8, shawnguo-DgEjT+Ai2ygdnm+yROfE0A
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Prabhakar Kushwaha
Integrated flash controller present in LS1043A and LS1046A is big endian.
So add big endian property in the devive tree.
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>
---
arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 +
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
index 45cface..09f1775 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
@@ -223,6 +223,7 @@
ifc: ifc@1530000 {
compatible = "fsl,ifc", "simple-bus";
reg = <0x0 0x1530000 0x0 0x10000>;
+ big-endian;
interrupts = <0 43 0x4>;
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index f4b8b7e..509e6c2 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -190,6 +190,7 @@
ifc: ifc@1530000 {
compatible = "fsl,ifc", "simple-bus";
reg = <0x0 0x1530000 0x0 0x10000>;
+ big-endian;
interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
};
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] arm: arm64: Add flash node for ls1088a qds and rdb 2017-05-04 9:10 [PATCH] arch: arm64: Define big endian of IFC for LS1043a/LS1046a Prabhakar Kushwaha @ 2017-05-04 9:10 ` Prabhakar Kushwaha [not found] ` <1493889032-20857-2-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> [not found] ` <1493889032-20857-1-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> 1 sibling, 1 reply; 4+ messages in thread From: Prabhakar Kushwaha @ 2017-05-04 9:10 UTC (permalink / raw) To: devicetree, robh, mark.rutland, shawnguo Cc: Prabhakar Kushwaha, linux-arm-kernel LS1088AQDS consist of NOR, NAND and FPGA connected over IFC LS1088ARDB consist of NAND and FPGA connected over IFC. So add flash information in ifc node of device tree. Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> --- arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts | 27 +++++++++++++++++++++++ arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 20 +++++++++++++++++ arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 4 ---- 3 files changed, 47 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts index 8c3cae5..ca7eb41 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts @@ -53,6 +53,33 @@ compatible = "fsl,ls1088a-qds", "fsl,ls1088a"; }; +&ifc { + #address-cells = <2>; + #size-cells = <1>; + status = "okay"; + + ranges = <0 0 0x5 0x80000000 0x08000000 + 2 0 0x5 0x30000000 0x00010000 + 3 0 0x5 0x20000000 0x00010000>; + + nor@0,0 { + compatible = "cfi-flash"; + reg = <0x0 0x0 0x8000000>; + bank-width = <2>; + device-width = <1>; + }; + + nand@2,0 { + compatible = "fsl,ifc-nand"; + reg = <0x2 0x0 0x10000>; + }; + + fpga: board-control@3,0 { + compatible = "fsl,ls1088aqds-fpga", "fsl,fpga-qixis"; + reg = <0x3 0x0 0x0000100>; + }; +}; + &i2c0 { status = "okay"; diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts index 8a04fbb..726e167 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts @@ -53,6 +53,26 @@ compatible = "fsl,ls1088a-rdb", "fsl,ls1088a"; }; +&ifc { + #address-cells = <2>; + #size-cells = <1>; + status = "okay"; + + ranges = <0 0 0x5 0x30000000 0x00010000 + 2 0 0x5 0x20000000 0x00010000>; + + nand@0,0 { + compatible = "fsl,ifc-nand"; + reg = <0x0 0x0 0x10000>; + }; + + fpga: board-control@2,0 { + compatible = "fsl,ls1088ardb-fpga", "fsl,fpga-qixis"; + reg = <0x2 0x0 0x0000100>; + }; +}; + + &i2c0 { status = "okay"; diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi index 2946fd7..9f6bcb4 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi @@ -217,10 +217,6 @@ #address-cells = <2>; #size-cells = <1>; - ranges = <0 0 0x5 0x80000000 0x08000000 - 2 0 0x5 0x30000000 0x00010000 - 3 0 0x5 0x20000000 0x00010000>; - status = "disabled"; }; i2c0: i2c@2000000 { -- 2.7.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <1493889032-20857-2-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>]
* Re: [PATCH] arm: arm64: Add flash node for ls1088a qds and rdb [not found] ` <1493889032-20857-2-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> @ 2017-05-05 2:32 ` Shawn Guo 0 siblings, 0 replies; 4+ messages in thread From: Shawn Guo @ 2017-05-05 2:32 UTC (permalink / raw) To: Prabhakar Kushwaha Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, robh-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Thu, May 04, 2017 at 02:40:32PM +0530, Prabhakar Kushwaha wrote: > LS1088AQDS consist of NOR, NAND and FPGA connected over IFC > LS1088ARDB consist of NAND and FPGA connected over IFC. > > So add flash information in ifc node of device tree. > > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> Please fix the subject prefix. > --- > arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts | 27 +++++++++++++++++++++++ > arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 20 +++++++++++++++++ > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 4 ---- > 3 files changed, 47 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts > index 8c3cae5..ca7eb41 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts > @@ -53,6 +53,33 @@ > compatible = "fsl,ls1088a-qds", "fsl,ls1088a"; > }; > > +&ifc { Please try to sort these labeled nodes alphabetically. That said, it should be added after &i2c0. > + #address-cells = <2>; > + #size-cells = <1>; The ifc node defined in fsl-ls1088a.dtsi already has them, right? > + status = "okay"; > + > + ranges = <0 0 0x5 0x80000000 0x08000000 > + 2 0 0x5 0x30000000 0x00010000 > + 3 0 0x5 0x20000000 0x00010000>; > + > + nor@0,0 { > + compatible = "cfi-flash"; > + reg = <0x0 0x0 0x8000000>; > + bank-width = <2>; > + device-width = <1>; > + }; > + > + nand@2,0 { > + compatible = "fsl,ifc-nand"; > + reg = <0x2 0x0 0x10000>; > + }; > + > + fpga: board-control@3,0 { > + compatible = "fsl,ls1088aqds-fpga", "fsl,fpga-qixis"; > + reg = <0x3 0x0 0x0000100>; > + }; > +}; > + > &i2c0 { > status = "okay"; > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts > index 8a04fbb..726e167 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts > @@ -53,6 +53,26 @@ > compatible = "fsl,ls1088a-rdb", "fsl,ls1088a"; > }; > > +&ifc { > + #address-cells = <2>; > + #size-cells = <1>; > + status = "okay"; > + > + ranges = <0 0 0x5 0x30000000 0x00010000 > + 2 0 0x5 0x20000000 0x00010000>; > + > + nand@0,0 { > + compatible = "fsl,ifc-nand"; > + reg = <0x0 0x0 0x10000>; > + }; > + > + fpga: board-control@2,0 { > + compatible = "fsl,ls1088ardb-fpga", "fsl,fpga-qixis"; > + reg = <0x2 0x0 0x0000100>; > + }; > +}; > + > + One newline is good enough. Shawn > &i2c0 { > status = "okay"; > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > index 2946fd7..9f6bcb4 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > @@ -217,10 +217,6 @@ > #address-cells = <2>; > #size-cells = <1>; > > - ranges = <0 0 0x5 0x80000000 0x08000000 > - 2 0 0x5 0x30000000 0x00010000 > - 3 0 0x5 0x20000000 0x00010000>; > - status = "disabled"; > }; > > i2c0: i2c@2000000 { > -- > 2.7.4 > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <1493889032-20857-1-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>]
* Re: [PATCH] arch: arm64: Define big endian of IFC for LS1043a/LS1046a [not found] ` <1493889032-20857-1-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> @ 2017-05-05 2:20 ` Shawn Guo 0 siblings, 0 replies; 4+ messages in thread From: Shawn Guo @ 2017-05-05 2:20 UTC (permalink / raw) To: Prabhakar Kushwaha Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, robh-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Thu, May 04, 2017 at 02:40:31PM +0530, Prabhakar Kushwaha wrote: > Integrated flash controller present in LS1043A and LS1046A is big endian. > > So add big endian property in the devive tree. > > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> The subject prefix should be 'arm64: dts: ...'. I fixed it up and applied the patch. Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-05 2:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-04 9:10 [PATCH] arch: arm64: Define big endian of IFC for LS1043a/LS1046a Prabhakar Kushwaha
2017-05-04 9:10 ` [PATCH] arm: arm64: Add flash node for ls1088a qds and rdb Prabhakar Kushwaha
[not found] ` <1493889032-20857-2-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>
2017-05-05 2:32 ` Shawn Guo
[not found] ` <1493889032-20857-1-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>
2017-05-05 2:20 ` [PATCH] arch: arm64: Define big endian of IFC for LS1043a/LS1046a Shawn Guo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).