From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [v2, 1/5] mmc: dt: add compatible into eSDHC required properties Date: Fri, 5 May 2017 11:18:02 +0800 Message-ID: <20170505031801.GA852@dragon> References: <1493894940-47452-1-git-send-email-yangbo.lu@nxp.com> <1493894940-47452-2-git-send-email-yangbo.lu@nxp.com> <20170505023651.GW18578@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Y.B. Lu" Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , Harninder Rai , Catalin Marinas , Xiaobo Xie , Rob Herring , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Fri, May 05, 2017 at 03:01:04AM +0000, Y.B. Lu wrote: > > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt > > > b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt > > > index dedfb02..b04b248 100644 > > > --- a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt > > > +++ b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt > > > @@ -7,6 +7,7 @@ This file documents differences between the core > > > properties described by mmc.txt and the properties used by the sdhci- > > esdhc driver. > > > > > > Required properties: > > > + - compatible : should be "fsl,esdhc", or "fsl,-esdhc". > > > > I think either supported or the compatible should be listed > > explicitly. > > > > [Lu Yangbo-B47093] I think the reason we use is to avoid listing too much chips, and to avoid doc updating if new chips are added. > The checkpatch script also had considered that. > > Currently there're about 20 platforms with "fsl,-esdhc" compatible in kernel dts. > And the doc also provide an example. > Example: > > sdhci@2e000 { > compatible = "fsl,mpc8378-esdhc", "fsl,esdhc"; > > Should we still need to list all ? I anyway need an ACK from Rob on this patch. Let's see what he would say. Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html