[PATCH V4] ARM64: dts: hi6220-hikey: Add clock binding for the pmic mfd

[PATCH V4] ARM64: dts: hi6220-hikey: Add clock binding for the pmic mfd

[Daniel Lezcano]

The hi655x PMIC provides the regulators but also a clock. The latter is missing
in the definition and in the DT, thus it is no possible to enable the WiFi which
depends on this clock.

The hi655x's clock has been added and the hi655x multifunction driver has
updated with a clock-cell.

This patch adds the clock-cells for the PMIC in the DT and updates the
documentation.

Signed-off-by: Daniel Lezcano <daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Acked-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: Michael Turquette <mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
---
 Changelog:
	v4:
	   - Added Acked-by's
	   - Updated the commit message with a better description
---
 Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt | 6 ++++++
 arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts             | 1 +
 2 files changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
index 0548569..9630ac0 100644
--- a/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
+++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
@@ -16,6 +16,11 @@ Required properties:
 - reg:                  Base address of PMIC on Hi6220 SoC.
 - interrupt-controller: Hi655x has internal IRQs (has own IRQ domain).
 - pmic-gpios:           The GPIO used by PMIC IRQ.
+- #clock-cells:		From common clock binding; shall be set to 0
+
+Optional properties:
+- clock-output-names: From common clock binding to override the
+  default output clock name
 
 Example:
 	pmic: pmic@f8000000 {
@@ -24,4 +29,5 @@ Example:
 		interrupt-controller;
 		#interrupt-cells = <2>;
 		pmic-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>;
+		#clock-cells = <0>;
 	}
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
index dba3c13..e0496f7 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
@@ -325,6 +325,7 @@
 	pmic: pmic@f8000000 {
 		compatible = "hisilicon,hi655x-pmic";
 		reg = <0x0 0xf8000000 0x0 0x1000>;
+		#clock-cells = <0>;
 		interrupt-controller;
 		#interrupt-cells = <2>;
 		pmic-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V4] ARM64: dts: hi6220-hikey: Add clock binding for the pmic mfd

[Daniel Lezcano]

On Mon, Apr 24, 2017 at 10:40:22PM +0200, Daniel Lezcano wrote:
> The hi655x PMIC provides the regulators but also a clock. The latter is missing
> in the definition and in the DT, thus it is no possible to enable the WiFi which
> depends on this clock.
> 
> The hi655x's clock has been added and the hi655x multifunction driver has
> updated with a clock-cell.
> 
> This patch adds the clock-cells for the PMIC in the DT and updates the
> documentation.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Acked-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Cc: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
> Cc: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> Cc: Michael Turquette <mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> ---
>  Changelog:
> 	v4:
> 	   - Added Acked-by's
> 	   - Updated the commit message with a better description
> ---

Hi Xu Wei,

a gentle reminder for this patch. Is it ok for you?

Thanks.

  -- Daniel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V4] ARM64: dts: hi6220-hikey: Add clock binding for the pmic mfd

[Lee Jones]

On Fri, 05 May 2017, Daniel Lezcano wrote:

> On Mon, Apr 24, 2017 at 10:40:22PM +0200, Daniel Lezcano wrote:
> > The hi655x PMIC provides the regulators but also a clock. The latter is missing
> > in the definition and in the DT, thus it is no possible to enable the WiFi which
> > depends on this clock.
> > 
> > The hi655x's clock has been added and the hi655x multifunction driver has
> > updated with a clock-cell.
> > 
> > This patch adds the clock-cells for the PMIC in the DT and updates the
> > documentation.
> > 
> > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> > Acked-by: Rob Herring <robh@kernel.org>
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Stephen Boyd <sboyd@codeaurora.org>
> > Cc: Michael Turquette <mturquette@baylibre.com>
> > ---
> >  Changelog:
> > 	v4:
> > 	   - Added Acked-by's
> > 	   - Updated the commit message with a better description
> > ---
> 
> Hi Xu Wei,
> 
> a gentle reminder for this patch. Is it ok for you?

a) Pings aren't usually received well.  If you wish to remind
maintainers of a patch's existence a [RESEND] is usually the most
accepted method.

b) There is usually little point (at least it's significantly reduced)
in sending pings/resends whilst the merge-window is open.  Maintainers
usually take this time to take a little breather (rest) from their
duties.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH V4] ARM64: dts: hi6220-hikey: Add clock binding for the pmic mfd

[Daniel Lezcano]

On Fri, May 05, 2017 at 08:48:21AM +0100, Lee Jones wrote:
> On Fri, 05 May 2017, Daniel Lezcano wrote:
> 
> > On Mon, Apr 24, 2017 at 10:40:22PM +0200, Daniel Lezcano wrote:
> > > The hi655x PMIC provides the regulators but also a clock. The latter is missing
> > > in the definition and in the DT, thus it is no possible to enable the WiFi which
> > > depends on this clock.
> > > 
> > > The hi655x's clock has been added and the hi655x multifunction driver has
> > > updated with a clock-cell.
> > > 
> > > This patch adds the clock-cells for the PMIC in the DT and updates the
> > > documentation.
> > > 
> > > Signed-off-by: Daniel Lezcano <daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > > Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > > Acked-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > > Cc: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
> > > Cc: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> > > Cc: Michael Turquette <mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> > > ---
> > >  Changelog:
> > > 	v4:
> > > 	   - Added Acked-by's
> > > 	   - Updated the commit message with a better description
> > > ---
> > 
> > Hi Xu Wei,
> > 
> > a gentle reminder for this patch. Is it ok for you?
> 
> a) Pings aren't usually received well.  If you wish to remind
> maintainers of a patch's existence a [RESEND] is usually the most
> accepted method.
> b) There is usually little point (at least it's significantly reduced)
> in sending pings/resends whilst the merge-window is open.  Maintainers
> usually take this time to take a little breather (rest) from their
> duties.

This patch is the last one of a series which was already merged. As the
series has been resend and split with a different submission path, I just
wanted to make sure there were no confusion.

The sentence "a gentle reminder" is clumsy.

-- 

 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html