From: jmondi <jacopo@jmondi.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Chris Brandt <Chris.Brandt@renesas.com>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable
Date: Mon, 8 May 2017 18:01:20 +0200 [thread overview]
Message-ID: <20170508160120.GB25206@w540> (raw)
In-Reply-To: <CACRpkdZkNGSUvTrEdjbGKO1hr799QpJBGSHPVbsBibph7Jx61A@mail.gmail.com>
Hi Linus,
On Sun, May 07, 2017 at 09:52:49AM +0200, Linus Walleij wrote:
> On Fri, Apr 28, 2017 at 4:53 PM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>
> > Linus, for me it looks like better to revert that change, until we
> > will have clear picture why existing configuration parameters can't
> > work.
>
> Yeah I'll revert the binding for fixes.
>
As it seems we won't be able to proceed with the currently proposed solution,
would that be acceptable now that we use the "pinmux" property to add
flags as BIDIR and SWIO_[INPUT|OUTPUT] directly there?
This was my original proposal, rejected because we were using the "pins"
property at the time.
Quoting to the description of "pinmux":
"Each individual pin controller driver bindings documentation shall
specify how those values (pin IDs and pin multiplexing configuration)
are defined and assembled together"
Do you think the "flags" we have failed to describe as generic pin
configuration properties, fit the definition of "pin multiplexing
configuration" to be assembled with pin IDs?
As a reference this was the proposed bindings in v3:
https://www.spinics.net/lists/linux-renesas-soc/msg12792.html
Have a look at Pin multiplexing sub-nodes examples 2 and 3, with
"pinmux" in place of "renesas,pins" property.
Thanks
j
> Yours,
> Linus Walleij
next prev parent reply other threads:[~2017-05-08 16:01 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 8:19 [PATCH v5 00/10] Renesas RZ/A1 pin and gpio controller Jacopo Mondi
2017-04-27 8:19 ` [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable Jacopo Mondi
[not found] ` <1493281194-5200-2-git-send-email-jacopo+renesas-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org>
2017-04-27 14:56 ` Andy Shevchenko
[not found] ` <CAHp75Vcy1OE+9htFx9k3kQhGARQPT1C0gg3SEKZd7ULu_vkUMA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-28 8:32 ` Linus Walleij
2017-04-28 10:09 ` Geert Uytterhoeven
2017-05-07 7:50 ` Linus Walleij
2017-04-28 12:07 ` Chris Brandt
2017-04-28 12:15 ` Andy Shevchenko
2017-04-28 13:18 ` Chris Brandt
[not found] ` <SG2PR06MB11658EC3A3A80C57E6F539AC8A130-ESzmfEwOt/xoAsOJh7vwSm0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-04-28 14:53 ` Andy Shevchenko
2017-04-28 15:16 ` Chris Brandt
2017-04-28 15:37 ` Andy Shevchenko
2017-04-28 16:46 ` Chris Brandt
2017-05-07 7:52 ` Linus Walleij
2017-05-08 16:01 ` jmondi [this message]
2017-05-08 16:08 ` Andy Shevchenko
2017-05-08 17:02 ` Chris Brandt
[not found] ` <SG2PR06MB1165C1109F74DF1F15E171D48AEE0-ESzmfEwOt/xoAsOJh7vwSm0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-05-08 18:26 ` Andy Shevchenko
2017-05-08 20:05 ` Chris Brandt
[not found] ` <CAHp75VfOMKOhpkec+htA6DRQhivpSmNXy1=Ayig1W+ZC84gTLw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-08 17:25 ` jmondi
2017-05-08 17:47 ` Andy Shevchenko
2017-05-09 9:55 ` jmondi
2017-05-08 21:19 ` Linus Walleij
2017-05-09 10:54 ` Geert Uytterhoeven
2017-05-12 9:00 ` Linus Walleij
2017-05-12 9:04 ` Linus Walleij
[not found] ` <CACRpkdYsE1oeDp1HnYAFMKG2iPTg06cAtD41vxrmZPP70MJQdA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-12 11:11 ` Geert Uytterhoeven
2017-05-12 12:13 ` Chris Brandt
2017-05-12 12:25 ` Geert Uytterhoeven
2017-05-12 12:57 ` Chris Brandt
2017-05-12 11:44 ` Chris Brandt
2017-05-23 10:08 ` Dong Aisheng
[not found] ` <CAA+hA=Q9hwe7_xL440Reoi7z7m8-SScZ5E057419KSA7dQK=tQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-23 18:37 ` jmondi
2017-05-29 8:45 ` Linus Walleij
2017-05-29 10:42 ` jmondi
2017-05-30 14:12 ` Chris Brandt
2017-06-09 7:26 ` Dong Aisheng
2017-06-09 7:50 ` jmondi
2017-06-11 21:45 ` Linus Walleij
[not found] ` <CACRpkdZ=hNJLyV94FyRBSR3Dk8NLe-jEo3qbUKDya6ruqG3KNQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-12 9:44 ` jmondi
2017-06-13 6:25 ` Dong Aisheng
2017-06-15 11:11 ` jmondi
2017-06-19 15:43 ` Dong Aisheng
[not found] ` <1493281194-5200-1-git-send-email-jacopo+renesas-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org>
2017-04-27 8:19 ` [PATCH v5 02/10] pinctrl: generic: Add macros to unpack properties Jacopo Mondi
[not found] ` <1493281194-5200-3-git-send-email-jacopo+renesas-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org>
2017-04-27 8:37 ` Geert Uytterhoeven
2017-04-28 8:16 ` Linus Walleij
2017-04-28 10:06 ` Geert Uytterhoeven
[not found] ` <CACRpkdbkBtJGJ_5MVy2QSAa0zcKVm=_H+vC_kH4AUcX58TiaLg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-28 12:49 ` jmondi
2017-04-28 16:23 ` Andy Shevchenko
2017-04-27 8:19 ` [PATCH v5 04/10] dt-bindings: pinctrl: Add RZ/A1 bindings doc Jacopo Mondi
2017-04-27 8:37 ` Geert Uytterhoeven
[not found] ` <1493281194-5200-5-git-send-email-jacopo+renesas-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org>
2017-04-28 21:03 ` Rob Herring
2017-04-27 8:19 ` [PATCH v5 05/10] arm: dts: dt-bindings: Add Renesas RZ/A1 pinctrl header Jacopo Mondi
2017-04-27 8:38 ` Geert Uytterhoeven
2017-04-28 5:19 ` Simon Horman
2017-04-27 8:19 ` [PATCH v5 07/10] arm: dts: genmai: Add SCIF2 pin group Jacopo Mondi
2017-04-28 5:21 ` Simon Horman
2017-04-27 8:19 ` [PATCH v5 08/10] arm: dts: genmai: Add RIIC2 " Jacopo Mondi
2017-04-27 8:19 ` [PATCH v5 03/10] pinctrl: Renesas RZ/A1 pin and gpio controller Jacopo Mondi
2017-04-27 8:37 ` Geert Uytterhoeven
2017-04-27 8:19 ` [PATCH v5 06/10] arm: dts: r7s72100: Add pin controller node Jacopo Mondi
2017-04-27 8:19 ` [PATCH v5 09/10] arm: dts: genmai: Add user led device nodes Jacopo Mondi
2017-04-27 8:19 ` [PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group Jacopo Mondi
2017-04-27 9:56 ` Geert Uytterhoeven
2017-04-27 10:48 ` Chris Brandt
2017-04-28 5:22 ` Simon Horman
2017-04-28 7:18 ` Geert Uytterhoeven
[not found] ` <CAMuHMdU2CvipQQQ8-wxsiniHZJQmUMHv-t52Pw=sHD3YTd7Yug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-28 14:48 ` Chris Brandt
[not found] ` <SG2PR06MB11650F50D93653212039A4348A130-ESzmfEwOt/xoAsOJh7vwSm0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-05-05 12:06 ` Linus Walleij
2017-05-05 12:20 ` Geert Uytterhoeven
2017-05-05 12:45 ` Chris Brandt
[not found] ` <SG2PR06MB1165D80A4642F5A2F27FB6AA8AEB0-ESzmfEwOt/xoAsOJh7vwSm0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-05-11 13:48 ` Linus Walleij
2017-04-28 8:49 ` Linus Walleij
2017-04-28 13:50 ` Chris Brandt
2017-04-27 8:42 ` [PATCH v5 00/10] Renesas RZ/A1 pin and gpio controller Geert Uytterhoeven
2017-04-28 5:22 ` Simon Horman
2017-04-28 7:24 ` jmondi
2017-04-28 7:30 ` Geert Uytterhoeven
2017-04-28 7:31 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170508160120.GB25206@w540 \
--to=jacopo@jmondi.org \
--cc=Chris.Brandt@renesas.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jacopo+renesas@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).