From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Brendan Higgins <brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: "Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Thomas Gleixner" <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
"Jason Cooper" <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
"Marc Zyngier" <marc.zyngier-5wv7dgnIgG8@public.gmane.org>,
"Joel Stanley" <joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>,
"Vladimir Zapolskiy" <vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>,
"Kachalov Anton" <mouse-Pma6HLj0uuo@public.gmane.org>,
"Cédric Le Goater" <clg-Bxea+6Xhats@public.gmane.org>,
"Benjamin Herrenschmidt"
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Linux Kernel Mailing List"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"OpenBMC Maillist"
<openbmc-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
"Ryan Chen" <ryan_chen-SAlXDmAnmOAqDJ6do+/SaQ@public.gmane.org>
Subject: Re: [PATCH v7 4/5] i2c: aspeed: added driver for Aspeed I2C
Date: Tue, 9 May 2017 04:21:01 +0200 [thread overview]
Message-ID: <20170509022101.GA2562@tetsubishi> (raw)
In-Reply-To: <CAFd5g47VGa=wqeyg5tFjB5xD=YsTuP27hLN3-ZM62MJD8dCP_Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
> > + /* TODO: provide device tree option for multi-master mode.
> > */
>
>
> I am curious what everyone thinks about this. It seemed that, earlier on,
> people did not like me disabling multi-master mode, but I think that it
> would make bus recovery not work as well. Given that, I think it makes the
> most sense to provide a device tree option either to enable multi-master
> support or disable it. Thoughts?
Check Documentation/devicetree/bindings/i2c/i2c.txt, there is a
"multi-master" property already which I think you could use here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-05-09 2:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 18:18 [PATCH v7 0/5] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins
[not found] ` <20170424181818.2754-1-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-04-24 18:18 ` [PATCH v7 1/5] irqchip/aspeed-i2c-ic: binding docs for Aspeed I2C Interrupt Controller Brendan Higgins
[not found] ` <20170424181818.2754-2-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-04-28 18:19 ` Rob Herring
2017-04-24 18:18 ` [PATCH v7 2/5] irqchip/aspeed-i2c-ic: Add I2C IRQ controller for Aspeed Brendan Higgins
2017-04-24 18:18 ` [PATCH v7 5/5] i2c: aspeed: added slave support for Aspeed I2C driver Brendan Higgins
2017-04-25 8:35 ` Brendan Higgins
2017-04-24 18:18 ` [PATCH v7 3/5] i2c: aspeed: added documentation " Brendan Higgins
2017-04-28 18:21 ` Rob Herring
2017-04-24 18:18 ` [PATCH v7 4/5] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins
2017-04-25 2:21 ` Benjamin Herrenschmidt
2017-04-25 8:00 ` Brendan Higgins
2017-05-08 23:28 ` Brendan Higgins
[not found] ` <CAFd5g47VGa=wqeyg5tFjB5xD=YsTuP27hLN3-ZM62MJD8dCP_Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-09 2:21 ` Wolfram Sang [this message]
2017-05-09 7:15 ` Benjamin Herrenschmidt
2017-05-08 23:34 ` Brendan Higgins
[not found] ` <20170424181818.2754-5-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-05-12 7:02 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170509022101.GA2562@tetsubishi \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
--cc=brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=clg-Bxea+6Xhats@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
--cc=joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marc.zyngier-5wv7dgnIgG8@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mouse-Pma6HLj0uuo@public.gmane.org \
--cc=openbmc-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=ryan_chen-SAlXDmAnmOAqDJ6do+/SaQ@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).