From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH][v2] arm64: Add flash node for ls1088a qds and rdb
Date: Wed, 10 May 2017 09:20:58 +0800 [thread overview]
Message-ID: <20170510012057.GB5833@dragon> (raw)
In-Reply-To: <1493962448-10888-1-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>
On Fri, May 05, 2017 at 11:04:08AM +0530, Prabhakar Kushwaha wrote:
> LS1088AQDS consist of NOR, NAND and FPGA connected over IFC
> LS1088ARDB consist of NAND and FPGA connected over IFC.
>
> So add flash information in ifc node of device tree.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>
> ---
> changes for v2: Incorporated Shawn's comments
>
>
> arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts | 25 +++++++++++++++++++++++
> arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 17 +++++++++++++++
> arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 4 ----
> 3 files changed, 42 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts
> index 8c3cae5..f536ca9 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts
> @@ -110,6 +110,31 @@
> };
> };
>
> +&ifc {
> + status = "okay";
> +
> + ranges = <0 0 0x5 0x80000000 0x08000000
> + 2 0 0x5 0x30000000 0x00010000
> + 3 0 0x5 0x20000000 0x00010000>;
We usually have 'status' be the last one in property list, and also
newline in the middle of property list is generally unneeded.
ranges = <0 0 0x5 0x80000000 0x08000000
2 0 0x5 0x30000000 0x00010000
3 0 0x5 0x20000000 0x00010000>;
status = "okay";
> +
> + nor@0,0 {
> + compatible = "cfi-flash";
> + reg = <0x0 0x0 0x8000000>;
> + bank-width = <2>;
> + device-width = <1>;
> + };
> +
> + nand@2,0 {
> + compatible = "fsl,ifc-nand";
> + reg = <0x2 0x0 0x10000>;
> + };
> +
> + fpga: board-control@3,0 {
> + compatible = "fsl,ls1088aqds-fpga", "fsl,fpga-qixis";
> + reg = <0x3 0x0 0x0000100>;
> + };
> +};
> +
> &duart0 {
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> index 8a04fbb..3f79610 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> @@ -94,6 +94,23 @@
> };
> };
>
> +&ifc {
> + status = "okay";
> +
> + ranges = <0 0 0x5 0x30000000 0x00010000
> + 2 0 0x5 0x20000000 0x00010000>;
Ditto
> +
> + nand@0,0 {
> + compatible = "fsl,ifc-nand";
> + reg = <0x0 0x0 0x10000>;
> + };
> +
> + fpga: board-control@2,0 {
> + compatible = "fsl,ls1088ardb-fpga", "fsl,fpga-qixis";
> + reg = <0x2 0x0 0x0000100>;
> + };
> +};
> +
> &duart0 {
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index 2946fd7..9f6bcb4 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -217,10 +217,6 @@
> #address-cells = <2>;
> #size-cells = <1>;
>
> - ranges = <0 0 0x5 0x80000000 0x08000000
> - 2 0 0x5 0x30000000 0x00010000
> - 3 0 0x5 0x20000000 0x00010000>;
> - status = "disabled";
The 'status' line should be kept.
Shawn
> };
>
> i2c0: i2c@2000000 {
> --
> 2.7.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-05-10 1:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 5:34 [PATCH][v2] arm64: Add flash node for ls1088a qds and rdb Prabhakar Kushwaha
[not found] ` <1493962448-10888-1-git-send-email-prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org>
2017-05-10 1:20 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170510012057.GB5833@dragon \
--to=shawnguo-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).