* [PATCH] arm64: dts: ls1088a: update the sata node
@ 2017-05-08 3:13 Yuantian Tang
[not found] ` <1494213209-39673-1-git-send-email-andy.tang-3arQi8VN3Tc@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Yuantian Tang @ 2017-05-08 3:13 UTC (permalink / raw)
To: shawnguo-DgEjT+Ai2ygdnm+yROfE0A
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
catalin.marinas-5wv7dgnIgG8, will.deacon-5wv7dgnIgG8,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Yuantian Tang
1. Sata ecc should be disabled due to a erratum.
Provide the ecc register address for driver to use.
2. Enable dma coherence operation
Signed-off-by: Tang Yuantian <andy.tang-3arQi8VN3Tc@public.gmane.org>
---
arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
index 2946fd7..90edd76 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
@@ -265,10 +265,13 @@
sata: sata@3200000 {
compatible = "fsl,ls1088a-ahci", "fsl,ls1043a-ahci";
- reg = <0x0 0x3200000 0x0 0x10000>;
+ reg = <0x0 0x3200000 0x0 0x10000>,
+ <0x0 0x20140520 0x0 0x4>;
+ reg-names = "ahci", "sata-ecc";
interrupts = <0 133 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clockgen 4 3>;
status = "disabled";
+ dma-coherent;
};
};
--
2.1.0.27.g96db324
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1494213209-39673-1-git-send-email-andy.tang-3arQi8VN3Tc@public.gmane.org>]
* Re: [PATCH] arm64: dts: ls1088a: update the sata node [not found] ` <1494213209-39673-1-git-send-email-andy.tang-3arQi8VN3Tc@public.gmane.org> @ 2017-05-11 7:35 ` Shawn Guo 2017-05-11 7:57 ` Andy Tang 0 siblings, 1 reply; 3+ messages in thread From: Shawn Guo @ 2017-05-11 7:35 UTC (permalink / raw) To: Yuantian Tang Cc: mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA, catalin.marinas-5wv7dgnIgG8, will.deacon-5wv7dgnIgG8, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Mon, May 08, 2017 at 11:13:29AM +0800, Yuantian Tang wrote: > 1. Sata ecc should be disabled due to a erratum. > Provide the ecc register address for driver to use. This is a bit confusing. Are you saying that the ECC register address is provided in DT for SATA driver to disable ECC function? > 2. Enable dma coherence operation > > Signed-off-by: Tang Yuantian <andy.tang-3arQi8VN3Tc@public.gmane.org> > --- > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > index 2946fd7..90edd76 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > @@ -265,10 +265,13 @@ > > sata: sata@3200000 { > compatible = "fsl,ls1088a-ahci", "fsl,ls1043a-ahci"; > - reg = <0x0 0x3200000 0x0 0x10000>; > + reg = <0x0 0x3200000 0x0 0x10000>, > + <0x0 0x20140520 0x0 0x4>; > + reg-names = "ahci", "sata-ecc"; > interrupts = <0 133 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&clockgen 4 3>; > status = "disabled"; > + dma-coherent; Please add it above 'status' line, which we generally keep at the bottom of property list. Shawn > }; > }; > > -- > 2.1.0.27.g96db324 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] arm64: dts: ls1088a: update the sata node 2017-05-11 7:35 ` Shawn Guo @ 2017-05-11 7:57 ` Andy Tang 0 siblings, 0 replies; 3+ messages in thread From: Andy Tang @ 2017-05-11 7:57 UTC (permalink / raw) To: Shawn Guo Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Hi Shawn, Please see my reply inline. > -----Original Message----- > From: Shawn Guo [mailto:shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org] > Sent: Thursday, May 11, 2017 3:35 PM > To: Andy Tang <andy.tang-3arQi8VN3Tc@public.gmane.org> > Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org; devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; > catalin.marinas-5wv7dgnIgG8@public.gmane.org; will.deacon-5wv7dgnIgG8@public.gmane.org; robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Subject: Re: [PATCH] arm64: dts: ls1088a: update the sata node > > On Mon, May 08, 2017 at 11:13:29AM +0800, Yuantian Tang wrote: > > 1. Sata ecc should be disabled due to a erratum. > > Provide the ecc register address for driver to use. > > This is a bit confusing. Are you saying that the ECC register address is > provided in DT for SATA driver to disable ECC function? > Yes, we have a ECC register to control all the IP's ecc status. This ECC register doesn't belong to any IP block. > > 2. Enable dma coherence operation > > > > Signed-off-by: Tang Yuantian <andy.tang-3arQi8VN3Tc@public.gmane.org> > > --- > > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > > b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > > index 2946fd7..90edd76 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > > @@ -265,10 +265,13 @@ > > > > sata: sata@3200000 { > > compatible = "fsl,ls1088a-ahci", "fsl,ls1043a-ahci"; > > - reg = <0x0 0x3200000 0x0 0x10000>; > > + reg = <0x0 0x3200000 0x0 0x10000>, > > + <0x0 0x20140520 0x0 0x4>; > > + reg-names = "ahci", "sata-ecc"; > > interrupts = <0 133 IRQ_TYPE_LEVEL_HIGH>; > > clocks = <&clockgen 4 3>; > > status = "disabled"; > > + dma-coherent; > > Please add it above 'status' line, which we generally keep at the bottom of > property list. > OK, Will resend this patch. Thanks, Andy > Shawn > > > }; > > }; > > > > -- > > 2.1.0.27.g96db324 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-11 7:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-08 3:13 [PATCH] arm64: dts: ls1088a: update the sata node Yuantian Tang
[not found] ` <1494213209-39673-1-git-send-email-andy.tang-3arQi8VN3Tc@public.gmane.org>
2017-05-11 7:35 ` Shawn Guo
2017-05-11 7:57 ` Andy Tang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).