[PATCH v2] arm64: dts: ls1088a: update the sata node

[PATCH v2] arm64: dts: ls1088a: update the sata node

[Yuantian Tang]

1. Sata ecc should be disabled due to a erratum.
Provide the ecc register address for driver to use.
2. Enable dma coherence operation

Signed-off-by: Tang Yuantian <andy.tang-3arQi8VN3Tc@public.gmane.org>
---
v2:
	- move dma-coherent property above status

 arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
index 2946fd7..caecd14 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
@@ -265,9 +265,12 @@
 
 		sata: sata@3200000 {
 			compatible = "fsl,ls1088a-ahci", "fsl,ls1043a-ahci";
-			reg = <0x0 0x3200000 0x0 0x10000>;
+			reg = <0x0 0x3200000 0x0 0x10000>,
+				<0x0 0x20140520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
 			interrupts = <0 133 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clockgen 4 3>;
+			dma-coherent;
 			status = "disabled";
 		};
 	};
-- 
2.1.0.27.g96db324

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] arm64: dts: ls1088a: Add TMU device tree support

[Yuantian Tang]

Add nodes and properties for thermal management support.

Signed-off-by: Tang Yuantian <andy.tang-3arQi8VN3Tc@public.gmane.org>
---
 arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 89 ++++++++++++++++++++++++++
 1 file changed, 89 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
index caecd14..53dc1c1 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
@@ -44,6 +44,7 @@
  *     OTHER DEALINGS IN THE SOFTWARE.
  */
 #include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/thermal/thermal.h>
 
 / {
 	compatible = "fsl,ls1088a";
@@ -61,6 +62,7 @@
 			compatible = "arm,cortex-a53";
 			reg = <0x0>;
 			clocks = <&clockgen 1 0>;
+			#cooling-cells = <2>;
 		};
 
 		cpu1: cpu@1 {
@@ -89,6 +91,7 @@
 			compatible = "arm,cortex-a53";
 			reg = <0x100>;
 			clocks = <&clockgen 1 1>;
+			#cooling-cells = <2>;
 		};
 
 		cpu5: cpu@101 {
@@ -273,6 +276,92 @@
 			dma-coherent;
 			status = "disabled";
 		};
+
+		tmu: tmu@1f80000 {
+			compatible = "fsl,qoriq-tmu";
+			reg = <0x0 0x1f80000 0x0 0x10000>;
+			interrupts = <0 23 0x4>;
+			fsl,tmu-range = <0xb0000 0x9002a 0x6004c 0x30062>;
+			fsl,tmu-calibration =
+				/* Calibration data group 1 */
+				<0x00000000 0x00000026
+				0x00000001 0x0000002d
+				0x00000002 0x00000032
+				0x00000003 0x00000039
+				0x00000004 0x0000003f
+				0x00000005 0x00000046
+				0x00000006 0x0000004d
+				0x00000007 0x00000054
+				0x00000008 0x0000005a
+				0x00000009 0x00000061
+				0x0000000a 0x0000006a
+				0x0000000b 0x00000071
+				/* Calibration data group 2 */
+				0x00010000 0x00000025
+				0x00010001 0x0000002c
+				0x00010002 0x00000035
+				0x00010003 0x0000003d
+				0x00010004 0x00000045
+				0x00010005 0x0000004e
+				0x00010006 0x00000057
+				0x00010007 0x00000061
+				0x00010008 0x0000006b
+				0x00010009 0x00000076
+				/* Calibration data group 3 */
+				0x00020000 0x00000029
+				0x00020001 0x00000033
+				0x00020002 0x0000003d
+				0x00020003 0x00000049
+				0x00020004 0x00000056
+				0x00020005 0x00000061
+				0x00020006 0x0000006d
+				/* Calibration data group 4 */
+				0x00030000 0x00000021
+				0x00030001 0x0000002a
+				0x00030002 0x0000003c
+				0x00030003 0x0000004e>;
+			little-endian;
+			#thermal-sensor-cells = <1>;
+		};
+
+		thermal-zones {
+			cpu_thermal: cpu-thermal {
+				polling-delay-passive = <1000>;
+				polling-delay = <5000>;
+				thermal-sensors = <&tmu 0>;
+
+				trips {
+					cpu_alert: cpu-alert {
+						temperature = <85000>;
+						hysteresis = <2000>;
+						type = "passive";
+					};
+
+					cpu_crit: cpu-crit {
+						temperature = <95000>;
+						hysteresis = <2000>;
+						type = "critical";
+					};
+				};
+
+				cooling-maps {
+					map0 {
+						trip = <&cpu_alert>;
+						cooling-device =
+							<&cpu0 THERMAL_NO_LIMIT
+							THERMAL_NO_LIMIT>;
+					};
+
+					map1 {
+						trip = <&cpu_alert>;
+						cooling-device =
+							<&cpu4 THERMAL_NO_LIMIT
+							THERMAL_NO_LIMIT>;
+					};
+				};
+			};
+		};
+
 	};
 
 };
-- 
2.1.0.27.g96db324

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] arm64: dts: ls1088a: update the sata node

[Shawn Guo]

On Thu, May 11, 2017 at 04:01:19PM +0800, Yuantian Tang wrote:
> 1. Sata ecc should be disabled due to a erratum.
> Provide the ecc register address for driver to use.
> 2. Enable dma coherence operation
> 
> Signed-off-by: Tang Yuantian <andy.tang-3arQi8VN3Tc@public.gmane.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] arm64: dts: ls1088a: Add TMU device tree support

[Shawn Guo]

On Thu, May 11, 2017 at 04:01:20PM +0800, Yuantian Tang wrote:
> Add nodes and properties for thermal management support.
> 
> Signed-off-by: Tang Yuantian <andy.tang-3arQi8VN3Tc@public.gmane.org>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 89 ++++++++++++++++++++++++++
>  1 file changed, 89 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index caecd14..53dc1c1 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -44,6 +44,7 @@
>   *     OTHER DEALINGS IN THE SOFTWARE.
>   */
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/thermal/thermal.h>
>  
>  / {
>  	compatible = "fsl,ls1088a";
> @@ -61,6 +62,7 @@
>  			compatible = "arm,cortex-a53";
>  			reg = <0x0>;
>  			clocks = <&clockgen 1 0>;
> +			#cooling-cells = <2>;
>  		};
>  
>  		cpu1: cpu@1 {
> @@ -89,6 +91,7 @@
>  			compatible = "arm,cortex-a53";
>  			reg = <0x100>;
>  			clocks = <&clockgen 1 1>;
> +			#cooling-cells = <2>;
>  		};
>  
>  		cpu5: cpu@101 {
> @@ -273,6 +276,92 @@
>  			dma-coherent;
>  			status = "disabled";
>  		};
> +
> +		tmu: tmu@1f80000 {

We sort the devices under simple-bus in order of unit-address.  Please
respect the order when adding new devices.

Shawn

> +			compatible = "fsl,qoriq-tmu";
> +			reg = <0x0 0x1f80000 0x0 0x10000>;
> +			interrupts = <0 23 0x4>;
> +			fsl,tmu-range = <0xb0000 0x9002a 0x6004c 0x30062>;
> +			fsl,tmu-calibration =
> +				/* Calibration data group 1 */
> +				<0x00000000 0x00000026
> +				0x00000001 0x0000002d
> +				0x00000002 0x00000032
> +				0x00000003 0x00000039
> +				0x00000004 0x0000003f
> +				0x00000005 0x00000046
> +				0x00000006 0x0000004d
> +				0x00000007 0x00000054
> +				0x00000008 0x0000005a
> +				0x00000009 0x00000061
> +				0x0000000a 0x0000006a
> +				0x0000000b 0x00000071
> +				/* Calibration data group 2 */
> +				0x00010000 0x00000025
> +				0x00010001 0x0000002c
> +				0x00010002 0x00000035
> +				0x00010003 0x0000003d
> +				0x00010004 0x00000045
> +				0x00010005 0x0000004e
> +				0x00010006 0x00000057
> +				0x00010007 0x00000061
> +				0x00010008 0x0000006b
> +				0x00010009 0x00000076
> +				/* Calibration data group 3 */
> +				0x00020000 0x00000029
> +				0x00020001 0x00000033
> +				0x00020002 0x0000003d
> +				0x00020003 0x00000049
> +				0x00020004 0x00000056
> +				0x00020005 0x00000061
> +				0x00020006 0x0000006d
> +				/* Calibration data group 4 */
> +				0x00030000 0x00000021
> +				0x00030001 0x0000002a
> +				0x00030002 0x0000003c
> +				0x00030003 0x0000004e>;
> +			little-endian;
> +			#thermal-sensor-cells = <1>;
> +		};
> +
> +		thermal-zones {
> +			cpu_thermal: cpu-thermal {
> +				polling-delay-passive = <1000>;
> +				polling-delay = <5000>;
> +				thermal-sensors = <&tmu 0>;
> +
> +				trips {
> +					cpu_alert: cpu-alert {
> +						temperature = <85000>;
> +						hysteresis = <2000>;
> +						type = "passive";
> +					};
> +
> +					cpu_crit: cpu-crit {
> +						temperature = <95000>;
> +						hysteresis = <2000>;
> +						type = "critical";
> +					};
> +				};
> +
> +				cooling-maps {
> +					map0 {
> +						trip = <&cpu_alert>;
> +						cooling-device =
> +							<&cpu0 THERMAL_NO_LIMIT
> +							THERMAL_NO_LIMIT>;
> +					};
> +
> +					map1 {
> +						trip = <&cpu_alert>;
> +						cooling-device =
> +							<&cpu4 THERMAL_NO_LIMIT
> +							THERMAL_NO_LIMIT>;
> +					};
> +				};
> +			};
> +		};
> +
>  	};
>  
>  };
> -- 
> 2.1.0.27.g96db324
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] arm64: dts: ls1088a: Add TMU device tree support

[Andy Tang]

OK, I thought it is in alphabet order. Will resend it.

Regards,
Andy

> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org]
> Sent: Friday, May 12, 2017 11:30 AM
> To: Andy Tang <andy.tang-3arQi8VN3Tc@public.gmane.org>
> Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org; devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
> catalin.marinas-5wv7dgnIgG8@public.gmane.org; will.deacon-5wv7dgnIgG8@public.gmane.org; robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org;
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> Subject: Re: [PATCH] arm64: dts: ls1088a: Add TMU device tree support
> 
> On Thu, May 11, 2017 at 04:01:20PM +0800, Yuantian Tang wrote:
> > Add nodes and properties for thermal management support.
> >
> > Signed-off-by: Tang Yuantian <andy.tang-3arQi8VN3Tc@public.gmane.org>
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 89
> > ++++++++++++++++++++++++++
> >  1 file changed, 89 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > index caecd14..53dc1c1 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > @@ -44,6 +44,7 @@
> >   *     OTHER DEALINGS IN THE SOFTWARE.
> >   */
> >  #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +#include <dt-bindings/thermal/thermal.h>
> >
> >  / {
> >  	compatible = "fsl,ls1088a";
> > @@ -61,6 +62,7 @@
> >  			compatible = "arm,cortex-a53";
> >  			reg = <0x0>;
> >  			clocks = <&clockgen 1 0>;
> > +			#cooling-cells = <2>;
> >  		};
> >
> >  		cpu1: cpu@1 {
> > @@ -89,6 +91,7 @@
> >  			compatible = "arm,cortex-a53";
> >  			reg = <0x100>;
> >  			clocks = <&clockgen 1 1>;
> > +			#cooling-cells = <2>;
> >  		};
> >
> >  		cpu5: cpu@101 {
> > @@ -273,6 +276,92 @@
> >  			dma-coherent;
> >  			status = "disabled";
> >  		};
> > +
> > +		tmu: tmu@1f80000 {
> 
> We sort the devices under simple-bus in order of unit-address.  Please
> respect the order when adding new devices.
> 
> Shawn
> 
> > +			compatible = "fsl,qoriq-tmu";
> > +			reg = <0x0 0x1f80000 0x0 0x10000>;
> > +			interrupts = <0 23 0x4>;
> > +			fsl,tmu-range = <0xb0000 0x9002a 0x6004c 0x30062>;
> > +			fsl,tmu-calibration =
> > +				/* Calibration data group 1 */
> > +				<0x00000000 0x00000026
> > +				0x00000001 0x0000002d
> > +				0x00000002 0x00000032
> > +				0x00000003 0x00000039
> > +				0x00000004 0x0000003f
> > +				0x00000005 0x00000046
> > +				0x00000006 0x0000004d
> > +				0x00000007 0x00000054
> > +				0x00000008 0x0000005a
> > +				0x00000009 0x00000061
> > +				0x0000000a 0x0000006a
> > +				0x0000000b 0x00000071
> > +				/* Calibration data group 2 */
> > +				0x00010000 0x00000025
> > +				0x00010001 0x0000002c
> > +				0x00010002 0x00000035
> > +				0x00010003 0x0000003d
> > +				0x00010004 0x00000045
> > +				0x00010005 0x0000004e
> > +				0x00010006 0x00000057
> > +				0x00010007 0x00000061
> > +				0x00010008 0x0000006b
> > +				0x00010009 0x00000076
> > +				/* Calibration data group 3 */
> > +				0x00020000 0x00000029
> > +				0x00020001 0x00000033
> > +				0x00020002 0x0000003d
> > +				0x00020003 0x00000049
> > +				0x00020004 0x00000056
> > +				0x00020005 0x00000061
> > +				0x00020006 0x0000006d
> > +				/* Calibration data group 4 */
> > +				0x00030000 0x00000021
> > +				0x00030001 0x0000002a
> > +				0x00030002 0x0000003c
> > +				0x00030003 0x0000004e>;
> > +			little-endian;
> > +			#thermal-sensor-cells = <1>;
> > +		};
> > +
> > +		thermal-zones {
> > +			cpu_thermal: cpu-thermal {
> > +				polling-delay-passive = <1000>;
> > +				polling-delay = <5000>;
> > +				thermal-sensors = <&tmu 0>;
> > +
> > +				trips {
> > +					cpu_alert: cpu-alert {
> > +						temperature = <85000>;
> > +						hysteresis = <2000>;
> > +						type = "passive";
> > +					};
> > +
> > +					cpu_crit: cpu-crit {
> > +						temperature = <95000>;
> > +						hysteresis = <2000>;
> > +						type = "critical";
> > +					};
> > +				};
> > +
> > +				cooling-maps {
> > +					map0 {
> > +						trip = <&cpu_alert>;
> > +						cooling-device =
> > +							<&cpu0
> THERMAL_NO_LIMIT
> > +
> 	THERMAL_NO_LIMIT>;
> > +					};
> > +
> > +					map1 {
> > +						trip = <&cpu_alert>;
> > +						cooling-device =
> > +							<&cpu4
> THERMAL_NO_LIMIT
> > +
> 	THERMAL_NO_LIMIT>;
> > +					};
> > +				};
> > +			};
> > +		};
> > +
> >  	};
> >
> >  };
> > --
> > 2.1.0.27.g96db324
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html