devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: linux-amlogic@lists.infradead.org
Cc: "Carlo Caione" <carlo@caione.org>,
	"Kevin Hilman" <khilman@baylibre.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, "Andreas Färber" <afaerber@suse.de>,
	devicetree@vger.kernel.org, "Rob Herring" <robh@kernel.org>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>
Subject: [PATCH v2 00/18] ARM64: meson: DT cleanups
Date: Sat, 13 May 2017 16:33:19 +0200	[thread overview]
Message-ID: <20170513143337.14278-1-afaerber@suse.de> (raw)

Hello Kevin,

This series fixes several cosmetic issues, on top of your for-next branch.

Patches 3-6 rename a node, the rest should all be non-functional changes.

PLEASE STOP merging random new nodes at the bottom of DT files!
Just like it's a convention to sort new nodes by unit address, it has been
a convention to sort by-label nodes by their label. As discussed here and
elsewhere, this helps avoid merge conflicts and makes nodes easy to find.
I don't care whether we order A0 before A or after, but adding new HDMI
or CVBS nodes at the very bottom is totally out of alphabetical order.
Since my v1 you really should've known that...

Similarly, Khadas Vim shouldn't have been merged with the "bcrmf" typo.

Which proves my point that we need to fix these issues now so that they
don't keep spreading (Broken Window Theory). New boards have not been
checked for sort order, only boards already touched in v1.

Board and Makefile order affect my pending R-Box Pro patches.
Node order affects Martin's pending Bluetooth patches among others.

Patches 7-9 (had and) have no dependency, please start applying.

Thanks,
Andreas

v1 -> v2:
* Rebased (new nodes/properties added)
* Chose a different name for the misnamed Wifi nodes (Rob)
* Added patch to fix another new misnamed Wifi node
* Dropped patch fixing a trailing white line error (resolved)
* Tweaked subjects

Cc: Kevin Hilman <khilman@baylibre.com>
Cc: devicetree@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Andreas Färber (18):
  dt-bindings: arm: amlogic: Reorder boards
  arm64: dts: amlogic: Sort Makefile
  arm64: dts: meson-gxbb-vega-s95: Fix Wifi node name
  arm64: dts: meson-gxbb-p20x: Fix Wifi node name
  arm64: dts: meson-gx-p23x-q20x: Fix Wifi node name
  arm64: dts: meson-gxl-s905x-khadas-vim: Fix Wifi node name
  arm64: dts: meson-gxm-nexbox-a1: Drop UART comment
  arm64: dts: meson-gxl-s905x: Comment typo fix
  arm64: dts: meson-gxbb-wetek-hub: Reference CVBS node by label
  arm64: dts: meson-gxbb: Fix node order
  arm64: dts: meson-gxbb-odroidc2: Fix node order
  arm64: dts: meson-gxbb-vega-s95: Fix node order
  arm64: dts: meson-gxbb-nexbox-a95x: Fix node order
  arm64: dts: meson-gxbb-p20x: Fix node order
  arm64: dts: meson-gxl: Fix node order
  arm64: dts: meson-gxl-s905x-nexbox-a95x: Fix node order
  arm64: dts: meson-gxm-nexbox-a1: Fix node order
  arm64: dts: meson-gx-p23x-q20x: Fix node order

 Documentation/devicetree/bindings/arm/amlogic.txt  |  20 ++-
 arch/arm64/boot/dts/amlogic/Makefile               |   6 +-
 .../arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi |  60 ++++----
 .../boot/dts/amlogic/meson-gxbb-nexbox-a95x.dts    |  52 +++----
 .../arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 108 ++++++-------
 arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi   |  66 ++++----
 .../boot/dts/amlogic/meson-gxbb-vega-s95.dtsi      |  56 +++----
 .../boot/dts/amlogic/meson-gxbb-wetek-hub.dts      |   6 +-
 arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi        | 171 +++++++++++----------
 .../dts/amlogic/meson-gxl-s905x-khadas-vim.dts     |   2 +-
 .../dts/amlogic/meson-gxl-s905x-nexbox-a95x.dts    |  52 +++----
 arch/arm64/boot/dts/amlogic/meson-gxl-s905x.dtsi   |   2 +-
 arch/arm64/boot/dts/amlogic/meson-gxl.dtsi         |  72 ++++-----
 .../arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts |  87 ++++++-----
 14 files changed, 388 insertions(+), 372 deletions(-)

-- 
2.12.0

             reply	other threads:[~2017-05-13 14:33 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-13 14:33 Andreas Färber [this message]
2017-05-13 14:33 ` [PATCH v2 01/18] dt-bindings: arm: amlogic: Reorder boards Andreas Färber
2017-05-15  8:07   ` Neil Armstrong
     [not found]   ` <20170513143337.14278-2-afaerber-l3A5Bk7waGM@public.gmane.org>
2017-05-19  1:27     ` Rob Herring
2017-05-13 14:33 ` [PATCH v2 02/18] arm64: dts: amlogic: Sort Makefile Andreas Färber
     [not found]   ` <20170513143337.14278-3-afaerber-l3A5Bk7waGM@public.gmane.org>
2017-05-14  4:28     ` Chris Moore
     [not found]       ` <2e9efe9b-6bfe-ab69-8811-c85e1a8ec9f9-GANU6spQydw@public.gmane.org>
2017-05-14 10:06         ` Andreas Färber
2017-05-13 14:33 ` [PATCH v2 03/18] arm64: dts: meson-gxbb-vega-s95: Fix Wifi node name Andreas Färber
2017-05-15  8:17   ` Neil Armstrong
2017-05-13 14:33 ` [PATCH v2 06/18] arm64: dts: meson-gxl-s905x-khadas-vim: " Andreas Färber
2017-05-15  8:17   ` Neil Armstrong
     [not found]   ` <20170513143337.14278-7-afaerber-l3A5Bk7waGM@public.gmane.org>
2017-05-15 20:16     ` Martin Blumenstingl
2017-05-13 14:33 ` [PATCH v2 07/18] arm64: dts: meson-gxm-nexbox-a1: Drop UART comment Andreas Färber
2017-05-15  8:17   ` Neil Armstrong
2017-05-13 14:33 ` [PATCH v2 08/18] arm64: dts: meson-gxl-s905x: Comment typo fix Andreas Färber
2017-05-15  8:17   ` Neil Armstrong
2017-05-13 14:33 ` [PATCH v2 09/18] arm64: dts: meson-gxbb-wetek-hub: Reference CVBS node by label Andreas Färber
     [not found]   ` <20170513143337.14278-10-afaerber-l3A5Bk7waGM@public.gmane.org>
2017-05-15  8:17     ` Neil Armstrong
2017-05-13 14:33 ` [PATCH v2 10/18] arm64: dts: meson-gxbb: Fix node order Andreas Färber
     [not found]   ` <20170513143337.14278-11-afaerber-l3A5Bk7waGM@public.gmane.org>
2017-05-15  8:17     ` Neil Armstrong
2017-05-15 18:56       ` Andreas Färber
2017-05-13 14:33 ` [PATCH v2 11/18] arm64: dts: meson-gxbb-odroidc2: " Andreas Färber
2017-05-15  8:17   ` Neil Armstrong
     [not found] ` <20170513143337.14278-1-afaerber-l3A5Bk7waGM@public.gmane.org>
2017-05-13 14:33   ` [PATCH v2 04/18] arm64: dts: meson-gxbb-p20x: Fix Wifi node name Andreas Färber
     [not found]     ` <20170513143337.14278-5-afaerber-l3A5Bk7waGM@public.gmane.org>
2017-05-15  8:17       ` Neil Armstrong
2017-05-13 14:33   ` [PATCH v2 05/18] arm64: dts: meson-gx-p23x-q20x: " Andreas Färber
2017-05-15  8:17     ` Neil Armstrong
2017-05-13 14:33   ` [PATCH v2 12/18] arm64: dts: meson-gxbb-vega-s95: Fix node order Andreas Färber
2017-05-15  8:17     ` Neil Armstrong
2017-05-17 21:46   ` [PATCH v2 00/18] ARM64: meson: DT cleanups Kevin Hilman
     [not found]     ` <m2mvab88dh.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-05-20 15:48       ` Andreas Färber
2017-05-13 14:33 ` [PATCH v2 13/18] arm64: dts: meson-gxbb-nexbox-a95x: Fix node order Andreas Färber
     [not found]   ` <20170513143337.14278-14-afaerber-l3A5Bk7waGM@public.gmane.org>
2017-05-15  8:17     ` Neil Armstrong
2017-05-13 14:33 ` [PATCH v2 14/18] arm64: dts: meson-gxbb-p20x: " Andreas Färber
2017-05-15  8:17   ` Neil Armstrong
2017-05-13 14:33 ` [PATCH v2 15/18] arm64: dts: meson-gxl: " Andreas Färber
2017-05-15  8:17   ` Neil Armstrong
2017-05-13 14:33 ` [PATCH v2 16/18] arm64: dts: meson-gxl-s905x-nexbox-a95x: " Andreas Färber
2017-05-15  8:17   ` Neil Armstrong
2017-05-13 14:33 ` [PATCH v2 17/18] arm64: dts: meson-gxm-nexbox-a1: " Andreas Färber
2017-05-15  8:16   ` Neil Armstrong
2017-05-13 14:33 ` [PATCH v2 18/18] arm64: dts: meson-gx-p23x-q20x: " Andreas Färber
2017-05-15  8:16   ` Neil Armstrong
2017-05-15  8:16 ` [PATCH v2 00/18] ARM64: meson: DT cleanups Neil Armstrong
     [not found]   ` <36c02d8a-d3e2-4330-f600-e49a1ba680e8-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-05-15 19:10     ` Andreas Färber
     [not found]       ` <5fb0130c-473e-dc15-b60c-e5b6144031ad-l3A5Bk7waGM@public.gmane.org>
2017-05-15 20:24         ` Martin Blumenstingl
     [not found]           ` <CAFBinCA18Y0CXvu4DtDnz=zvYxpqUNA5WRK5teO_T8zTVj4FnQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-20 13:50             ` Andreas Färber
2017-05-17 22:34         ` Kevin Hilman
     [not found]           ` <m2d1b75d0i.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-05-20 13:16             ` Andreas Färber
     [not found]               ` <8b61eb79-8a63-6f74-b461-30b99ceeecea-l3A5Bk7waGM@public.gmane.org>
2017-05-25 21:22                 ` Carlo Caione

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170513143337.14278-1-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=carlo@caione.org \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).