From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Rob Herring <robh+dt@kernel.org>
Cc: Olof Johansson <olof@lixom.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Mikael Starvik <starvik@axis.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
James Hogan <james.hogan@imgtec.com>,
Ralf Baechle <ralf@linux-mips.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Frank Rowand <frowand.list@gmail.com>,
linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH] devicetree: Move include prefixes from arch to separate directory
Date: Mon, 15 May 2017 15:26:42 +0100 [thread overview]
Message-ID: <20170515142641.GU22219@n2100.armlinux.org.uk> (raw)
In-Reply-To: <CAL_JsqKLxA8K8378z4nDBkDWnwM_zBbbf9D7EPtwQ1782dydTw@mail.gmail.com>
On Mon, May 15, 2017 at 08:01:07AM -0500, Rob Herring wrote:
> I'd prefer not to mix things in scripts/dtc that aren't the import of
> dtc (yes, we do have a few other things already, but they are at least
> scripts). Couldn't this go in include/dt-bindings/ instead?
I don't think that works.
The include path used is "include", which means that we force people
to use:
#include <dt-bindings/foo.dtsi>
in their DT files. This means that we'd need to populate $topdir/include
with per-architecture symlinks on top of the 26 or so directories already
there, so that:
#include <arch/foo.dtsi>
would work. That's quite horrible, since $topdir/include is the main
include path for C headers.
I guess we could have symlinks inside include/dt-bindings, but that
makes the includes:
#include <dt-bindings/arch/foo.dtsi>
but that's rather absurd because these _aren't_ dt-binding definitions.
Maybe what we should do is:
mkdir include/dt
git mv include/dt-bindings include/dt
for arch in arch/*; do
dts=$arch/boot/dts
if [ -d $dts ]; then
a=include/dt/$(basename $arch)
ln -s $dts $a
git add $a
fi
done
... fixup scripts/Makefile.lib ...
git commit
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-05-15 14:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 13:01 [PATCH] devicetree: Move include prefixes from arch to separate directory Rob Herring
2017-05-15 14:26 ` Russell King - ARM Linux [this message]
[not found] ` <20170515142641.GU22219-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org>
2017-05-15 14:47 ` Rob Herring
[not found] ` <CAL_JsqJzoe_xNxMOZ88+k+bZ+bSK6-j30HXk0ZsFxHUqVDzwzw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-15 15:27 ` Russell King - ARM Linux
2017-05-15 15:27 ` Olof Johansson
2017-05-15 15:48 ` Russell King - ARM Linux
[not found] ` <20170515154845.GW22219-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org>
2017-05-15 17:04 ` Olof Johansson
[not found] ` <CAOesGMjrjRTBTxN8_DGp6WUJk8hy5WnzCcxi+fUz446_Uk5JwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-17 13:54 ` Masahiro Yamada
2017-05-15 15:52 ` Rob Herring
2017-05-15 16:09 ` Olof Johansson
[not found] ` <CAOesGMh3UxHPYQ7SDG7+NODuT5TnP_i23ru0ZRR-rOYxbOGe_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-15 16:40 ` Rob Herring
2017-05-17 14:22 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2017-05-13 3:34 Olof Johansson
2017-05-13 16:18 ` Heiko Stuebner
2017-05-15 12:53 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515142641.GU22219@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=heiko@sntech.de \
--cc=james.hogan@imgtec.com \
--cc=jesper.nilsson@axis.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mpe@ellerman.id.au \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=starvik@axis.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).